Regression: [DevTools] Focus does not seen on ‘Run audits’ button after clicking ‘+’ (Perform an audit) icon.
Reported by
dchau...@etouch.net,
May 25 2018
|
|||||
Issue descriptionChrome Version: 68.0.3439.0 (Official Build) Revision 1666e272389d5933c9d96ce25114aa327dfb9233-refs/branch-heads/3439@{#1} 32/64-bit. OS: Win(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.5) and Linux (14.04 LTS). What steps will reproduce the problem? 1. Launch Chrome, open DevTools and go to Audits section. 2. Run the audit by clicking on ‘Run audits’ button and wait till audit is completed. 3. Now click on ‘+’ (Perform an audit) icon at audit header and observe the focus. Actual: Focus does not seen on ‘Run audits’ button after clicking on ‘+’ (Perform an audit) icon. Expected: Focus should seen on ‘Run audits’ button after clicking on ‘+’ (Perform an audit) icon. This is a regression issue, broken in M-68, below is manual regression range: Good Build : 68.0.3433.0 (Revision : 559328) Bad Build : 68.0.3434.0 (Revision : 559775) You are probably looking for a change made after 559753(known good), but no later than 559754(first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/f536a88e25b936a34db5800f4412603de7746404..3f2dc028ad0011e5d68b17bf41870a9296181f28 Suspecting: https://chromium.googlesource.com/chromium/src/+/3f2dc028ad0011e5d68b17bf41870a9296181f28 @phulce- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Kindly review the attached screen-cast for reference. Thank you.
,
May 30 2018
Update:- Re-tested this issue on Windows (7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.5) and Linux(14.04 LTS) machines using latest Chrome Canary build# 69.0.3445.0 and fix is working as expected.. Hence adding TE-Verified labels. Please find the attached screen-cast for reference. Thanks..!
,
May 30 2018
,
May 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65df80761261cdba02aafe8c8f20535ebec0daa1 commit 65df80761261cdba02aafe8c8f20535ebec0daa1 Author: Patrick Hulce <phulce@chromium.org> Date: Thu May 31 20:40:30 2018 DevTools: Audits2 use built-in dialog overlay BUG= 845406 , 847350 , 846607 Change-Id: Id3ed220dcaf00cfbed5ba7b02e27412eab09b219 Reviewed-on: https://chromium-review.googlesource.com/1076325 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Paul Irish <paulirish@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#562528}(cherry picked from commit 3fce93a6536e0fd46e21ffb5f3635f1e544696ef) Reviewed-on: https://chromium-review.googlesource.com/1081069 Reviewed-by: Patrick Hulce <phulce@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#65} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/65df80761261cdba02aafe8c8f20535ebec0daa1/third_party/blink/renderer/devtools/front_end/audits2/Audits2Panel.js [modify] https://crrev.com/65df80761261cdba02aafe8c8f20535ebec0daa1/third_party/blink/renderer/devtools/front_end/audits2/Audits2StartView.js [modify] https://crrev.com/65df80761261cdba02aafe8c8f20535ebec0daa1/third_party/blink/renderer/devtools/front_end/audits2/Audits2StatusView.js [modify] https://crrev.com/65df80761261cdba02aafe8c8f20535ebec0daa1/third_party/blink/renderer/devtools/front_end/audits2/audits2Dialog.css [modify] https://crrev.com/65df80761261cdba02aafe8c8f20535ebec0daa1/third_party/blink/renderer/devtools/front_end/audits2/audits2StartView.css
,
Jun 5 2018
Update:- Re-tested this issue on Windows (7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.5) and Linux(14.04 LTS) machines using latest Chrome Dev build# 68.0.3440.15 and fix is working as expected.. Hence adding TE-Verified labels. Please find the attached screen-cast for reference. Thanks..! |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, May 29 2018