Regression : Transition effect is not seen properly for the sub-pages of "Content Settings".
Reported by
avsha...@etouch.net,
May 25 2018
|
|||||||||
Issue descriptionChrome Version : 68.0.3440.0 (Official Build) 05533d197c5763ecde7fa3dd551fd5ff214cec5e-refs/branch-heads/3440@{#1} 64-bit OS : Windows(7, 8, 8.1, 10) What steps will reproduce the problem? 1. Launch chrome, navigate to chrome://settings/content and click on "Cookies". 2. Observe the transition effect on "Cookies" sub-page. Actual Result : Transition effect is not seen properly for the sub-pages of "Content Settings". Expected Result : Transition effect for "Content Settings" sub-page should be smooth. This is a regression issue, broken in M-68 and will soon update other info. Good Build : 68.0.3439.0 (Revision : 561389) Bad Build : 68.0.3440.0 (Revision : 561733)
,
May 25 2018
I am able to reproduce this. Let's make sure this is fixed and merged to M68.
,
May 25 2018
,
May 26 2018
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fba7635322a3be23675c78c01b5eb22b5dfd20cb commit fba7635322a3be23675c78c01b5eb22b5dfd20cb Author: Hector Carmona <hcarmona@chromium.org> Date: Tue May 29 23:59:10 2018 WebUI - Settings: Fix animation regression caused by focus change. Issue was caused by focusing before animation had completed therefore causing the animation to end prematurely. Fix waits until animation is done before focusing back button. Fixed related issue where focus was lost for a11y when navigating back from content settings sub pages. Bug: 846596 , 847186 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id350af115fe6b82c8044872b258ee18abaa9759c Reviewed-on: https://chromium-review.googlesource.com/1074386 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#562659} [modify] https://crrev.com/fba7635322a3be23675c78c01b5eb22b5dfd20cb/chrome/browser/resources/settings/settings_page/settings_animated_pages.js [modify] https://crrev.com/fba7635322a3be23675c78c01b5eb22b5dfd20cb/chrome/browser/resources/settings/site_settings_page/site_settings_page.js
,
May 30 2018
Update : Retested above issue in latest Canary build #69.0.3445.0 on Windows(7, 8, 8.1, 10), Mac(10.12.6, 10.13.1, 10.13.5) & Linux 14.04 LTS OS and the issue is fixed. Transition animation is seen smoothly in Sub-pages of "Content settings". Kindly review an attached screen-cast for the reference. Thank you..!
,
May 31 2018
,
Jun 1 2018
Issue 847186 has been merged into this issue.
,
Jun 1 2018
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ddb57edea2419a267e743fb8619c8dc63a0fab57 commit ddb57edea2419a267e743fb8619c8dc63a0fab57 Author: Hector Carmona <hcarmona@chromium.org> Date: Fri Jun 01 22:58:13 2018 WebUI - Settings: Fix animation regression caused by focus change. Issue was caused by focusing before animation had completed therefore causing the animation to end prematurely. Fix waits until animation is done before focusing back button. Fixed related issue where focus was lost for a11y when navigating back from content settings sub pages. Bug: 846596 , 847186 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id350af115fe6b82c8044872b258ee18abaa9759c Reviewed-on: https://chromium-review.googlesource.com/1074386 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#562659}(cherry picked from commit fba7635322a3be23675c78c01b5eb22b5dfd20cb) Reviewed-on: https://chromium-review.googlesource.com/1083731 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#108} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/ddb57edea2419a267e743fb8619c8dc63a0fab57/chrome/browser/resources/settings/settings_page/settings_animated_pages.js [modify] https://crrev.com/ddb57edea2419a267e743fb8619c8dc63a0fab57/chrome/browser/resources/settings/site_settings_page/site_settings_page.js
,
Jun 2 2018
,
Jun 5 2018
Update : Retested above issue in latest Dev build #68.0.3440.15 on Windows(7, 8, 8.1, 10), Mac(10.12.6, 10.13.1, 10.13.6) & Linux (14.04 LTS) OS and the issue is fixed. Transition animation for the sub-pages of Content settings is now seen smoothly. Kindly review an attached screen-cast for the reference. Thank you..! |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by avsha...@etouch.net
, May 25 2018Owner: hcarmona@chromium.org
Status: Assigned (was: Unconfirmed)