Add separators and whitespace changes for the new Files App navigation UI to match the mocks. This is part of a project to refresh the Files App navigation UI (mocks - go/filesapp-2018-mocks).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5a68857784ac2b7cbb4836dc47c84ab77893e92 commit f5a68857784ac2b7cbb4836dc47c84ab77893e92 Author: Luciano Pacheco <lucmult@chromium.org> Date: Mon Jul 09 04:42:02 2018 Add division lines to directory tree Fix navigation item ordering and add tests for it. Add NavigationSection enum to group navigation items in 4 sections: Top, My Files, Removable and Cloud. DirectoryTree adds attribute "section-division" when the section changes between navigation items. Change MockVolumeManagerWrapper to add volumeId to label if a label isn't provided to make test code a bit shorter. Bug: 846593 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I8a8f1c80c8bfe35efc5867a35dcd34b32a8259f2 Reviewed-on: https://chromium-review.googlesource.com/1126689 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#573218} [modify] https://crrev.com/f5a68857784ac2b7cbb4836dc47c84ab77893e92/ui/file_manager/file_manager/background/js/mock_volume_manager.js [modify] https://crrev.com/f5a68857784ac2b7cbb4836dc47c84ab77893e92/ui/file_manager/file_manager/foreground/css/tree.css [modify] https://crrev.com/f5a68857784ac2b7cbb4836dc47c84ab77893e92/ui/file_manager/file_manager/foreground/js/navigation_list_model.js [modify] https://crrev.com/f5a68857784ac2b7cbb4836dc47c84ab77893e92/ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.html [modify] https://crrev.com/f5a68857784ac2b7cbb4836dc47c84ab77893e92/ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.js [modify] https://crrev.com/f5a68857784ac2b7cbb4836dc47c84ab77893e92/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f6a359563677fdf5f87552a1fc06283ca8e32ed commit 2f6a359563677fdf5f87552a1fc06283ca8e32ed Author: Luciano Pacheco <lucmult@chromium.org> Date: Wed Jul 11 02:45:37 2018 Add icon to My Files Add both icons for My Files active and inactive. Bug: 846593 , 846587 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I718f3374868686ed0aa9480deb83ebf96e9717e4 Reviewed-on: https://chromium-review.googlesource.com/1130557 Reviewed-by: Sasha Morrissey <sashab@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#574047} [modify] https://crrev.com/2f6a359563677fdf5f87552a1fc06283ca8e32ed/ui/file_manager/file_manager/foreground/css/file_types.css [add] https://crrev.com/2f6a359563677fdf5f87552a1fc06283ca8e32ed/ui/file_manager/file_manager/foreground/images/volumes/2x/my_files.png [add] https://crrev.com/2f6a359563677fdf5f87552a1fc06283ca8e32ed/ui/file_manager/file_manager/foreground/images/volumes/2x/my_files_active.png [add] https://crrev.com/2f6a359563677fdf5f87552a1fc06283ca8e32ed/ui/file_manager/file_manager/foreground/images/volumes/my_files.png [add] https://crrev.com/2f6a359563677fdf5f87552a1fc06283ca8e32ed/ui/file_manager/file_manager/foreground/images/volumes/my_files_active.png [modify] https://crrev.com/2f6a359563677fdf5f87552a1fc06283ca8e32ed/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js
Comment 1 by lucmult@chromium.org
, Jun 1 2018