New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 846586 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 841640



Sign in to add a comment

Add "Recents" and "Shortcuts" views at the top of the new Files App Nav

Project Member Reported by sashab@chromium.org, May 25 2018

Issue description

Add "Recents" view and "Shortcuts" entries to the top of the new Files App Navigation, which behave in the same way they currently do with the current navigation.

This is part of a project to refresh the Files App navigation UI (mocks - go/filesapp-2018-mocks).

 

Comment 1 by sashab@chromium.org, May 25 2018

Description: Show this description

Comment 2 by sashab@chromium.org, May 25 2018

Summary: Add "Recents" and "Shortcuts" views at the top of the new Files App Nav (was: Add “Recents” view and “Shortcuts” at the top of the new Files App Nav)
Blocking: 841640
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10195bc69820c4cc24e332655aa939e9a6cf374c

commit 10195bc69820c4cc24e332655aa939e9a6cf374c
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Wed Jul 04 07:38:01 2018

Add My Files parent for Downloads (behind flag)

Add My Files parent on navigation tree, navigation_list_model.js
creates the "My Files" entry as a EntryList and EntryListItem on
directory_tree.js is the UI element to display it.

This is a continuation of:
 * crrev.com/c/1086680
 * crrev.com/c/1116400
 * crrev.com/c/1116517

Some changes required to display EntryList:
 * isDescendantEntry: Inspect on each of EntryList's children.
 * FileManager.initializeUI: Fetch asynchronously the flag to be able
to use before displaying the navigation tree.
 * extract the switch (modelItem.type) to its own function, to be able
to reuse it.

Design doc: https://docs.google.com/document/d/1X5XSLKJd0yerL-qFhpb2z9ibUVb_W3gG_tfIV7T_Qt0

Bug:  846587 ,  846592 ,  846591 ,  846590 ,  846589 ,  846588 ,  846586 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Id8f27f09763d4478b93d52dd32e4ed851c7e448d
Reviewed-on: https://chromium-review.googlesource.com/1113258
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572507}
[modify] https://crrev.com/10195bc69820c4cc24e332655aa939e9a6cf374c/chrome/app/chromeos_strings.grdp
[add] https://crrev.com/10195bc69820c4cc24e332655aa939e9a6cf374c/chrome/app/chromeos_strings_grdp/IDS_FILE_BROWSER_MY_FILES_ROOT_LABEL.png.sha1
[modify] https://crrev.com/10195bc69820c4cc24e332655aa939e9a6cf374c/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/10195bc69820c4cc24e332655aa939e9a6cf374c/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/10195bc69820c4cc24e332655aa939e9a6cf374c/ui/file_manager/file_manager/background/js/volume_manager_impl.js
[modify] https://crrev.com/10195bc69820c4cc24e332655aa939e9a6cf374c/ui/file_manager/file_manager/common/js/util.js
[modify] https://crrev.com/10195bc69820c4cc24e332655aa939e9a6cf374c/ui/file_manager/file_manager/common/js/volume_manager_common.js
[modify] https://crrev.com/10195bc69820c4cc24e332655aa939e9a6cf374c/ui/file_manager/file_manager/foreground/js/directory_model.js
[modify] https://crrev.com/10195bc69820c4cc24e332655aa939e9a6cf374c/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/10195bc69820c4cc24e332655aa939e9a6cf374c/ui/file_manager/file_manager/foreground/js/navigation_list_model.js
[modify] https://crrev.com/10195bc69820c4cc24e332655aa939e9a6cf374c/ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.js
[modify] https://crrev.com/10195bc69820c4cc24e332655aa939e9a6cf374c/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js
[modify] https://crrev.com/10195bc69820c4cc24e332655aa939e9a6cf374c/ui/file_manager/file_manager/foreground/js/ui/location_line.js
[add] https://crrev.com/10195bc69820c4cc24e332655aa939e9a6cf374c/ui/file_manager/integration_tests/file_manager/my_files.js
[modify] https://crrev.com/10195bc69820c4cc24e332655aa939e9a6cf374c/ui/file_manager/integration_tests/file_manager_test_manifest.json

Status: Fixed (was: Assigned)

Sign in to add a comment