New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 846561 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Make FakeDriveService work with Team Drives

Project Member Reported by sashab@chromium.org, May 25 2018

Issue description

Make FakeDriveService work with Team Drives, which will allow browser tests to be written for with team drives enabled.
 

Comment 1 by sashab@chromium.org, May 25 2018

Labels: -Pri-3 CrOSFilesCategory-Testing M-69 Pri-1
What's left to do here? 

Comment 3 by sashab@chromium.org, Jun 19 2018

Let me write a test that uses FDS to add team drives and entries, and then we'll know it works for sure. I'll close this bug after that.
FWIW We already have those, unless you're talking about some JS tests.

Comment 5 by sashab@chromium.org, Jun 20 2018

Talking about JS tests, yes.
Status: Fixed (was: Assigned)
This is done, as of https://chromium-review.googlesource.com/c/chromium/src/+/1117719. :)
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f721bbdf94479979077874ff12000e39c8d40d5a

commit f721bbdf94479979077874ff12000e39c8d40d5a
Author: Sasha Morrissey <sashab@chromium.org>
Date: Mon Jul 09 03:51:05 2018

Add support for capabilities in Team Drive tests

Add support for capabilities in Team Drive tests, including a unit test
for the new method in FakeDriveService and a browser test that
transfers files between Drive, Downloads and Team Drives.

Bug: 719959, 846561 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I3935ab56cf481f3fc5e61beb12e966d21223b155
Reviewed-on: https://chromium-review.googlesource.com/1124066
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573208}
[modify] https://crrev.com/f721bbdf94479979077874ff12000e39c8d40d5a/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/f721bbdf94479979077874ff12000e39c8d40d5a/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
[modify] https://crrev.com/f721bbdf94479979077874ff12000e39c8d40d5a/components/drive/service/fake_drive_service.cc
[modify] https://crrev.com/f721bbdf94479979077874ff12000e39c8d40d5a/components/drive/service/fake_drive_service.h
[modify] https://crrev.com/f721bbdf94479979077874ff12000e39c8d40d5a/components/drive/service/fake_drive_service_unittest.cc
[modify] https://crrev.com/f721bbdf94479979077874ff12000e39c8d40d5a/ui/file_manager/file_manager/background/js/test_util.js
[modify] https://crrev.com/f721bbdf94479979077874ff12000e39c8d40d5a/ui/file_manager/file_manager/foreground/js/file_transfer_controller.js
[modify] https://crrev.com/f721bbdf94479979077874ff12000e39c8d40d5a/ui/file_manager/integration_tests/file_manager/context_menu.js
[modify] https://crrev.com/f721bbdf94479979077874ff12000e39c8d40d5a/ui/file_manager/integration_tests/file_manager/transfer.js

Sign in to add a comment