virtual/layout_ng_experimental/css3/flexbox/button.html failing on Mac |
||
Issue descriptionStarted in https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.10/47757 Dunno why SoM isn't complaining. Suspecting [LayoutNG] Make LayoutNGFlexibleBox inherit from LayoutBlock It previously inherited from LayoutNGBlockFlow, which, aside from violating is-a, prevented inline flex children from being blockified -- LayoutNGBlockFlow::AddChild does not call LayoutBlock::AddChild, which is where the blockification happens. Considered inheriting from LayoutFlexibleBox to get better baseline and intrinsic size support, but those will have to be reimplemented in LayoutNG anyway. With this change, IsLayoutNGMixin() is e ...skip... /flexbox/button-expected.png is because the underline in the link is 1 pixel shorter. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I42811edeb53e8e2a80a64d5b30bf6627e0957b7d Bug: 845235 Reviewed-on: https://chromium-review.googlesource.com/1062499 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#561661} I'll just skip it on Mac for now. I suspect it's some rebaselineing issue.
,
May 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cdd6d15244a6bf359db42291bc7ebd0f68b7ce8b commit cdd6d15244a6bf359db42291bc7ebd0f68b7ce8b Author: Trent Apted <tapted@chromium.org> Date: Fri May 25 03:35:33 2018 Skip virtual/layout_ng_experimental/css3/flexbox/button.html on Mac Maybe a rebaselining issue TBR=dgrogan@chromium.org Bug: 846557 Change-Id: I4c27cb7b162c06fcc740e1c8283d8d802bf173b7 Reviewed-on: https://chromium-review.googlesource.com/1073027 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#561756} [modify] https://crrev.com/cdd6d15244a6bf359db42291bc7ebd0f68b7ce8b/third_party/WebKit/LayoutTests/TestExpectations
,
May 29 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by tapted@chromium.org
, May 25 2018