New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 846554 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: WebRtcGetUserMediaBrowserTest.SrcObjectReassignSameObject/1



Sign in to add a comment

WebRtcGetUserMediaBrowserTest.SrcObjectReassignSameObject/1 is Flaky

Project Member Reported by Findit, May 25 2018

Issue description

Findit has detected a flake at test WebRtcGetUserMediaBrowserTest.SrcObjectReassignSameObject/1.

Culprit (70.0% confidence): https://chromium-review.googlesource.com/q/Ic7ecea4b1a6211e3c5df60d849590ee097531bfd
Regression range: None

Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyxwELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKQAWNocm9taXVtLndpbi9XaW43IFRlc3RzIChkYmcpKDEpLzY5MjI2L3Zpel9jb250ZW50X2Jyb3dzZXJ0ZXN0cy9WMlZpVW5SalIyVjBWWE5sY2sxbFpHbGhRbkp2ZDNObGNsUmxjM1F1VTNKalQySnFaV04wVW1WaGMzTnBaMjVUWVcxbFQySnFaV04wTHpFPQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM

If this result was incorrect, apply the label Test-Findit-Wrong, mark the bug as Untriaged and the component Tools>Test>Findit>Flakiness.
 
Project Member

Comment 1 by Findit, May 25 2018

Findit identified the culprit r561177 with confidence 70.0% in the config "chromium.win / Win7 Tests (dbg)(1)"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyxwELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKQAWNocm9taXVtLndpbi9XaW43IFRlc3RzIChkYmcpKDEpLzY5MjI2L3Zpel9jb250ZW50X2Jyb3dzZXJ0ZXN0cy9WMlZpVW5SalIyVjBWWE5sY2sxbFpHbGhRbkp2ZDNObGNsUmxjM1F1VTNKalQySnFaV04wVW1WaGMzTnBaMjVUWVcxbFQySnFaV04wTHpFPQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM


Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness

Comment 2 by tapted@chromium.org, May 25 2018

Cc: samans@chromium.org
Owner: fsam...@chromium.org
Culprit is a revert that relanded ~6 hours ago.

Comment 3 by tapted@chromium.org, May 25 2018

Components: Blink>Compositing
Status: Assigned (was: Available)

Comment 4 by tapted@chromium.org, May 25 2018

Cc: phoglund@chromium.org
Labels: -Sheriff-Chromium
revert -> https://chromium-review.googlesource.com/c/chromium/src/+/1073031
Project Member

Comment 5 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0449370cdf2860d764367832ed81b1746e7c3c74

commit 0449370cdf2860d764367832ed81b1746e7c3c74
Author: Trent Apted <tapted@chromium.org>
Date: Fri May 25 04:16:44 2018

Disable WebRtcGetUserMediaBrowserTest.SrcObjectReassignSameObject.

Flaky.

TBR=fsamuel@chromium.org,phoglund@chromium.org

Bug:  846554 
Change-Id: I4eb5ef90717fd417aae68ef843365ad7cafaa87f
Reviewed-on: https://chromium-review.googlesource.com/1073031
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561765}
[modify] https://crrev.com/0449370cdf2860d764367832ed81b1746e7c3c74/content/browser/webrtc/webrtc_getusermedia_browsertest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5d1d87b1315b5b2fb0f551360ee09a5a17e9513

commit c5d1d87b1315b5b2fb0f551360ee09a5a17e9513
Author: Fady Samuel <fsamuel@chromium.org>
Date: Mon Jul 16 16:00:36 2018

Revert "Disable WebRtcGetUserMediaBrowserTest.SrcObjectReassignSameObject."

This reverts commit 0449370cdf2860d764367832ed81b1746e7c3c74.

Reason for revert: The culprit patch was a revert that relanded.

Original change's description:
> Disable WebRtcGetUserMediaBrowserTest.SrcObjectReassignSameObject.
> 
> Flaky.
> 
> TBR=fsamuel@chromium.org,phoglund@chromium.org
> 
> Bug:  846554 
> Change-Id: I4eb5ef90717fd417aae68ef843365ad7cafaa87f
> Reviewed-on: https://chromium-review.googlesource.com/1073031
> Commit-Queue: Trent Apted <tapted@chromium.org>
> Reviewed-by: Trent Apted <tapted@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#561765}

TBR=tapted@chromium.org,phoglund@chromium.org,fsamuel@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  846554 
Change-Id: I3e46e97fdd6d782aa64912f46ab0ba70d3159755
Reviewed-on: https://chromium-review.googlesource.com/1138413
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575286}
[modify] https://crrev.com/c5d1d87b1315b5b2fb0f551360ee09a5a17e9513/content/browser/webrtc/webrtc_getusermedia_browsertest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment