New issue
Advanced search Search tips

Issue 846551 link

Starred by 3 users
Status: Fixed
Owner:
paulir...@chromium.org
Closed: Jul 16
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 2
Type: ----



Sign in to add a comment

http/tests/devtools/audits2/audits2-limited-run.js and 2 other(s) in webkit_layout_tests failing on chromium.webkit/WebKit Mac10.11 (dbg)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, May 25 2018 
Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of tapted@google.com

http/tests/devtools/audits2/audits2-limited-run.js and 2 other(s) in webkit_layout_tests failing on chromium.webkit/WebKit Mac10.11 (dbg)

Builders failed on: 
- WebKit Mac10.11 (dbg): 
  https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.11%20%28dbg%29


seems to have started in

https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.11%20%28dbg%29/16183



I can't really make sense of it. Maybe related to msan failures in  Issue 846545 .

https://test-results.appspot.com/data/layout_results/WebKit_Mac10_11__dbg_/16183/layout-test-results/results.html


206	206	duplicate-id: true
207	207	efficient-animated-content: false
208	208	errors-in-console: false
209		estimated-input-latency: true
209	estimated-input-latency: false
210	210	external-anchors-use-rel-noopener: true
211		first-contentful-paint: true
212		first-cpu-idle: true
213		first-meaningful-paint: true
211	first-contentful-paint: false
212	first-cpu-idle: false
213	first-meaningful-paint: false
214	214	focus-traps: false
215	215	focusable-controls: false
216	216	font-display: true


225	225	image-alt: true
226	226	image-aspect-ratio: true
227	227	input-image-alt: true
228		interactive: true
228	interactive: false
229	229	is-crawlable: true
230	230	is-on-https: true
231	231	label: true

Comment 1 by tapted@chromium.org, May 25 2018

Cc: phulce@chromium.org paulir...@chromium.org
Components: Platform>DevTools
Labels: OS-Mac OS-Windows
errors on mac and windows

they're already skipped on Linux https://cs.chromium.org/search/?q=http/tests/devtools/audits2/audits2-limited-run.js

Issue 846211 and Issue 798957

Comment 2 by mlippautz@chromium.org, May 25 2018 

I guess I am on this because of 4024aad376eea8ef01d693a89dab09585b2a4f9e. That path is not enabled at runtime, i.e., there's a an if branch at the very top that is always false on ToT.

Comment 3 by tapted@chromium.org, May 25 2018

Owner: paulir...@chromium.org
Status: Assigned (was: Available)
ah, actually I've traced it back further past some flakes to 

https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.11%20%28dbg%29/16181

suspecting

DevTools: [Audits] Roll Lighthouse to v3.0-beta

Bug: 772558, 846211
Change-Id: I4f74ea0d4a84908d2e7c4ccfe7035ee421bdf023
Reviewed-on: https://chromium-review.googlesource.com/1070532
Commit-Queue: Paul Irish <paulirish@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561412}

I'll revert.

Comment 4 by tapted@chromium.org, May 25 2018

Cc: -falken@chromium.org -mlippautz@chromium.org -keishi@chromium.org -paulir...@chromium.org -phulce@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, May 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28abe7802899b037a176426f883c750fec5a6d24

commit 28abe7802899b037a176426f883c750fec5a6d24
Author: Trent Apted <tapted@chromium.org>
Date: Fri May 25 02:13:48 2018

Revert "DevTools: [Audits] Roll Lighthouse to v3.0-beta"

This reverts commit a745fe4457a6dda2ebca843cfbb9a9ec16563805.

Bug:  846551 

Reason for revert: Suspected for failures in


* http/tests/devtools/audits2/audits2-limited-run.js
* http/tests/devtools/audits2/audits2-successful-run.js

since

https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.11%20%28dbg%29/16181

Original change's description:
> DevTools: [Audits] Roll Lighthouse to v3.0-beta
> 
> Bug: 772558, 846211
> Change-Id: I4f74ea0d4a84908d2e7c4ccfe7035ee421bdf023
> Reviewed-on: https://chromium-review.googlesource.com/1070532
> Commit-Queue: Paul Irish <paulirish@chromium.org>
> Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#561412}

TBR=pfeldman@chromium.org,paulirish@chromium.org,phulce@chromium.org

Change-Id: I71f125736ac908f37c3d90988b85de51f4fb283c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 772558, 846211
Reviewed-on: https://chromium-review.googlesource.com/1073008
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561735}
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run-expected.txt
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run-expected.txt
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/BUILD.gn
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2/Audits2Controller.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2/Audits2Panel.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2/Audits2ProtocolService.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2/Audits2ReportRenderer.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2/Audits2ReportSelector.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2/RadioSetting.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2/audits2Panel.css
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/category-renderer.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/crc-details-renderer.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/details-renderer.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/dom.js
[delete] https://crrev.com/c4d26bf432ed85aff2ac8ed238829aeacb05523a/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/performance-category-renderer.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/report-renderer.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/util.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/report-styles.css
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/templates.html
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2/module.json
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2_worker/Audits2Service.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2_worker/lighthouse/lighthouse-background.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/bindings/FileUtils.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/externs.js

Comment 6 by tapted@chromium.org, May 25 2018

Labels: -Sheriff-Chromium

Comment 7 by phulce@chromium.org, May 29 2018

Labels: ReleaseBlock-Stable M-68
Rolling LH to v3 introduced flakiness to layout tests, we'll need to land and merge the flakiness fix and then reland/merge the v3 roll.

https://chromium-review.googlesource.com/c/chromium/src/+/1070532 Landed CL
https://chromium-review.googlesource.com/c/chromium/src/+/1073008 Reverted CL
https://chromium-review.googlesource.com/c/chromium/src/+/1071883 Deflake CL
Project Member

Comment 9 by bugdroid1@chromium.org, May 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8405e18c05b9e5a1c714db1e204de6aaae3be24d

commit 8405e18c05b9e5a1c714db1e204de6aaae3be24d
Author: Paul Irish <paulirish@chromium.org>
Date: Thu May 31 02:29:50 2018

Restore "DevTools: [Audits] Roll Lighthouse to v3.0-beta"

This reverts commit 28abe7802899b037a176426f883c750fec5a6d24.

Bug: 772558, 846211, 846551 
Change-Id: Ib782b1fb5ee737f31deaa94630fb2bb1021b579b
Reviewed-on: https://chromium-review.googlesource.com/1077597
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Patrick Hulce <phulce@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563121}
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run-expected.txt
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run-expected.txt
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run.js
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/BUILD.gn
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/Audits2Controller.js
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/Audits2Panel.js
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/Audits2ProtocolService.js
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/Audits2ReportRenderer.js
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/Audits2ReportSelector.js
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/RadioSetting.js
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/audits2Panel.css
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/category-renderer.js
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/crc-details-renderer.js
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/details-renderer.js
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/dom.js
[add] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/performance-category-renderer.js
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/report-renderer.js
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/util.js
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/report-styles.css
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/templates.html
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/module.json
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2_worker/Audits2Service.js
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2_worker/lighthouse/lighthouse-background.js
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/bindings/FileUtils.js
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/externs.js

Comment 10 by abdulsyed@google.com, Jul 3 

Bulk update: M68 stable cut is scheduled for July 19th. This issue is marked as RB-Stable, so please take a look at it before. Thanks!

Comment 11 by abdulsyed@google.com, Jul 16 

Is this fixed?

Comment 12 by paulir...@chromium.org, Jul 16

Status: Fixed (was: Assigned)
yup
Project Member

Comment 13 by blocker...@chrome-infra-auth.iam.gserviceaccount.com, Jul 16

Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-68; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-68 label, otherwise remove Merge-TBD label. Thanks.

Comment 14 by paulir...@chromium.org, Jul 16

Labels: -Merge-TBD -ReleaseBlock-Stable
►

Sign in to add a comment