Make Crostini Terminal app less hacky |
|||
Issue descriptionThe Crostini Terminal is current running crosh (a v1 app) with some hacks to make it not get picked up in the shelf as crosh. We should try and avoid these hacks, for example moving crosh off the legacy app system and making separate PWAs for crosh and the terminal.
,
May 25 2018
But to be honest after hearing your explanation of the pinning fix I'm not longer sure, we should talk about it early next week. Maybe the shelf is the real hackiness, not how we've setup the terminal :/
,
May 29 2018
,
Jul 3
I noticed some other weirdness. The terminal also shows up in Chrome history, and will re-open with ctrl-shift-T from a Chrome window.
,
Nov 14
The terminal also has problems handling complex commands passed as commandline inputs i.e. running "x-terminal-emulator <some command>". See https://bugs.chromium.org/p/chromium/issues/detail?id=898111 for one manifestation of that, and the currently proposed fix for that will probably break (if they're not already broken) commands containing characters with special interpretations in URLs. Something more comprehensive should be done about this at some point.
,
Nov 14
i don't think x-terminal-emulator is related to this bug
,
Nov 14
|
|||
►
Sign in to add a comment |
|||
Comment 1 by benwells@chromium.org
, May 25 2018