Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of tapted@google.com browser_tests failing on chromium.memory/Linux ChromiumOS MSan Tests Builders failed on: - Linux ChromiumOS MSan Tests: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests
the bot is a mess... consistent browser_tests failures starting tl;dr suspecting https://chromium-review.googlesource.com/c/chromium/src/+/1069956 -> falken "shared worker: Give the renderer a factory bundle when NetworkService is enabled.". I'll revert. https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7284 WorkerDevToolsSanityTest.PauseInSharedWorkerInitialization ExtensionApiTestWithSwitch.ExtensionDebugger WorkerDevToolsSanityTest.InspectSharedWorker ExtensionApiTest.Debugger and continuing https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7290 WorkerDevToolsSanityTest.PauseInSharedWorkerInitialization ExtensionApiTest.Debugger WorkerDevToolsSanityTest.InspectSharedWorker errors are like =1==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x26931324 in is_empty ./../../base/unguessable_token.h:68:45 #1 0x26931324 in blink::IdentifiersFactory::IdFromToken(base::UnguessableToken const&) ./../../third_party/blink/renderer/core/inspector/identifiers_factory.cc:95:0 #2 0x26b81609 in blink::InspectorNetworkAgent::InspectorNetworkAgent(blink::InspectedFrames*, blink::WorkerGlobalScope*, v8_inspector::V8InspectorSession*) ./../../third_party/blink/renderer/core/inspector/inspector_network_agent.cc:1809:23 #3 0x25b52e2f in blink::WebDevToolsAgentImpl::Session::InitializeInspectorSession(WTF::String const&) ./../../third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.cc:416:24 #4 0x25b50580 in blink::WebDevToolsAgentImpl::Session::Session(blink::WebDevToolsAgentImpl*, mojo::AssociatedInterfacePtrInfo<blink::mojom::blink::DevToolsSessionHost>, mojo::AssociatedInterfaceRequest<blink::mojom::blink::DevToolsSession>, mojo::InterfaceRequest<blink::mojom::blink::DevToolsSession>, WTF::String const&) ./../../third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.cc:327:3 #5 0x25b5b406 in blink::WebDevToolsAgentImpl::AttachDevToolsSession(mojo::AssociatedInterfacePtrInfo<blink::mojom::blink::DevToolsSessionHost>, mojo::AssociatedInterfaceRequest<blink::mojom::blink::DevToolsSession>, mojo::InterfaceRequest<blink::mojom::blink::DevToolsSession>, WTF::String const&) ./../../third_party/blink/renderer/core/exported/web_dev_tools_agent_impl.cc:559:11 #6 0xf6a577c in blink::mojom::blink::DevToolsAgentStubDispatch::Accept(blink::mojom::blink::DevToolsAgent*, mojo::Message*) ./gen/third_party/blink/public/web/devtools_agent.mojom-blink.cc:175:13 #7 0x25b6b9e6 in blink::mojom::blink::DevToolsAgentStub<mojo::RawPtrImplRefTraits<blink::mojom::blink::DevToolsAgent> >::Accept(mojo::Message*) ./gen/third_party/blink/public/web/devtools_agent.mojom-blink.h:302:12 #8 0x181c394d in mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message*) ./../../mojo/public/cpp/bindings/lib/interface_endpoint_client.cc:419:32 #9 0x181c161a in mojo::FilterChain::Accept(mojo::Message*) ./../../mojo/public/cpp/bindings/lib/filter_chain.cc:40:17 #10 0x181dbc14 in mojo::internal::MultiplexRouter::ProcessIncomingMessage(mojo::internal::MultiplexRouter::MessageWrapper*, mojo::internal::MultiplexRouter::ClientCallBehavior, base::SequencedTaskRunner*) ./../../mojo/public/cpp/bindings/lib/multiplex_router.cc:865:42 #11 0x181d94de in mojo::internal::MultiplexRouter::Accept(mojo::Message*) ./../../mojo/public/cpp/bindings/lib/multiplex_router.cc:589:38 #12 0x181c161a in mojo::FilterChain::Accept(mojo::Message*) ./../../mojo/public/cpp/bindings/lib/filter_chain.cc:40:17 #13 0x181baecf in mojo::Connector::ReadSingleMessage(unsigned int*) ./../../mojo/public/cpp/bindings/lib/connector.cc:443:51 #14 0x181bd439 in mojo::Connector::ReadAllAvailableMessages() ./../../mojo/public/cpp/bindings/lib/connector.cc:472:10 #15 0x1518735b in Run ./../../base/callback.h:125:12 #16 0x1518735b in mojo::SimpleWatcher::OnHandleReady(int, unsigned int, mojo::HandleSignalsState const&) ./../../mojo/public/cpp/system/simple_watcher.cc:274:0 #17 0x13124231 in Run ./../../base/callback.h:96:12 #18 0x13124231 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) ./../../base/debug/task_annotator.cc:101:0 #19 0x126768a5 in base::sequence_manager::internal::ThreadControllerImpl::DoWork(base::sequence_manager::internal::ThreadControllerImpl::WorkType) ./../../third_party/blink/renderer/platform/scheduler/base/thread_controller_impl.cc:170:21 #20 0x13124231 in Run ./../../base/callback.h:96:12 #21 0x13124231 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) ./../../base/debug/task_annotator.cc:101:0 #22 0x131a5804 in base::MessageLoop::RunTask(base::PendingTask*) ./../../base/message_loop/message_loop.cc:319:25 Uninitialized value was stored to memory at #0 0x25dc5a47 in blink::Frame::Frame(blink::FrameClient*, blink::Page&, blink::FrameOwner*, blink::WindowProxyManager*) ./../../third_party/blink/renderer/core/frame/frame.cc:283:37 #1 0x25e1b958 in blink::LocalFrame::LocalFrame(blink::LocalFrameClient*, blink::Page&, blink::FrameOwner*, blink::InterfaceRegistry*) ./../../third_party/blink/renderer/core/frame/local_frame.cc:859:7 #2 0x25e1a612 in blink::LocalFrame::Create(blink::LocalFrameClient*, blink::Page&, blink::FrameOwner*, blink::InterfaceRegistry*) ./../../third_party/blink/renderer/core/frame/local_frame.cc:194:27 #3 0x25fd9c8a in blink::WebLocalFrameImpl::InitializeCoreFrame(blink::Page&, blink::FrameOwner*, WTF::AtomicString const&) ./../../third_party/blink/renderer/core/frame/web_local_frame_impl.cc:1809:16 #4 0x25fd841a in blink::WebLocalFrameImpl::CreateMainFrame(blink::WebView*, blink::WebFrameClient*, blink::InterfaceRegistry*, blink::WebFrame*, blink::WebString const&, blink::WebSandboxFlags) ./../../third_party/blink/renderer/core/frame/web_local_frame_impl.cc:1689:10 #5 0x2e679543 in blink::WorkerShadowPage::WorkerShadowPage(blink::WorkerShadowPage::Client*) ./../../third_party/blink/renderer/core/exported/worker_shadow_page.cc:24:11 #6 0x2e66d199 in make_unique<blink::WorkerShadowPage, blink::WebSharedWorkerImpl *> ./../../buildtools/third_party/libc++/trunk/include/memory:3114:32 #7 0x2e66d199 in blink::WebSharedWorkerImpl::WebSharedWorkerImpl(blink::WebSharedWorkerClient*) ./../../third_party/blink/renderer/core/exported/web_shared_worker_impl.cc:79:0 #8 0x2e6764ea in blink::WebSharedWorker::Create(blink::WebSharedWorkerClient*) ./../../third_party/blink/renderer/core/exported/web_shared_worker_impl.cc:392:31 #9 0x2ac0c8ea in content::EmbeddedSharedWorkerStub::EmbeddedSharedWorkerStub(mojo::StructPtr<content::mojom::SharedWorkerInfo>, bool, base::UnguessableToken const&, mojo::InterfacePtr<blink::mojom::WorkerContentSettingsProxy>, mojo::StructPtr<content::mojom::ServiceWorkerProviderInfoForSharedWorker>, mojo::AssociatedInterfacePtrInfo<network::mojom::URLLoaderFactory>, std::__1::unique_ptr<content::URLLoaderFactoryBundleInfo, std::__1::default_delete<content::URLLoaderFactoryBundleInfo> >, mojo::InterfacePtr<content::mojom::SharedWorkerHost>, mojo::InterfaceRequest<content::mojom::SharedWorker>, mojo::InterfacePtr<service_manager::mojom::InterfaceProvider>) ./../../content/renderer/shared_worker/embedded_shared_worker_stub.cc:201:11 #10 0x2a6c6d57 in content::SharedWorkerFactoryImpl::CreateSharedWorker(mojo::StructPtr<content::mojom::SharedWorkerInfo>, bool, base::UnguessableToken const&, mojo::InterfacePtr<blink::mojom::WorkerContentSettingsProxy>, mojo::StructPtr<content::mojom::ServiceWorkerProviderInfoForSharedWorker>, mojo::AssociatedInterfacePtrInfo<network::mojom::URLLoaderFactory>, std::__1::unique_ptr<content::URLLoaderFactoryBundleInfo, std::__1::default_delete<content::URLLoaderFactoryBundleInfo> >, mojo::InterfacePtr<content::mojom::SharedWorkerHost>, mojo::InterfaceRequest<content::mojom::SharedWorker>, mojo::InterfacePtr<service_manager::mojom::InterfaceProvider>) ./../../content/renderer/shared_worker/shared_worker_factory_impl.cc:37:7 #11 0x9e697b2 in content::mojom::SharedWorkerFactoryStubDispatch::Accept(content::mojom::SharedWorkerFactory*, mojo::Message*) ./gen/content/common/shared_worker/shared_worker_factory.mojom.cc:190:13 #12 0x2a6c8b66 in content::mojom::SharedWorkerFactoryStub<mojo::RawPtrImplRefTraits<content::mojom::SharedWorkerFactory> >::Accept(mojo::Message*) ./gen/content/common/shared_worker/shared_worker_factory.mojom.h:153:12 #13 0x181c394d in mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message*) ./../../mojo/public/cpp/bindings/lib/interface_endpoint_client.cc:419:32 #14 0x181c161a in mojo::FilterChain::Accept(mojo::Message*) ./../../mojo/public/cpp/bindings/lib/filter_chain.cc:40:17 #15 0x181dbc14 in mojo::internal::MultiplexRouter::ProcessIncomingMessage(mojo::internal::MultiplexRouter::MessageWrapper*, mojo::internal::MultiplexRouter::ClientCallBehavior, base::SequencedTaskRunner*) ./../../mojo/public/cpp/bindings/lib/multiplex_router.cc:865:42 #16 0x181d94de in mojo::internal::MultiplexRouter::Accept(mojo::Message*) ./../../mojo/public/cpp/bindings/lib/multiplex_router.cc:589:38 #17 0x181c161a in mojo::FilterChain::Accept(mojo::Message*) ./../../mojo/public/cpp/bindings/lib/filter_chain.cc:40:17 #18 0x181baecf in mojo::Connector::ReadSingleMessage(unsigned int*) ./../../mojo/public/cpp/bindings/lib/connector.cc:443:51 #19 0x181bd439 in mojo::Connector::ReadAllAvailableMessages() ./../../mojo/public/cpp/bindings/lib/connector.cc:472:10 #20 0x1518735b in Run ./../../base/callback.h:125:12 #21 0x1518735b in mojo::SimpleWatcher::OnHandleReady(int, unsigned int, mojo::HandleSignalsState const&) ./../../mojo/public/cpp/system/simple_watcher.cc:274:0 Uninitialized value was created by a heap allocation #0 0xac2699 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_new_delete.cc:45:35 #1 0x2e6764af in blink::WebSharedWorker::Create(blink::WebSharedWorkerClient*) ./../../third_party/blink/renderer/core/exported/web_shared_worker_impl.cc:392:27 #2 0x2ac0c8ea in content::EmbeddedSharedWorkerStub::EmbeddedSharedWorkerStub(mojo::StructPtr<content::mojom::SharedWorkerInfo>, bool, base::UnguessableToken const&, mojo::InterfacePtr<blink::mojom::WorkerContentSettingsProxy>, mojo::StructPtr<content::mojom::ServiceWorkerProviderInfoForSharedWorker>, mojo::AssociatedInterfacePtrInfo<network::mojom::URLLoaderFactory>, std::__1::unique_ptr<content::URLLoaderFactoryBundleInfo, std::__1::default_delete<content::URLLoaderFactoryBundleInfo> >, mojo::InterfacePtr<content::mojom::SharedWorkerHost>, mojo::InterfaceRequest<content::mojom::SharedWorker>, mojo::InterfacePtr<service_manager::mojom::InterfaceProvider>) ./../../content/renderer/shared_worker/embedded_shared_worker_stub.cc:201:11 #3 0x2a6c6d57 in content::SharedWorkerFactoryImpl::CreateSharedWorker(mojo::StructPtr<content::mojom::SharedWorkerInfo>, bool, base::UnguessableToken const&, mojo::InterfacePtr<blink::mojom::WorkerContentSettingsProxy>, mojo::StructPtr<content::mojom::ServiceWorkerProviderInfoForSharedWorker>, mojo::AssociatedInterfacePtrInfo<network::mojom::URLLoaderFactory>, std::__1::unique_ptr<content::URLLoaderFactoryBundleInfo, std::__1::default_delete<content::URLLoaderFactoryBundleInfo> >, mojo::InterfacePtr<content::mojom::SharedWorkerHost>, mojo::InterfaceRequest<content::mojom::SharedWorker>, mojo::InterfacePtr<service_manager::mojom::InterfaceProvider>) ./../../content/renderer/shared_worker/shared_worker_factory_impl.cc:37:7 #4 0x9e697b2 in content::mojom::SharedWorkerFactoryStubDispatch::Accept(content::mojom::SharedWorkerFactory*, mojo::Message*) ./gen/content/common/shared_worker/shared_worker_factory.mojom.cc:190:13 #5 0x2a6c8b66 in content::mojom::SharedWorkerFactoryStub<mojo::RawPtrImplRefTraits<content::mojom::SharedWorkerFactory> >::Accept(mojo::Message*) ./gen/content/common/shared_worker/shared_worker_factory.mojom.h:153:12 #6 0x181c394d in mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message*) ./../../mojo/public/cpp/bindings/lib/interface_endpoint_client.cc:419:32 #7 0x181c161a in mojo::FilterChain::Accept(mojo::Message*) ./../../mojo/public/cpp/bindings/lib/filter_chain.cc:40:17 #8 0x181dbc14 in mojo::internal::MultiplexRouter::ProcessIncomingMessage(mojo::internal::MultiplexRouter::MessageWrapper*, mojo::internal::MultiplexRouter::ClientCallBehavior, base::SequencedTaskRunner*) ./../../mojo/public/cpp/bindings/lib/multiplex_router.cc:865:42 #9 0x181d94de in mojo::internal::MultiplexRouter::Accept(mojo::Message*) ./../../mojo/public/cpp/bindings/lib/multiplex_router.cc:589:38 #10 0x181c161a in mojo::FilterChain::Accept(mojo::Message*) ./../../mojo/public/cpp/bindings/lib/filter_chain.cc:40:17 #11 0x181baecf in mojo::Connector::ReadSingleMessage(unsigned int*) ./../../mojo/public/cpp/bindings/lib/connector.cc:443:51 #12 0x181bd439 in mojo::Connector::ReadAllAvailableMessages() ./../../mojo/public/cpp/bindings/lib/connector.cc:472:10 #13 0x1518735b in Run ./../../base/callback.h:125:12 #14 0x1518735b in mojo::SimpleWatcher::OnHandleReady(int, unsigned int, mojo::HandleSignalsState const&) ./../../mojo/public/cpp/system/simple_watcher.cc:274:0 #15 0x13124231 in Run ./../../base/callback.h:96:12 #16 0x13124231 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) ./../../base/debug/task_annotator.cc:101:0 #17 0x126768a5 in base::sequence_manager::internal::ThreadControllerImpl::DoWork(base::sequence_manager::internal::ThreadControllerImpl::WorkType) ./../../third_party/blink/renderer/platform/scheduler/base/thread_controller_impl.cc:170:21 #18 0x13124231 in Run ./../../base/callback.h:96:12 #19 0x13124231 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) ./../../base/debug/task_annotator.cc:101:0 #20 0x131a5804 in base::MessageLoop::RunTask(base::PendingTask*) ./../../base/message_loop/message_loop.cc:319:25 #21 0x131a733e in DeferOrRunPendingTask ./../../base/message_loop/message_loop.cc:329:5 #22 0x131a733e in base::MessageLoop::DoWork() ./../../base/message_loop/message_loop.cc:373:0 #23 0x131adbd3 in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_default.cc:37:31 SUMMARY: MemorySanitizer: use-of-uninitialized-value (/b/s/w/ir/out/Release/browser_tests+0x26931324) Exiting
revert -> https://chromium-review.googlesource.com/c/chromium/src/+/1073007
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f904fcc9f834483e9a5a57d934b5d77636064657 commit f904fcc9f834483e9a5a57d934b5d77636064657 Author: Matt Falkenhagen <falken@chromium.org> Date: Fri May 25 06:55:00 2018 Reland "shared worker: Give the renderer a factory bundle when NetworkService is enabled." This relands r561423. Original code review: https://chromium-review.googlesource.com/1069956 The original patch had a problem because the shadow page was created before UnguessableToken. The fix is to not create the shadow page early, which was only needed in an earlier patchset to get the task runner from it. Bug: 839982 , 846545 Change-Id: Id6545d9d86a3a56a04e7f83a840d9acddd55f51b Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo TBR: kinuko, dcheng Reviewed-on: https://chromium-review.googlesource.com/1073037 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#561793} [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/content/browser/shared_worker/mock_shared_worker.cc [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/content/browser/shared_worker/mock_shared_worker.h [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/content/browser/shared_worker/shared_worker_host.cc [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/content/browser/shared_worker/shared_worker_host.h [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/content/browser/shared_worker/shared_worker_host_unittest.cc [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/content/browser/shared_worker/shared_worker_service_impl.cc [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/content/browser/shared_worker/shared_worker_service_impl.h [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/content/browser/storage_partition_impl.cc [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/content/common/shared_worker/shared_worker_factory.mojom [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/content/renderer/renderer_blink_platform_impl.cc [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/content/renderer/renderer_blink_platform_impl.h [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/content/renderer/shared_worker/embedded_shared_worker_stub.cc [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/content/renderer/shared_worker/embedded_shared_worker_stub.h [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/content/renderer/shared_worker/shared_worker_factory_impl.cc [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/content/renderer/shared_worker/shared_worker_factory_impl.h [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/third_party/blink/public/platform/DEPS [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/third_party/blink/public/platform/platform.h [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/third_party/blink/public/web/web_shared_worker.h [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/third_party/blink/renderer/core/DEPS [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/third_party/blink/renderer/core/exported/web_shared_worker_impl.cc [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/third_party/blink/renderer/core/exported/web_shared_worker_impl.h [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/third_party/blink/renderer/core/exported/worker_shadow_page.cc [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/third_party/blink/renderer/core/exported/worker_shadow_page.h [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/third_party/blink/renderer/modules/DEPS [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/third_party/blink/tools/audit_non_blink_usage.py
https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7294 is the cycle with the CL (and 6 other fixes for the messy tree :o). It ended with an exception though. Anyway, it looks like falken@ is on the case, so removing Sheriff label.
Thanks for the revert! I'm guessing it's fixed from the revert and the reland is expected to work but we can reopen if Msan fails again.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a commit 2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a Author: Olga Sharonova <olka@chromium.org> Date: Fri May 25 09:14:33 2018 Revert "Reland "shared worker: Give the renderer a factory bundle when NetworkService is enabled."" This reverts commit f904fcc9f834483e9a5a57d934b5d77636064657. Reason for revert: Suspected of causing virtual/service-worker-servicification/external/wpt/service-workers/service-worker/worker-interception-redirect.https.html failures (example: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/32483) Original change's description: > Reland "shared worker: Give the renderer a factory bundle when NetworkService is enabled." > > This relands r561423. > Original code review: https://chromium-review.googlesource.com/1069956 > > The original patch had a problem because the shadow page was created > before UnguessableToken. The fix is to not create the shadow page early, > which was only needed in an earlier patchset to get the task runner > from it. > > Bug: 839982 , 846545 > Change-Id: Id6545d9d86a3a56a04e7f83a840d9acddd55f51b > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > TBR: kinuko, dcheng > Reviewed-on: https://chromium-review.googlesource.com/1073037 > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561793} TBR=falken@chromium.org,dcheng@chromium.org,kinuko@chromium.org,nhiroki@chromium.org Change-Id: I56e491c5d74ee738c2ce6e530b7448319e14ab20 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 839982 , 846545 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1073248 Reviewed-by: Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#561815} [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/content/browser/shared_worker/mock_shared_worker.cc [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/content/browser/shared_worker/mock_shared_worker.h [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/content/browser/shared_worker/shared_worker_host.cc [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/content/browser/shared_worker/shared_worker_host.h [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/content/browser/shared_worker/shared_worker_host_unittest.cc [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/content/browser/shared_worker/shared_worker_service_impl.cc [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/content/browser/shared_worker/shared_worker_service_impl.h [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/content/browser/storage_partition_impl.cc [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/content/common/shared_worker/shared_worker_factory.mojom [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/content/renderer/renderer_blink_platform_impl.cc [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/content/renderer/renderer_blink_platform_impl.h [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/content/renderer/shared_worker/embedded_shared_worker_stub.cc [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/content/renderer/shared_worker/embedded_shared_worker_stub.h [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/content/renderer/shared_worker/shared_worker_factory_impl.cc [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/content/renderer/shared_worker/shared_worker_factory_impl.h [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/third_party/blink/public/platform/DEPS [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/third_party/blink/public/platform/platform.h [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/third_party/blink/public/web/web_shared_worker.h [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/third_party/blink/renderer/core/DEPS [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/third_party/blink/renderer/core/exported/web_shared_worker_impl.cc [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/third_party/blink/renderer/core/exported/web_shared_worker_impl.h [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/third_party/blink/renderer/core/exported/worker_shadow_page.cc [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/third_party/blink/renderer/core/exported/worker_shadow_page.h [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/third_party/blink/renderer/modules/DEPS [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/third_party/blink/tools/audit_non_blink_usage.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7e6a5626720fc556b4159f5903780a0d364b845 commit d7e6a5626720fc556b4159f5903780a0d364b845 Author: Matt Falkenhagen <falken@chromium.org> Date: Fri May 25 13:12:48 2018 Reland "shared worker: Give the renderer a factory bundle when NetworkService is enabled." This relands r561423 and r561793. Original code review: https://chromium-review.googlesource.com/1069956 Second code review: https://chromium-review.googlesource.com/1073037 This collided with the landing of the S13nSW virtual test suite. I'm relanding with an expectation for the S13nSW failure. Probably we're using NetworkService when S13nSW is on and NetworkService is off. Bug: 839982 , 846545 , 846637 Change-Id: Ib1c3122ee532cce56a040356433002a24edc5553 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo TBR: nhiroki, kinuko, dcheng Reviewed-on: https://chromium-review.googlesource.com/1072991 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#561844} [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/browser/shared_worker/mock_shared_worker.cc [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/browser/shared_worker/mock_shared_worker.h [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/browser/shared_worker/shared_worker_host.cc [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/browser/shared_worker/shared_worker_host.h [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/browser/shared_worker/shared_worker_host_unittest.cc [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/browser/shared_worker/shared_worker_service_impl.cc [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/browser/shared_worker/shared_worker_service_impl.h [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/browser/storage_partition_impl.cc [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/common/shared_worker/shared_worker_factory.mojom [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/renderer/renderer_blink_platform_impl.cc [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/renderer/renderer_blink_platform_impl.h [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/renderer/shared_worker/embedded_shared_worker_stub.cc [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/renderer/shared_worker/embedded_shared_worker_stub.h [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/renderer/shared_worker/shared_worker_factory_impl.cc [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/renderer/shared_worker/shared_worker_factory_impl.h [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/public/platform/DEPS [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/public/platform/platform.h [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/public/web/web_shared_worker.h [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/renderer/core/DEPS [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/renderer/core/exported/web_shared_worker_impl.cc [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/renderer/core/exported/web_shared_worker_impl.h [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/renderer/core/exported/worker_shadow_page.cc [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/renderer/core/exported/worker_shadow_page.h [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/renderer/modules/DEPS [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/tools/audit_non_blink_usage.py
Comment 1 by tapted@chromium.org
, May 25 2018Labels: -Infra-Troopers Type-Bug
Owner: falken@chromium.org