Fix advertisement format for ChromeOS to include version number |
|||||
Issue descriptionCurrent advertisement packet format for Cable devices only includes client ephemeral ID. Fix this to also include version number.
,
May 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4d2965a507ec86a20b302f924d440024841769d5 commit 4d2965a507ec86a20b302f924d440024841769d5 Author: Jun Choi <hongjunchoi@chromium.org> Date: Thu May 31 20:33:35 2018 Add version number to CableDiscoveryData Advertisement packet for ChromeOS and Linux includes version number to be included in the first byte of the service data. Bug: 846536 Change-Id: I56aa419b0f3fb5c56e29c776175a16ce8c9c0c55 Reviewed-on: https://chromium-review.googlesource.com/1072963 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Tim Song <tengs@chromium.org> Reviewed-by: Balazs Engedy <engedy@chromium.org> Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#563368} [modify] https://crrev.com/4d2965a507ec86a20b302f924d440024841769d5/content/browser/webauth/authenticator_type_converters.cc [modify] https://crrev.com/4d2965a507ec86a20b302f924d440024841769d5/device/fido/fido_cable_discovery.cc [modify] https://crrev.com/4d2965a507ec86a20b302f924d440024841769d5/device/fido/fido_cable_discovery.h [modify] https://crrev.com/4d2965a507ec86a20b302f924d440024841769d5/device/fido/fido_cable_discovery_unittest.cc
,
May 31 2018
,
May 31 2018
Requesting merge of https://chromium-review.googlesource.com/c/chromium/src/+/1072963 to M68.
,
Jun 1 2018
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77835d7e293a587f780411a353265ddbfec95e5d commit 77835d7e293a587f780411a353265ddbfec95e5d Author: Jun Choi <hongjunchoi@chromium.org> Date: Fri Jun 01 20:56:22 2018 Add version number to CableDiscoveryData Advertisement packet for ChromeOS and Linux includes version number to be included in the first byte of the service data. Bug: 846536 Change-Id: I56aa419b0f3fb5c56e29c776175a16ce8c9c0c55 Reviewed-on: https://chromium-review.googlesource.com/1072963 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Tim Song <tengs@chromium.org> Reviewed-by: Balazs Engedy <engedy@chromium.org> Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#563368}(cherry picked from commit 4d2965a507ec86a20b302f924d440024841769d5) Reviewed-on: https://chromium-review.googlesource.com/1082939 Reviewed-by: Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#99} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/77835d7e293a587f780411a353265ddbfec95e5d/content/browser/webauth/authenticator_type_converters.cc [modify] https://crrev.com/77835d7e293a587f780411a353265ddbfec95e5d/device/fido/fido_cable_discovery.cc [modify] https://crrev.com/77835d7e293a587f780411a353265ddbfec95e5d/device/fido/fido_cable_discovery.h [modify] https://crrev.com/77835d7e293a587f780411a353265ddbfec95e5d/device/fido/fido_cable_discovery_unittest.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by hongjunchoi@chromium.org
, May 25 2018