Stop BLE advertisement once Cable discovery is complete |
|||||
Issue descriptionCurrent BlueZ implementation does not un-register advertisement upon destruction of BluetoothAdapter scoped reference pointer. This potentially increases the advertisement queue size indeterminately. Until fix in BlueZ implementation lands, manually unregister all complete advertisements upon destruction of FidoCableDiscovery.
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7698eb35c89a9cf16b39c481a8e4c1e72fac9cea commit 7698eb35c89a9cf16b39c481a8e4c1e72fac9cea Author: Jun Choi <hongjunchoi@chromium.org> Date: Wed May 30 21:37:26 2018 Stop advertisement once after Cable discovery The current BlueZ adapter implementation for BLE advertisement does not unregister advertisements when BluetoothAdapter scoped referenece pointer is destructed. This cause BluetoothAdapter::advertisements_ queue to increase indeterminately as BluetoothAdapter is a Chrome wide singleton object. Manually unregister any ongoing advertisement once CableDiscovery is destructed. Bug: 846535 Change-Id: If7782132f99e580bfa5f6e9a0da2a116375e6b7c Reviewed-on: https://chromium-review.googlesource.com/1072929 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by: Tim Song <tengs@chromium.org> Reviewed-by: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#563003} [modify] https://crrev.com/7698eb35c89a9cf16b39c481a8e4c1e72fac9cea/device/fido/fido_cable_discovery.cc [modify] https://crrev.com/7698eb35c89a9cf16b39c481a8e4c1e72fac9cea/device/fido/fido_cable_discovery.h [modify] https://crrev.com/7698eb35c89a9cf16b39c481a8e4c1e72fac9cea/device/fido/fido_cable_discovery_unittest.cc
,
May 30 2018
,
May 30 2018
Requesting merge of https://chromium-review.googlesource.com/c/chromium/src/+/1072929 to M68.
,
May 31 2018
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6558a16ddc7d1a27df98d712f1e55e03db2d2bf commit a6558a16ddc7d1a27df98d712f1e55e03db2d2bf Author: Jun Choi <hongjunchoi@chromium.org> Date: Thu May 31 21:44:39 2018 Stop advertisement once after Cable discovery The current BlueZ adapter implementation for BLE advertisement does not unregister advertisements when BluetoothAdapter scoped referenece pointer is destructed. This cause BluetoothAdapter::advertisements_ queue to increase indeterminately as BluetoothAdapter is a Chrome wide singleton object. Manually unregister any ongoing advertisement once CableDiscovery is destructed. Bug: 846535 Change-Id: If7782132f99e580bfa5f6e9a0da2a116375e6b7c Reviewed-on: https://chromium-review.googlesource.com/1072929 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by: Tim Song <tengs@chromium.org> Reviewed-by: Balazs Engedy <engedy@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#563003}(cherry picked from commit 7698eb35c89a9cf16b39c481a8e4c1e72fac9cea) Reviewed-on: https://chromium-review.googlesource.com/1081181 Reviewed-by: Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#68} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/a6558a16ddc7d1a27df98d712f1e55e03db2d2bf/device/fido/fido_cable_discovery.cc [modify] https://crrev.com/a6558a16ddc7d1a27df98d712f1e55e03db2d2bf/device/fido/fido_cable_discovery.h [modify] https://crrev.com/a6558a16ddc7d1a27df98d712f1e55e03db2d2bf/device/fido/fido_cable_discovery_unittest.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by hongjunchoi@chromium.org
, May 25 2018