New issue
Advanced search Search tips

Issue 846508 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Build-Toolchain



Sign in to add a comment

Toolchain nightly tests need to use external Chrome source tree.

Project Member Reported by cmt...@chromium.org, May 24 2018

Issue description

Since Chrome sync'ing inside Chrome OS is currently broken for us (see https://bugs.chromium.org/p/chromium/issues/detail?id=843752) we need to use an external Chrome source tree in our nightly performance tests.

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/toolchain-utils/+/372e1642e413f6d3f0047c852db95b90f76d7e6d

commit 372e1642e413f6d3f0047c852db95b90f76d7e6d
Author: Caroline Tice <cmtice@google.com>
Date: Sat May 26 03:32:12 2018

toolchain_utils: Use external chrome source tree for telemetry.

When generating the nightly performance tests, specify an external
Chrome source tree, since Chrome sync'ing is broken inside
Chrome OS.  Also remove unnecessary code that references a file that
no longer exists.

BUG= chromium:846508 
TEST=Successfully ran nightly tests with these changes on Chrotomation2.

Change-Id: I1cba94f82ad6ffb39c941a5dc3cb8f95cb833d20
Reviewed-on: https://chromium-review.googlesource.com/1072870
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/372e1642e413f6d3f0047c852db95b90f76d7e6d/buildbot_test_toolchains.py
[modify] https://crrev.com/372e1642e413f6d3f0047c852db95b90f76d7e6d/buildbot_test_llvm.py

Comment 2 by cmt...@chromium.org, May 29 2018

Status: Verified (was: Untriaged)

Sign in to add a comment