Chrome crashes by closing tab in new window with MR dialog open and with macviews enabled. |
||||
Issue descriptionChrome Version: 68.0.3438.3 OS: Mac MR: 6818.521.0.0 *Doesn't happen when macviews flag is not enabled. *Also happens with previous component extension. What steps will reproduce the problem? (1) Enable #views-browser-windows flag (2) Open a new Chrome window (3) Open the media router dialog. (4) With the MR dialog open, close the tab (should be the only open tab in the new window) What is the expected result? New window closes. What happens instead? Chrome crashes. Uploaded Crash Report ID a4d5910b8fcce9fe Uploaded Crash Report ID 445145e43f8d48a6
,
May 25 2018
,
Jun 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1099c597d756c3675ec3ff6621ca51006fc18390 commit 1099c597d756c3675ec3ff6621ca51006fc18390 Author: Takumi Fujimoto <takumif@chromium.org> Date: Tue Jun 12 19:06:50 2018 [Media Router UI] Fix a crash in WebContentsDisplayObserverView When |widget_| becomes null, |web_contents_| becomes invalid as well. So this CL checks for |widget_| before using |web_contents_|. Bug: 843023, 846505 Change-Id: I113de199ed7b0799308c99299ee36c1acd7c8656 Reviewed-on: https://chromium-review.googlesource.com/1093419 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#566523} [modify] https://crrev.com/1099c597d756c3675ec3ff6621ca51006fc18390/chrome/browser/ui/views/media_router/web_contents_display_observer_view.cc
,
Jun 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5bc4e3a229959ab7d5ac032f9318c494c0dc846e commit 5bc4e3a229959ab7d5ac032f9318c494c0dc846e Author: Takumi Fujimoto <takumif@chromium.org> Date: Mon Jun 18 19:50:44 2018 [Media Router UI] Fix a crash in WebContentsDisplayObserverView When |widget_| becomes null, |web_contents_| becomes invalid as well. So this CL checks for |widget_| before using |web_contents_|. Bug: 843023, 846505 Change-Id: I113de199ed7b0799308c99299ee36c1acd7c8656 Reviewed-on: https://chromium-review.googlesource.com/1093419 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by: Derek Cheng <imcheng@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#566523}(cherry picked from commit 1099c597d756c3675ec3ff6621ca51006fc18390) Reviewed-on: https://chromium-review.googlesource.com/1104762 Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#409} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/5bc4e3a229959ab7d5ac032f9318c494c0dc846e/chrome/browser/ui/views/media_router/web_contents_display_observer_view.cc
,
Jun 18 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by taku...@chromium.org
, May 24 2018Status: Assigned (was: Untriaged)