New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 846501 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 732805



Sign in to add a comment

CheckOverlayCapabilities could be nicer

Project Member Reported by dcheng@chromium.org, May 24 2018

Issue description

I came across this today while reviewing something else.

The current signature is this:
  CheckOverlayCapabilities(gfx.mojom.AcceleratedWidget widget,
      array<ui.ozone.mojom.OverlaySurfaceCandidate> candidates) =>
          (gfx.mojom.AcceleratedWidget widget,
          array<ui.ozone.mojom.OverlaySurfaceCandidate> candidates,
          array<ui.ozone.mojom.OverlayStatus> status);

It's a bit odd to echo |candidate| through IPC when the caller could just make a copy and bind it directly into the return callback if desired.

One other potential issue: it looks like |candidates| and |status| should match in size. But I'm not sure that anything actually enforces that (though I'm not sure if this can lead to actual bugs either)
 
Blocking: 620927
Part of 
Blocking: 732805
Blocking: -620927
Cc: colintan@google.com
Blocking: 898680
Blocking: -898680

Sign in to add a comment