synthetic-pinch-zoom-gesture-touchscreen-zoom-in-slow-desktop.html is flaky |
||
Issue descriptionThis test is very flaky: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=nthetic_gestures%2Fsynthetic-pinch-zoom-gesture-touchscreen-zoom-in-slow-desktop.html It recently flaked on my patch with: This is a testharness.js-based test. FAIL This tests that gpuBenchmarking.pinchBy is relatively accurate when zooming in slowly for touchscreen pinch. assert_approx_equals: Zooming in slowly has approximately correct visual viewport offsetLeft. expected 266.6666666666667 +/- 170 but got 95.282470703125 Harness: the test ran to completion. This test is very recent: https://chromium.googlesource.com/chromium/src/+/8ee07434f3312777b8c2b13c0f19146c74c49d62
,
May 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2def8793495a0262ce178f864b3e25422c19e410 commit 2def8793495a0262ce178f864b3e25422c19e410 Author: Trent Apted <tapted@chromium.org> Date: Fri May 25 03:57:17 2018 Skip synthetic-pinch-zoom-gesture-touchscreen-zoom-in-slow-desktop.html everywhere Flaky. It's already skipped on Mac. TBR=bokan@chromium.org Bug: 846494 Change-Id: I91e92bdb56c82c9a26bc6ff26e81ef256f9e7f9d Reviewed-on: https://chromium-review.googlesource.com/1072224 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#561759} [modify] https://crrev.com/2def8793495a0262ce178f864b3e25422c19e410/third_party/WebKit/LayoutTests/TestExpectations
,
May 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a508dc0dbaa52dd5d45ec91be1e49d263de791c commit 7a508dc0dbaa52dd5d45ec91be1e49d263de791c Author: David Bokan <bokan@chromium.org> Date: Mon May 28 16:32:20 2018 Fix flaky synthetic_gesture pinch zoom tests The -desktop versions of these tests were using large error bounds since the offset in a synthetic pinch zoom doesn't work today. Turns out it's not consistent either. Remove the offset check altogether for these tests to deflake them. Also lower the epsilon on scale for the rest of the tests since this was causing some mild flakiness. Bug: 846494 Change-Id: Ic032da120ba9abf25a0c62c0935c713720f2898e Reviewed-on: https://chromium-review.googlesource.com/1074271 Reviewed-by: Kevin McNee <mcnee@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#562278} [modify] https://crrev.com/7a508dc0dbaa52dd5d45ec91be1e49d263de791c/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/7a508dc0dbaa52dd5d45ec91be1e49d263de791c/third_party/WebKit/LayoutTests/synthetic_gestures/synthetic-pinch-zoom-gesture.js
,
May 30 2018
Tests have been nice and green since. |
||
►
Sign in to add a comment |
||
Comment 1 by tapted@chromium.org
, May 25 2018