New issue
Advanced search Search tips

Issue 846492 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Linux CFI browser_tests broken by LocalSiteCharacteristicsDataStore tests

Project Member Reported by gab@chromium.org, May 24 2018

Issue description

Failure : https://ci.chromium.org/buildbot/chromium.memory/Linux%20CFI/8099

Culprit : https://chromium-review.googlesource.com/c/chromium/src/+/1047725 @ r561176

Log :

[ RUN      ] LocalSiteCharacteristicsDataStoreFactoryTest.EndToEnd
Xlib:  extension "RANDR" missing on display ":99".
[16999:17008:0524/142512.270473:ERROR:instance.cc(49)] Unable to locate service manifest for ui
[16999:17008:0524/142512.270515:ERROR:service_manager.cc(942)] Failed to resolve service name: ui
[16999:17034:0524/142512.314479:ERROR:bus.cc(394)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[16999:16999:0524/142512.323620:WARNING:password_store_factory.cc(250)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
(browser_tests:16999): LIBDBUSMENU-GLIB-WARNING **: Unable to get session bus: Unknown or unsupported transport 'disabled' for address 'disabled:'
[16999:16999:0524/142512.468522:WARNING:gaia_auth_fetcher.cc(902)] Could not reach Google Accounts servers: errno -11
../../chrome/browser/resource_coordinator/local_site_characteristics_data_store_factory.cc:22:12: runtime error: control flow integrity check for type 'resource_coordinator::LocalSiteCharacteristicsDataStore' failed during base-to-derived cast (vtable address 0x000000ed85e0)
0x000000ed85e0: note: vtable is of type 'resource_coordinator::LocalSiteCharacteristicsNonRecordingDataStore'
 00 00 00 00  40 44 93 0a 00 00 00 00  50 44 93 0a 00 00 00 00  00 03 7a 0c 00 00 00 00  70 44 93 0a
              ^
    #0 0xa92d488 in resource_coordinator::LocalSiteCharacteristicsDataStoreFactory::GetForProfile(Profile*) (.cfi) ./../../chrome/browser/resource_coordinator/local_site_characteristics_data_store_factory.cc:22:12
    #1 0x6cb74c0 in resource_coordinator::LocalSiteCharacteristicsDataStoreFactoryTest_EndToEnd_Test::RunTestOnMainThread() ./../../chrome/browser/resource_coordinator/local_site_characteristics_data_store_factory_browsertest.cc:73:11
    #2 0xacc7fcc in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:385:5
    #3 0xacc8c80 in void base::internal::Invoker<base::internal::BindState<void (content::BrowserTestBase::*)(), base::internal::UnretainedWrapper<content::BrowserTestBase> >, void ()>::RunImpl<void (content::BrowserTestBase::* const&)(), std::__1::tuple<base::internal::UnretainedWrapper<content::BrowserTestBase> > const&, 0ul>(void (content::BrowserTestBase::* const&&&)(), std::__1::tuple<base::internal::UnretainedWrapper<content::BrowserTestBase> > const&&&, std::__1::integer_sequence<unsigned long, 0ul>) ./../../base/bind_internal.h:621:12
    #4 0xa5efaac in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:2087:27
    #5 0xa5eeb83 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1481:18
    #6 0x898961a in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:960:13
    #7 0x898caf0 in int base::internal::Invoker<base::internal::BindState<int (content::BrowserMainLoop::*)(), base::internal::UnretainedWrapper<content::BrowserMainLoop> >, int ()>::RunImpl<int (content::BrowserMainLoop::* const&)(), std::__1::tuple<base::internal::UnretainedWrapper<content::BrowserMainLoop> > const&, 0ul>(int (content::BrowserMainLoop::* const&&&)(), std::__1::tuple<base::internal::UnretainedWrapper<content::BrowserMainLoop> > const&&&, std::__1::integer_sequence<unsigned long, 0ul>) ./../../base/bind_internal.h:621:12
    #8 0x9011dd8 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:44:18
    #9 0x8988218 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:871:25
    #10 0x898d8bc in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main_runner_impl.cc:148:15
    #11 0x8985249 in content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main.cc:47:20
    #12 0xa396d20 in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/app/content_main_runner_impl.cc:620:10
    #13 0xa397d11 in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:964:12
    #14 0xc68d15e in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:459:29
    #15 0xa395ea3 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10
    #16 0xacc7b36 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:323:3
    #17 0xa56bf4d in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:243:20
    #18 0x79b252c in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2487:3
    #19 0x79b2dec in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11
    #20 0x79b35b1 in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #21 0x79ba282 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #22 0x79b9f0c in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:4663:10
    #23 0xa583842 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:16
    #24 0xa418cc1 in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:65:38
    #25 0xacfb7bd in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:625:31
    #26 0xa4190ce in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:170:10
    #27 0xa418c3b in main.cfi ./../../chrome/test/base/browser_tests_main.cc:36:10
    #28 0x7fa7167e3f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0
    #29 0x63ca029 in _start ??:0:0

 

Comment 1 by gab@chromium.org, May 24 2018

Labels: -Pri-1 Sheriff-Chromium Pri-2
Revert incoming, dropping to P2, please remove from Sheriff queue once bot goes green.

Comment 3 by tapted@chromium.org, May 25 2018

Labels: -Sheriff-Chromium
green in https://ci.chromium.org/buildbot/chromium.memory/Linux%20CFI/8103
Project Member

Comment 4 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5131a2dd255fa69bb6963f9fcf8510940b3eb9b6

commit 5131a2dd255fa69bb6963f9fcf8510940b3eb9b6
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Fri May 25 18:07:02 2018

Add a LocalSiteCharacteristicsDataStore factory (Reland)

This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1072787 with fixes.

ps1 is the original CL, the fix is in ps2 the problem is that I'm casting a
LocalSiteCharacteristicsNonRecordingDataStore* to a LocalSiteCharacteristicsDataStore* instead of
a SiteCharacteristicsDataStore* (the common interface between the 2 classes)

Bug:  773382 ,  846492 
Change-Id: I6cad02e8ca771debc3b4b2028616dec8fbcaf521
Reviewed-on: https://chromium-review.googlesource.com/1073050
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561944}
[modify] https://crrev.com/5131a2dd255fa69bb6963f9fcf8510940b3eb9b6/chrome/browser/BUILD.gn
[modify] https://crrev.com/5131a2dd255fa69bb6963f9fcf8510940b3eb9b6/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
[modify] https://crrev.com/5131a2dd255fa69bb6963f9fcf8510940b3eb9b6/chrome/browser/resource_coordinator/local_site_characteristics_data_store.cc
[modify] https://crrev.com/5131a2dd255fa69bb6963f9fcf8510940b3eb9b6/chrome/browser/resource_coordinator/local_site_characteristics_data_store.h
[add] https://crrev.com/5131a2dd255fa69bb6963f9fcf8510940b3eb9b6/chrome/browser/resource_coordinator/local_site_characteristics_data_store_factory.cc
[add] https://crrev.com/5131a2dd255fa69bb6963f9fcf8510940b3eb9b6/chrome/browser/resource_coordinator/local_site_characteristics_data_store_factory.h
[add] https://crrev.com/5131a2dd255fa69bb6963f9fcf8510940b3eb9b6/chrome/browser/resource_coordinator/local_site_characteristics_data_store_factory_browsertest.cc
[modify] https://crrev.com/5131a2dd255fa69bb6963f9fcf8510940b3eb9b6/chrome/browser/resource_coordinator/local_site_characteristics_data_store_unittest.cc
[modify] https://crrev.com/5131a2dd255fa69bb6963f9fcf8510940b3eb9b6/chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store.cc
[modify] https://crrev.com/5131a2dd255fa69bb6963f9fcf8510940b3eb9b6/chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store.h
[modify] https://crrev.com/5131a2dd255fa69bb6963f9fcf8510940b3eb9b6/chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store_unittest.cc
[modify] https://crrev.com/5131a2dd255fa69bb6963f9fcf8510940b3eb9b6/chrome/browser/resource_coordinator/site_characteristics_data_store.h
[modify] https://crrev.com/5131a2dd255fa69bb6963f9fcf8510940b3eb9b6/chrome/test/BUILD.gn

Status: Fixed (was: Assigned)

Sign in to add a comment