Bluetooth Dialog looks incorrect with MD2 |
|||||
Issue descriptionThe Bluetooth pairing dialog on Chrome OS embeds a cr-dialog in a WebUI dialog window. Previously this worked because the dialog was filling the page with no visible gaps. The MD2 styling includes rounded corners and a top and bottom margin, which looks awkward. The solution is to separate the contents of the bluetooth pairing dialog from the dialog itself so that the contents can be directly embedded in the WebUI dialog window without the cr-dialog wrapper. This is what the Internet dialogs do.
,
May 24 2018
I see. It should be possible to override the border-radius and the height to fit the window. Not sure why the height is smaller here. cr-dialog exposes various mixins to customize its internal styling.
,
May 24 2018
The way it's currently implemented is a little awkward and inconsistent with the internet dialogs anyway. I'd prefer to separate out the dialog bits from the pairing element anyway.
,
May 24 2018
That makes sense. I was only suggesting what I think it would be a small-ish fix, in case you need to merge this to M68.
,
May 24 2018
We clearly need it in 68, it will be early in the cycle so I'm not super concerned about it. That said, extracting the button logic outside of the dialog code is kind of a PITA. I may look into styling it as you suggested.
,
May 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41591cdd39fc766f18cc65d0d33cae9e56b65307 commit 41591cdd39fc766f18cc65d0d33cae9e56b65307 Author: Steven Bennetts <stevenjb@chromium.org> Date: Fri May 25 16:52:09 2018 Style bluetooth pairing dialog correctly for MD2 Bug: 846488 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib5e5fcc8b6eb51016c0a9a0f682a4afc4c657210 Reviewed-on: https://chromium-review.googlesource.com/1072923 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#561914} [modify] https://crrev.com/41591cdd39fc766f18cc65d0d33cae9e56b65307/chrome/browser/resources/chromeos/bluetooth_pairing_dialog/bluetooth_pairing_dialog.html [modify] https://crrev.com/41591cdd39fc766f18cc65d0d33cae9e56b65307/chrome/browser/ui/webui/chromeos/bluetooth_pairing_dialog.cc [modify] https://crrev.com/41591cdd39fc766f18cc65d0d33cae9e56b65307/ui/webui/resources/cr_components/chromeos/bluetooth_dialog.html
,
May 25 2018
,
May 25 2018
,
May 26 2018
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1f32433f28dca773f8d6c09381881044d85e25e commit e1f32433f28dca773f8d6c09381881044d85e25e Author: Steven Bennetts <stevenjb@chromium.org> Date: Tue May 29 16:56:08 2018 Style bluetooth pairing dialog correctly for MD2 TBR=stevenjb@chromium.org (cherry picked from commit 41591cdd39fc766f18cc65d0d33cae9e56b65307) Bug: 846488 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib5e5fcc8b6eb51016c0a9a0f682a4afc4c657210 Reviewed-on: https://chromium-review.googlesource.com/1072923 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#561914} Reviewed-on: https://chromium-review.googlesource.com/1076676 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#23} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/e1f32433f28dca773f8d6c09381881044d85e25e/chrome/browser/resources/chromeos/bluetooth_pairing_dialog/bluetooth_pairing_dialog.html [modify] https://crrev.com/e1f32433f28dca773f8d6c09381881044d85e25e/chrome/browser/ui/webui/chromeos/bluetooth_pairing_dialog.cc [modify] https://crrev.com/e1f32433f28dca773f8d6c09381881044d85e25e/ui/webui/resources/cr_components/chromeos/bluetooth_dialog.html |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dpa...@chromium.org
, May 24 2018