New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 846478 link

Starred by 3 users
Status: Fixed
Owner:
█ acondor@chromium.org
Last visit > 30 days ago
Closed: May 2018
Cc:
█ bshe@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR

Blocking:
issue 733656



Sign in to add a comment

VR: Have separate HoverMove and TouchMove events for the UI

Project Member Reported by acondor@chromium.org, May 24 2018 
We want to differentiate between a hover move and a touch move. The initial use case is the content quad. We want to be able to use the reticle as a pointer (current behaviour) and also as a touchpad device, when the touchpad is being clicked.

Comment 1 by acondor@chromium.org, May 24 2018

Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, May 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6d36373ea745329a2ae7245a84b2e8609b5af00

commit a6d36373ea745329a2ae7245a84b2e8609b5af00
Author: Aldo Culquicondor <acondor@chromium.org>
Date: Fri May 25 14:42:36 2018

VR: Renaming OnMove to OnHoverMove

Bug:  846478 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: Id24c9d4e9123b888a2228cdf0043e51e2850e97b
Reviewed-on: https://chromium-review.googlesource.com/1073189
Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561874}
[modify] https://crrev.com/a6d36373ea745329a2ae7245a84b2e8609b5af00/chrome/browser/vr/elements/keyboard.cc
[modify] https://crrev.com/a6d36373ea745329a2ae7245a84b2e8609b5af00/chrome/browser/vr/elements/keyboard.h
[modify] https://crrev.com/a6d36373ea745329a2ae7245a84b2e8609b5af00/chrome/browser/vr/elements/platform_ui_element.cc
[modify] https://crrev.com/a6d36373ea745329a2ae7245a84b2e8609b5af00/chrome/browser/vr/elements/platform_ui_element.h
[modify] https://crrev.com/a6d36373ea745329a2ae7245a84b2e8609b5af00/chrome/browser/vr/elements/text_input_unittest.cc
[modify] https://crrev.com/a6d36373ea745329a2ae7245a84b2e8609b5af00/chrome/browser/vr/elements/ui_element.cc
[modify] https://crrev.com/a6d36373ea745329a2ae7245a84b2e8609b5af00/chrome/browser/vr/elements/ui_element.h
[modify] https://crrev.com/a6d36373ea745329a2ae7245a84b2e8609b5af00/chrome/browser/vr/elements/ui_element_unittest.cc
[modify] https://crrev.com/a6d36373ea745329a2ae7245a84b2e8609b5af00/chrome/browser/vr/keyboard_delegate.h
[modify] https://crrev.com/a6d36373ea745329a2ae7245a84b2e8609b5af00/chrome/browser/vr/model/sounds.h
[modify] https://crrev.com/a6d36373ea745329a2ae7245a84b2e8609b5af00/chrome/browser/vr/platform_ui_input_delegate.cc
[modify] https://crrev.com/a6d36373ea745329a2ae7245a84b2e8609b5af00/chrome/browser/vr/platform_ui_input_delegate.h
[modify] https://crrev.com/a6d36373ea745329a2ae7245a84b2e8609b5af00/chrome/browser/vr/test/mock_content_input_delegate.h
[modify] https://crrev.com/a6d36373ea745329a2ae7245a84b2e8609b5af00/chrome/browser/vr/test/mock_keyboard_delegate.h
[modify] https://crrev.com/a6d36373ea745329a2ae7245a84b2e8609b5af00/chrome/browser/vr/ui.cc
[modify] https://crrev.com/a6d36373ea745329a2ae7245a84b2e8609b5af00/chrome/browser/vr/ui_input_manager.cc
[modify] https://crrev.com/a6d36373ea745329a2ae7245a84b2e8609b5af00/chrome/browser/vr/ui_input_manager_unittest.cc
[modify] https://crrev.com/a6d36373ea745329a2ae7245a84b2e8609b5af00/chrome/browser/vr/ui_unittest.cc
Project Member

Comment 3 by bugdroid1@chromium.org, May 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a4236be125818dfca42600e5b2af1c3a2351da0

commit 3a4236be125818dfca42600e5b2af1c3a2351da0
Author: Aldo Culquicondor <acondor@chromium.org>
Date: Wed May 30 23:15:04 2018

VR: Adding support for touch move events in the input handler

Bug:  846478 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: If825417bb9682cfc98299df85bb3e4960001977c
Reviewed-on: https://chromium-review.googlesource.com/1073871
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563055}
[modify] https://crrev.com/3a4236be125818dfca42600e5b2af1c3a2351da0/chrome/browser/vr/elements/ui_element.cc
[modify] https://crrev.com/3a4236be125818dfca42600e5b2af1c3a2351da0/chrome/browser/vr/elements/ui_element.h
[modify] https://crrev.com/3a4236be125818dfca42600e5b2af1c3a2351da0/chrome/browser/vr/model/sounds.h
[modify] https://crrev.com/3a4236be125818dfca42600e5b2af1c3a2351da0/chrome/browser/vr/ui_input_manager.cc
[modify] https://crrev.com/3a4236be125818dfca42600e5b2af1c3a2351da0/chrome/browser/vr/ui_input_manager.h
[modify] https://crrev.com/3a4236be125818dfca42600e5b2af1c3a2351da0/chrome/browser/vr/ui_input_manager_unittest.cc

Comment 4 by acondor@chromium.org, May 31 2018

Status: Fixed (was: Started)
►

Sign in to add a comment