Offline pages SD card support |
||||
Issue descriptionTo properly support SD cards with offline pages, we should use the directory chosen in the download dialog. The download location dialog enables the user to choose whether to download files to the SD card or main memory when downloading. It is currently only enabled when the "enable-download-location" flag is set, but the downloads team plans to turn the flag on during M-68. Since offline pages should act like downloads, if the user chooses a directory for downloads, offline pages should use the same directory. This change will enable using the downloads directory, if set, once the offline page sharing flag is activiated. We plan to activate the flag in M-68 A future change will also show the download location dialog when downloading an offline page. https://chromium-review.googlesource.com/c/chromium/src/+/1069423
,
May 26 2018
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 30 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 30 2018
It turns out no merge is required after all, the change was checked in before branch point. Removing the merge-approved tag.
,
Jun 4 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by petewil@chromium.org
, May 25 2018