New issue
Advanced search Search tips

Issue 846453 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Support safe browsing count in enterprise reporting API

Project Member Reported by zmin@chromium.org, May 24 2018

Issue description

Support safe browsing count in enterprise reporting API
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f52452e280d993517846feb53a786255e3cedf3e

commit f52452e280d993517846feb53a786255e3cedf3e
Author: Owen Min <zmin@chromium.org>
Date: Mon May 28 16:12:45 2018

Support safe browsing count in enterprise report API.

The API now accepts safe browsing warning count and safe browsing warning
click through count.

Bug:  846453 ,  832907 
Change-Id: Ied5eec64ab71f8fe3ef2cb65efd2f43bfceb3a68
Reviewed-on: https://chromium-review.googlesource.com/1072515
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562274}
[modify] https://crrev.com/f52452e280d993517846feb53a786255e3cedf3e/chrome/browser/extensions/api/enterprise_reporting_private/chrome_desktop_report_request_helper.cc
[modify] https://crrev.com/f52452e280d993517846feb53a786255e3cedf3e/chrome/browser/extensions/api/enterprise_reporting_private/chrome_desktop_report_request_helper_unittest.cc

Comment 2 by zmin@chromium.org, May 29 2018

Labels: Merge-Request-68
This CL needs to be merged into 68 for TT, it's covered with unittest and verified in Canary (69.0.3444.0)


Project Member

Comment 3 by sheriffbot@chromium.org, May 30 2018

Labels: -Merge-Request-68 Hotlist-Merge-Approved Merge-Approved-68
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, May 30 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fc760d3c84af035465535aa1bff0f490124b824

commit 2fc760d3c84af035465535aa1bff0f490124b824
Author: Owen Min <zmin@chromium.org>
Date: Wed May 30 19:22:12 2018

Merge "Support safe browsing count in enterprise report API." to 68.

The API now accepts safe browsing warning count and safe browsing warning
click through count.

Bug:  846453 ,  832907 
Change-Id: Ied5eec64ab71f8fe3ef2cb65efd2f43bfceb3a68
Reviewed-on: https://chromium-review.googlesource.com/1072515
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#562274}(cherry picked from commit f52452e280d993517846feb53a786255e3cedf3e)
Reviewed-on: https://chromium-review.googlesource.com/1079727
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#47}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/2fc760d3c84af035465535aa1bff0f490124b824/chrome/browser/extensions/api/enterprise_reporting_private/chrome_desktop_report_request_helper.cc
[modify] https://crrev.com/2fc760d3c84af035465535aa1bff0f490124b824/chrome/browser/extensions/api/enterprise_reporting_private/chrome_desktop_report_request_helper_unittest.cc

Comment 5 by zmin@chromium.org, Jun 4 2018

Status: Verified (was: Assigned)

Sign in to add a comment