New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 846441 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 634542



Sign in to add a comment

Refactor blob mime types

Project Member Reported by zakerinasab@chromium.org, May 24 2018

Issue description

In ImageDataBuffer, CanvasAsyncBlobCreator and HTMLCanvasElement blob mime types are used in plain string format. We should use named const strings instead.
 
Cc: -junov@chromium.org
Summary: Refactor blob mime types (was: Use constant strings for blob mime types)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0e722d041fe2956ab649f40b3fd715df5c353f4

commit f0e722d041fe2956ab649f40b3fd715df5c353f4
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Mon Aug 13 16:50:28 2018

Refactor blob mime types

Refactor blob mime types to avoid using string literals in the code.

TBR=dgozman@chromium.org

Bug:  846441 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I290808b25e7775931d838464f9470da36d0948bd
Reviewed-on: https://chromium-review.googlesource.com/1169524
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582615}
[modify] https://crrev.com/f0e722d041fe2956ab649f40b3fd715df5c353f4/third_party/blink/renderer/core/html/canvas/canvas_async_blob_creator.cc
[modify] https://crrev.com/f0e722d041fe2956ab649f40b3fd715df5c353f4/third_party/blink/renderer/core/html/canvas/canvas_async_blob_creator.h
[modify] https://crrev.com/f0e722d041fe2956ab649f40b3fd715df5c353f4/third_party/blink/renderer/core/html/canvas/canvas_async_blob_creator_test.cc
[modify] https://crrev.com/f0e722d041fe2956ab649f40b3fd715df5c353f4/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/f0e722d041fe2956ab649f40b3fd715df5c353f4/third_party/blink/renderer/core/inspector/inspector_audits_agent.cc
[modify] https://crrev.com/f0e722d041fe2956ab649f40b3fd715df5c353f4/third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
[modify] https://crrev.com/f0e722d041fe2956ab649f40b3fd715df5c353f4/third_party/blink/renderer/platform/graphics/graphics_types.cc
[modify] https://crrev.com/f0e722d041fe2956ab649f40b3fd715df5c353f4/third_party/blink/renderer/platform/graphics/graphics_types.h
[modify] https://crrev.com/f0e722d041fe2956ab649f40b3fd715df5c353f4/third_party/blink/renderer/platform/graphics/image_data_buffer.cc
[modify] https://crrev.com/f0e722d041fe2956ab649f40b3fd715df5c353f4/third_party/blink/renderer/platform/graphics/image_data_buffer.h
[modify] https://crrev.com/f0e722d041fe2956ab649f40b3fd715df5c353f4/third_party/blink/renderer/platform/image-encoders/DEPS
[modify] https://crrev.com/f0e722d041fe2956ab649f40b3fd715df5c353f4/third_party/blink/renderer/platform/image-encoders/image_encoder.cc
[modify] https://crrev.com/f0e722d041fe2956ab649f40b3fd715df5c353f4/third_party/blink/renderer/platform/image-encoders/image_encoder.h
[modify] https://crrev.com/f0e722d041fe2956ab649f40b3fd715df5c353f4/third_party/blink/renderer/platform/image-encoders/image_encoder_utils.cc
[modify] https://crrev.com/f0e722d041fe2956ab649f40b3fd715df5c353f4/third_party/blink/renderer/platform/image-encoders/image_encoder_utils.h

Status: Fixed (was: Assigned)

Sign in to add a comment