Chrome Version: 68.0.3438 dev build git rev 18432a5b72da87c0f47
OS: Windows 10 (gWindows)

What steps will reproduce the problem?
(1) Compile chrome with args below [1]
(2) Run Chrome --enable-logging --v=0
(3)

What is the expected result?

No NOTREACHED is hit

What happens instead?

NOTREACHED is hit


NOTREACHED here is being hit:

https://cs.chromium.org/chromium/src/chrome/browser/extensions/standard_management_policy_provider.cc?l=68

std::string
    StandardManagementPolicyProvider::GetDebugPolicyProviderName() const {
#ifdef NDEBUG
  NOTREACHED(); <--- HERE
  return std::string();
#else
  return "extension management policy controlled settings";
#endif
}

This is being called from ManagementPolicy::ApplyToProviderList

      DVLOG(1) << debug_operation_name << " of extension " << name
               << " (" << id << ")"
               << " prohibited by " << provider->GetDebugPolicyProviderName();

debug_operation_name is "Disabling"
name is "Chrome Web Store Payments"
id is "nmmhkkegccagdldgiimedpiccmgmieda"

Possibly because this is a release with dchecks enabled, and so not expecting for DVLOG(1) to be called in release?

Suggest changing the

#if defined(NDEBUG)

to

#if defined(NDEBUG) && !defined(DCHECK_ALWAYS_ON)

[1]

# Build arguments go here.
# See "gn args <out_dir> --list" for available build arguments.
use_goma = true
goma_dir = "C:\src\goma"
is_component_build = true
is_debug = false
target_cpu = "x64"
enable_nacl = false
remove_webcore_debug_symbols = true
is_chrome_branded = true
is_clang = true
dcheck_always_on = true