New issue
Advanced search Search tips

Issue 846431 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

sizes regressed on Mac

Project Member Reported by gab@chromium.org, May 24 2018

Issue description

Comment 2 by gab@chromium.org, May 24 2018

Labels: -Pri-1 Pri-2
Moving to P2 in sheriff queue with fix in CQ, thanks
Project Member

Comment 3 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/772299899d46dcfa4171b2e60e11cb097b3ddf0c

commit 772299899d46dcfa4171b2e60e11cb097b3ddf0c
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Thu May 24 20:22:53 2018

Fix a static initializer issue in LocalSiteCharImpl.

TimeDeltaToInternalRepresentation can't return a constexpr because it
uses TimeDelta::InSeconds which can't be evaluated at compile time,
remove the |kZeroIntervalInternalRepresentation| value as this doesn't
provide any clear value here.

Bug:  773382 , 846431 
Change-Id: I6b2df260742c239cc664e8476c726d4ba15731dc
Reviewed-on: https://chromium-review.googlesource.com/1072347
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561608}
[modify] https://crrev.com/772299899d46dcfa4171b2e60e11cb097b3ddf0c/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.cc
[modify] https://crrev.com/772299899d46dcfa4171b2e60e11cb097b3ddf0c/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.h

Comment 4 by gab@chromium.org, May 24 2018

Status: Fixed (was: Started)
Mac bot is green again :)

Sign in to add a comment