sizes regressed on Mac |
|||
Issue descriptionRegression range : https://chromium.googlesource.com/chromium/src/+log/45a02bc3b62e4d05dc12f69ad8da24da878fa232..0c1f782ad8993c7f4d9a390c69e651115277f71e?pretty=fuller&n=10000 Culprit https://chromium-review.googlesource.com/1047725 Patch failure on revert. sebmarchand@ is addressing on trunk
,
May 24 2018
Moving to P2 in sheriff queue with fix in CQ, thanks
,
May 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/772299899d46dcfa4171b2e60e11cb097b3ddf0c commit 772299899d46dcfa4171b2e60e11cb097b3ddf0c Author: Sebastien Marchand <sebmarchand@chromium.org> Date: Thu May 24 20:22:53 2018 Fix a static initializer issue in LocalSiteCharImpl. TimeDeltaToInternalRepresentation can't return a constexpr because it uses TimeDelta::InSeconds which can't be evaluated at compile time, remove the |kZeroIntervalInternalRepresentation| value as this doesn't provide any clear value here. Bug: 773382 , 846431 Change-Id: I6b2df260742c239cc664e8476c726d4ba15731dc Reviewed-on: https://chromium-review.googlesource.com/1072347 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#561608} [modify] https://crrev.com/772299899d46dcfa4171b2e60e11cb097b3ddf0c/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.cc [modify] https://crrev.com/772299899d46dcfa4171b2e60e11cb097b3ddf0c/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.h
,
May 24 2018
Mac bot is green again :) |
|||
►
Sign in to add a comment |
|||
Comment 1 by sebmarchand@chromium.org
, May 24 2018