Add close buttons to background tabs |
|||||||||||
Issue descriptionChrome Version: 68.0.3439.0 OS: 10.13.4 What steps will reproduce the problem? (1) --enable-features=SecondaryUiMd,ViewsBrowserWindows (2) Open several tabs in the tab strip (3) Scrub the mouse along the tab strip What is the expected result? Less visual distraction when hovering over the tabstrip. What happens instead? When you mouse over a tab, the close button animates/fades in. When you mouse off a tab, the close button animates/fades out. This is visually distracting when you're just moving your mouse around the screen. Please use labels and text to provide additional information. If this is a regression (i.e., worked before), please consider using the bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help us identify the root cause and more rapidly triage the issue. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
May 25 2018
I don't think we're ready for this level of feedback yet. I agree this is too distracting to ship, but it's one of a large number of things that we haven't yet had time to refine. Not closing since this is a legitimate bug, but I suggest not filing Refresh bugs yet.
,
May 31 2018
Fixing bug 847688 should put us in a position to decide whether we can ship hover-only close buttons on background tabs; until then things will be too janky to know. Making this call is P1 (we have to make a decision before shipping).
,
May 31 2018
,
Jun 1 2018
I'm not sure whether this bug is valuable to have open, actually, but if it is, this to me belongs to markchang@, since it's a product decision bug rather than an engineering work bug.
,
Jun 1 2018
Yup. Will hold and get us to decision.
,
Jun 11 2018
UXR study to help us figure this out is scheduled.
,
Jun 28 2018
UI review decision is to bring back close buttons for background tabs https://groups.google.com/a/google.com/forum/#!topic/chrome-ui-review/WTVkf6LZAcQ Changing the title and assigning to pkasting@. I don't think any additional specs are needed for this. Mocks to illustrate the intent: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZW9TjXpqhOa9/files/MCEndGYXWHp3udHEdFf49ZIk
,
Jun 28 2018
,
Jun 28 2018
,
Jun 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b78046188914eab12996154de10053b38e283f77 commit b78046188914eab12996154de10053b38e283f77 Author: Peter Kasting <pkasting@chromium.org> Date: Fri Jun 29 20:15:13 2018 Show close buttons on inactive tabs by default, and add feature control for it. Bug: 855729 , 856667 , 846430 Change-Id: Id2c9da22f671c94ffce1995477cab0899217ea2b Reviewed-on: https://chromium-review.googlesource.com/1119538 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#571607} [modify] https://crrev.com/b78046188914eab12996154de10053b38e283f77/chrome/browser/about_flags.cc [modify] https://crrev.com/b78046188914eab12996154de10053b38e283f77/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/b78046188914eab12996154de10053b38e283f77/chrome/browser/flag_descriptions.h [modify] https://crrev.com/b78046188914eab12996154de10053b38e283f77/chrome/browser/ui/views/tabs/tab_close_button.cc [modify] https://crrev.com/b78046188914eab12996154de10053b38e283f77/chrome/browser/ui/views/tabs/tab_strip.cc [modify] https://crrev.com/b78046188914eab12996154de10053b38e283f77/chrome/common/chrome_features.cc [modify] https://crrev.com/b78046188914eab12996154de10053b38e283f77/chrome/common/chrome_features.h [modify] https://crrev.com/b78046188914eab12996154de10053b38e283f77/tools/metrics/histograms/enums.xml
,
Jun 29 2018
,
Jul 2
Able to reproduce this issue on Windows 10, Mac OS 10.13.5 and Ubuntu 17.10 on the reported version 68.0.3439.0 and the issue is fixed on the latest Canary 69.0.3479.0 by following the below steps. 1. Launched Chrome and enabled the flags #secondary-ui-md and set #top-chrome-md flag to refresh on Windows and Linux. 2. On Mac OS, enabled the flags #views-browser-windows, #secondary-ui-md and set #top-chrome-md flag to refresh. 3. Opened many tabs and hovered over the tabs. Can observe that the close buttons are added to the background tabs as well and while hovering no visual distraction is observed Attached is the screen cast for reference. Hence adding TE verified labels as the fix is working as intended. Thanks..
,
Jul 12
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by meh...@chromium.org
, May 25 20183.3 MB
3.3 MB View Download