New issue
Advanced search Search tips

Issue 846430 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocked on:
issue 847688



Sign in to add a comment

Add close buttons to background tabs

Project Member Reported by rsesek@chromium.org, May 24 2018

Issue description

Chrome Version: 68.0.3439.0
OS: 10.13.4

What steps will reproduce the problem?
(1) --enable-features=SecondaryUiMd,ViewsBrowserWindows
(2) Open several tabs in the tab strip
(3) Scrub the mouse along the tab strip

What is the expected result?
Less visual distraction when hovering over the tabstrip.

What happens instead?
When you mouse over a tab, the close button animates/fades in. When you mouse off a tab, the close button animates/fades out.

This is visually distracting when you're just moving your mouse around the screen.


Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.


 
hover-close-animations.mov
587 KB View Download

Comment 1 by meh...@chromium.org, May 25 2018

Labels: Proj-MdRefresh
I know, MDRefresh is still heavy under development, but I totally agree with rsesek@. The appearing/disappearing of the close buttons make my eyes and head go really crazy :(

I think, one of the main issue here is, when the by the close button covered tab title shrinks and expands back to its full width, after the close button disappears again.

Please find enclosed a screencast demonstrating it on two windows:

In the foreground window it is less distracting, because the tab title is not covered by the close button.
 
In the background window the close button is covering the title (which shrinks and expands) and which makes it feel much more distracting.

Thanks for listening.
mdrefresh_background_tab_hover.mov
3.3 MB View Download
Cc: -ainslie@chromium.org bettes@chromium.org
Components: -Internals>Views>Desktop
Labels: -Proj-MacViews OS-Chrome OS-Linux OS-Windows
Owner: kylixrd@chromium.org
I don't think we're ready for this level of feedback yet.  I agree this is too distracting to ship, but it's one of a large number of things that we haven't yet had time to refine.

Not closing since this is a legitimate bug, but I suggest not filing Refresh bugs yet.
Blockedon: 847688
Labels: -Pri-2 M-69 Pri-1
Summary: Decide whether refresh can ship "hover-only close buttons on background tabs" (was: MacViewsBrowser: Animate-on-hover tab close buttons are visually distracting)
Fixing  bug 847688  should put us in a position to decide whether we can ship hover-only close buttons on background tabs; until then things will be too janky to know.

Making this call is P1 (we have to make a decision before shipping).
Status: Assigned (was: Untriaged)
Owner: markchang@chromium.org
I'm not sure whether this bug is valuable to have open, actually, but if it is, this to me belongs to markchang@, since it's a product decision bug rather than an engineering work bug.
Yup. Will hold and get us to decision.
UXR study to help us figure this out is scheduled.

Comment 8 by bettes@chromium.org, Jun 28 2018

Cc: mmarkchang@chromium.org
Owner: pkasting@chromium.org
Summary: Add close buttons to background tabs (was: Decide whether refresh can ship "hover-only close buttons on background tabs")
UI review decision is to bring back close buttons for background tabs https://groups.google.com/a/google.com/forum/#!topic/chrome-ui-review/WTVkf6LZAcQ

Changing the title and assigning to pkasting@.

I don't think any additional specs are needed for this. Mocks to illustrate the intent: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZW9TjXpqhOa9/files/MCEndGYXWHp3udHEdFf49ZIk


Cc: -mmarkchang@chromium.org markchang@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 29 2018

Status: Fixed (was: Started)
Labels: TE-Verified-69.0.3479.0 TE-Verified-M69
Able to reproduce this issue on Windows 10, Mac OS 10.13.5 and Ubuntu 17.10 on the reported version 68.0.3439.0 and the issue is fixed on the latest Canary 69.0.3479.0 by following the below steps.

1. Launched Chrome and enabled the flags #secondary-ui-md and set #top-chrome-md flag to refresh on Windows and Linux.
2. On Mac OS, enabled the flags #views-browser-windows, #secondary-ui-md and set #top-chrome-md flag to refresh.
3. Opened many tabs and hovered over the tabs. 
Can observe that the close buttons are added to the background tabs as well and while hovering no visual distraction is observed
Attached is the screen cast for reference.

Hence adding TE verified labels as the fix is working as intended.

Thanks..
846430-M69.mp4
609 KB View Download
Labels: -M-69 Group-Design

Sign in to add a comment