New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 846426 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

TabMemoryMetricsReporter crash in telemetry_unittests

Project Member Reported by gab@chromium.org, May 24 2018

Issue description

Regression range : https://chromium.googlesource.com/chromium/src/+log/be313798d23cd131c4dc360290fe4970c3cdc9b8..e3abcb79ea1e1d87381057d8ff95721491cd8ec9?pretty=fuller&n=10000

Bot : https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29?limit=200

Suspect : https://chromium-review.googlesource.com/c/chromium/src/+/925987

Example log :

[96805:775:0524/105402.545909:FATAL:process_posix.cc(296)] Check failed: IsValid(). 
  base::debug::StackTrace::StackTrace(unsigned long) + 174
  base::debug::StackTrace::StackTrace(unsigned long) + 29
  base::debug::StackTrace::StackTrace() + 28
  logging::LogMessage::~LogMessage() + 460
  logging::LogMessage::~LogMessage() + 21
  base::Process::Pid() const + 187
  resource_coordinator::TabMemoryMetricsReporter::EmitMemoryMetricsAfterPageLoaded(resource_coordinator::TabMemoryMetricsReporter::WebContentsData const&) + 113
  resource_coordinator::TabMemoryMetricsReporter::UpdateTimerCallback() + 1097
  void base::internal::FunctorTraits<void (resource_coordinator::TabMemoryMetricsReporter::*)(), void>::Invoke<void (resource_coordinator::TabMemoryMetricsReporter::*)(), resource_coordinator::TabMemoryMetricsReporter*>(void (resource_coordinator::TabMemoryMetricsReporter::*)(), resource_coordinator::TabMemoryMetricsReporter*&&) + 125
  void base::internal::InvokeHelper<false, void>::MakeItSo<void (resource_coordinator::TabMemoryMetricsReporter::* const&)(), resource_coordinator::TabMemoryMetricsReporter*>(void (resource_coordinator::TabMemoryMetricsReporter::* const&&&)(), resource_coordinator::TabMemoryMetricsReporter*&&) + 68
  void base::internal::Invoker<base::internal::BindState<void (resource_coordinator::TabMemoryMetricsReporter::*)(), base::internal::UnretainedWrapper<resource_coordinator::TabMemoryMetricsReporter> >, void ()>::RunImpl<void (resource_coordinator::TabMemoryMetricsReporter::* const&)(), std::__1::tuple<base::internal::UnretainedWrapper<resource_coordinator::TabMemoryMetricsReporter> > const&, 0ul>(void (resource_coordinator::TabMemoryMetricsReporter::* const&&&)(), std::__1::tuple<base::internal::UnretainedWrapper<resource_coordinator::TabMemoryMetricsReporter> > const&&&, std::__1::integer_sequence<unsigned long, 0ul>) + 99
  base::internal::Invoker<base::internal::BindState<void (resource_coordinator::TabMemoryMetricsReporter::*)(), base::internal::UnretainedWrapper<resource_coordinator::TabMemoryMetricsReporter> >, void ()>::Run(base::internal::BindStateBase*) + 44
  base::RepeatingCallback<void ()>::Run() const & + 61
  base::Timer::RunScheduledTask() + 294
  base::BaseTimerTaskInternal::Run() + 73
  void base::internal::FunctorTraits<void (base::BaseTimerTaskInternal::*)(), void>::Invoke<void (base::BaseTimerTaskInternal::*)(), base::BaseTimerTaskInternal*>(void (base::BaseTimerTaskInternal::*)(), base::BaseTimerTaskInternal*&&) + 125
  void base::internal::InvokeHelper<false, void>::MakeItSo<void (base::BaseTimerTaskInternal::*)(), base::BaseTimerTaskInternal*>(void (base::BaseTimerTaskInternal::*&&)(), base::BaseTimerTaskInternal*&&) + 68
  void base::internal::Invoker<base::internal::BindState<void (base::BaseTimerTaskInternal::*)(), base::internal::OwnedWrapper<base::BaseTimerTaskInternal> >, void ()>::RunImpl<void (base::BaseTimerTaskInternal::*)(), std::__1::tuple<base::internal::OwnedWrapper<base::BaseTimerTaskInternal> >, 0ul>(void (base::BaseTimerTaskInternal::*&&)(), std::__1::tuple<base::internal::OwnedWrapper<base::BaseTimerTaskInternal> >&&, std::__1::integer_sequence<unsigned long, 0ul>) + 99
  base::internal::Invoker<base::internal::BindState<void (base::BaseTimerTaskInternal::*)(), base::internal::OwnedWrapper<base::BaseTimerTaskInternal> >, void ()>::RunOnce(base::internal::BindStateBase*) + 57
  base::OnceCallback<void ()>::Run() && + 92
  base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 1033
  base::internal::IncomingTaskQueue::RunTask(base::PendingTask*) + 234
  base::MessageLoop::RunTask(base::PendingTask*) + 872
  base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) + 89
  base::MessageLoop::DoDelayedWork(base::TimeTicks*) + 605
  base::MessagePumpCFRunLoopBase::RunWork() + 160
  ___ZN4base24MessagePumpCFRunLoopBase13RunWorkSourceEPv_block_invoke + 28
  base::mac::CallWithEHFrame(void () block_pointer) + 10
  base::MessagePumpCFRunLoopBase::RunWorkSource(void*) + 101
  __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
  __CFRunLoopDoSource0 + 108
  __CFRunLoopDoSources0 + 208
  __CFRunLoopRun + 1293
  CFRunLoopRunSpecific + 487
  RunCurrentEventLoopInMode + 286
  ReceiveNextEventCommon + 613
  _BlockUntilNextEventMatchingListInModeWithFilter + 64
  _DPSNextEvent + 2085
  -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 3044
  __71-[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:]_block_invoke + 106
  base::mac::CallWithEHFrame(void () block_pointer) + 10
  -[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 248
  -[NSApplication run] + 764
  base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 348
  base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 101
  base::MessageLoop::Run(bool) + 556
  base::RunLoop::Run() + 606
  ChromeBrowserMainParts::MainMessageLoopRun(int*) + 361
  content::BrowserMainLoop::RunMainMessageLoopParts() + 450
  content::BrowserMainRunnerImpl::Run() + 378
  content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) + 1340
  content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) + 1027
  content::ContentMainRunnerImpl::Run() + 2023
  content::ContentServiceManagerMainDelegate::RunEmbedderProcess() + 53
  service_manager::Main(service_manager::MainParams const&) + 2168
  content::ContentMain(content::ContentMainParams const&) + 86
  ChromeMain + 270
  main + 674

 

Comment 1 by gab@chromium.org, May 24 2018

Labels: Sheriff-Chromium

Comment 2 by gab@chromium.org, May 24 2018

Labels: -Pri-1 Pri-2
P2 (revert in CQ)
Project Member

Comment 3 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60efe19e288d308654ec1ec8f8d4d6d03e4f262a

commit 60efe19e288d308654ec1ec8f8d4d6d03e4f262a
Author: Gabriel Charette <gab@chromium.org>
Date: Thu May 24 20:31:19 2018

Revert "[2/2] Report Memory_Experimental UKM 1, 5, 10 and 15 minutes after each tab's page load"

This reverts commit d911f7ffcc03fe645575e959c848a060bcacc0fe.

Reason for revert: crbug.com/846426

Original change's description:
> [2/2] Report Memory_Experimental UKM 1, 5, 10 and 15 minutes after each tab's page load
> 
> We would like to see more Memory_Experimental UKM after page load.
> We are thinking that renderer memory usage will quickly grow after page load.
> However, currently Memory_Experimental UKM is reported every 30 minutes, and
> is not related to any page load.
> 
> ProcessMemoryMetricsEmitter's change was https://chromium-review.googlesource.com/1032150
> and submitted.
> 
> Bug:  837498 
> Change-Id: I16eb5997879fb9a16b647969dc9e73503211065c
> Reviewed-on: https://chromium-review.googlesource.com/925987
> Commit-Queue: Takashi Sakamoto <tasak@google.com>
> Reviewed-by: Chris Hamilton <chrisha@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560948}

TBR=chrisha@chromium.org,tasak@google.com,erikchen@chromium.org,fmeawad@chromium.org,haraken@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  837498 , 846426
Change-Id: I45a2e3df525617e797680f4ddf14582b6f35df0e
Reviewed-on: https://chromium-review.googlesource.com/1072328
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561611}
[modify] https://crrev.com/60efe19e288d308654ec1ec8f8d4d6d03e4f262a/chrome/browser/BUILD.gn
[modify] https://crrev.com/60efe19e288d308654ec1ec8f8d4d6d03e4f262a/chrome/browser/resource_coordinator/tab_helper.cc
[delete] https://crrev.com/6a7c83a9f55a3fd8385d41782c04fe13a47bb066/chrome/browser/resource_coordinator/tab_memory_metrics_reporter.cc
[delete] https://crrev.com/6a7c83a9f55a3fd8385d41782c04fe13a47bb066/chrome/browser/resource_coordinator/tab_memory_metrics_reporter.h
[delete] https://crrev.com/6a7c83a9f55a3fd8385d41782c04fe13a47bb066/chrome/browser/resource_coordinator/tab_memory_metrics_reporter_unittest.cc
[modify] https://crrev.com/60efe19e288d308654ec1ec8f8d4d6d03e4f262a/chrome/test/BUILD.gn

Comment 4 by tasak@google.com, May 25 2018

Owner: tasak@google.com

Comment 5 by tapted@chromium.org, May 25 2018

Labels: -Sheriff-Chromium
Project Member

Comment 6 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/006522629080281754763876f822bfb63550fa01

commit 006522629080281754763876f822bfb63550fa01
Author: Takashi SAKAMOTO <tasak@google.com>
Date: Fri May 25 06:57:15 2018

Reland [2/2] Report Memory_Experimental UKM 1, 5, 10 and 15 minutes after each tab's page load

Fixed telemetry.internal.backends.chrome.tab_list_backend_unittest.TabListBackendTest.testTabIdStableAfterTabCrash.
If discarding a tab, TabMemoryMetricsReporter should not invoke EmitProcessMemoryMetrics for the tab because its process value is not valid.

Bug:  837498 , 846426
Change-Id: Ic23f779b5d64eec90467494a2158c0d6e81ae4b2
Reviewed-on: https://chromium-review.googlesource.com/1073109
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561794}
[modify] https://crrev.com/006522629080281754763876f822bfb63550fa01/chrome/browser/BUILD.gn
[modify] https://crrev.com/006522629080281754763876f822bfb63550fa01/chrome/browser/resource_coordinator/tab_helper.cc
[add] https://crrev.com/006522629080281754763876f822bfb63550fa01/chrome/browser/resource_coordinator/tab_memory_metrics_reporter.cc
[add] https://crrev.com/006522629080281754763876f822bfb63550fa01/chrome/browser/resource_coordinator/tab_memory_metrics_reporter.h
[add] https://crrev.com/006522629080281754763876f822bfb63550fa01/chrome/browser/resource_coordinator/tab_memory_metrics_reporter_unittest.cc
[modify] https://crrev.com/006522629080281754763876f822bfb63550fa01/chrome/test/BUILD.gn

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 5 2018

Labels: merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74324f8287efdc73b1cc77eecd2f4337403cf36d

commit 74324f8287efdc73b1cc77eecd2f4337403cf36d
Author: Takashi SAKAMOTO <tasak@google.com>
Date: Tue Jun 05 04:00:21 2018

Reland [2/2] Report Memory_Experimental UKM 1, 5, 10 and 15 minutes after each tab's page load

Fixed telemetry.internal.backends.chrome.tab_list_backend_unittest.TabListBackendTest.testTabIdStableAfterTabCrash.
If discarding a tab, TabMemoryMetricsReporter should not invoke EmitProcessMemoryMetrics for the tab because its process value is not valid.

TBR=tasak@google.com

(cherry picked from commit 006522629080281754763876f822bfb63550fa01)

Bug:  837498 , 846426
Change-Id: Ic23f779b5d64eec90467494a2158c0d6e81ae4b2
Reviewed-on: https://chromium-review.googlesource.com/1073109
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#561794}
Reviewed-on: https://chromium-review.googlesource.com/1086669
Reviewed-by: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/branch-heads/3440@{#181}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/74324f8287efdc73b1cc77eecd2f4337403cf36d/chrome/browser/BUILD.gn
[modify] https://crrev.com/74324f8287efdc73b1cc77eecd2f4337403cf36d/chrome/browser/resource_coordinator/tab_helper.cc
[add] https://crrev.com/74324f8287efdc73b1cc77eecd2f4337403cf36d/chrome/browser/resource_coordinator/tab_memory_metrics_reporter.cc
[add] https://crrev.com/74324f8287efdc73b1cc77eecd2f4337403cf36d/chrome/browser/resource_coordinator/tab_memory_metrics_reporter.h
[add] https://crrev.com/74324f8287efdc73b1cc77eecd2f4337403cf36d/chrome/browser/resource_coordinator/tab_memory_metrics_reporter_unittest.cc
[modify] https://crrev.com/74324f8287efdc73b1cc77eecd2f4337403cf36d/chrome/test/BUILD.gn

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cc974fd9d3bee6cc3bee9ff6c296c4a9c00457a

commit 5cc974fd9d3bee6cc3bee9ff6c296c4a9c00457a
Author: Michael Moss <mmoss@chromium.org>
Date: Wed Jun 06 00:32:05 2018

Revert "Reland [2/2] Report Memory_Experimental UKM 1, 5, 10 and 15 minutes after each tab's page load"

This reverts commit 74324f8287efdc73b1cc77eecd2f4337403cf36d.

Reason for revert: Breaking official builds with:
  The target //chrome/browser:browser
  generates two object files with the same name:
    obj/chrome/browser/browser/time.o

Original change's description:
> Reland [2/2] Report Memory_Experimental UKM 1, 5, 10 and 15 minutes after each tab's page load
> 
> Fixed telemetry.internal.backends.chrome.tab_list_backend_unittest.TabListBackendTest.testTabIdStableAfterTabCrash.
> If discarding a tab, TabMemoryMetricsReporter should not invoke EmitProcessMemoryMetrics for the tab because its process value is not valid.
> 
> TBR=tasak@google.com
> 
> (cherry picked from commit 006522629080281754763876f822bfb63550fa01)
> 
> Bug:  837498 , 846426
> Change-Id: Ic23f779b5d64eec90467494a2158c0d6e81ae4b2
> Reviewed-on: https://chromium-review.googlesource.com/1073109
> Commit-Queue: Takashi Sakamoto <tasak@google.com>
> Commit-Queue: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#561794}
> Reviewed-on: https://chromium-review.googlesource.com/1086669
> Reviewed-by: Takashi Sakamoto <tasak@google.com>
> Cr-Commit-Position: refs/branch-heads/3440@{#181}
> Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}

TBR=tasak@google.com,haraken@chromium.org

Change-Id: I846db6cf11095c6845362d823ab9c4a91aed5469
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  837498 , 846426, 849613
Reviewed-on: https://chromium-review.googlesource.com/1087329
Reviewed-by: Michael Moss <mmoss@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#201}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/5cc974fd9d3bee6cc3bee9ff6c296c4a9c00457a/chrome/browser/BUILD.gn
[modify] https://crrev.com/5cc974fd9d3bee6cc3bee9ff6c296c4a9c00457a/chrome/browser/resource_coordinator/tab_helper.cc
[delete] https://crrev.com/49e6eb80352f1137cb3a8fbd19723844e04778fe/chrome/browser/resource_coordinator/tab_memory_metrics_reporter.cc
[delete] https://crrev.com/49e6eb80352f1137cb3a8fbd19723844e04778fe/chrome/browser/resource_coordinator/tab_memory_metrics_reporter.h
[delete] https://crrev.com/49e6eb80352f1137cb3a8fbd19723844e04778fe/chrome/browser/resource_coordinator/tab_memory_metrics_reporter_unittest.cc
[modify] https://crrev.com/5cc974fd9d3bee6cc3bee9ff6c296c4a9c00457a/chrome/test/BUILD.gn

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73efcb115563045a4257b63ae2e6000fa9efe0ad

commit 73efcb115563045a4257b63ae2e6000fa9efe0ad
Author: Takashi Sakamoto <tasak@google.com>
Date: Thu Jun 07 04:54:29 2018

Reland [2/2] Report Memory_Experimental UKM 1, 5, 10 and 15 minutes after each tab's page load

Merge to release branch (branch-heads/3440).
Fixed telemetry.internal.backends.chrome.tab_list_backend_unittest.TabListBackendTest.testTabIdStableAfterTabCrash.
If discarding a tab, TabMemoryMetricsReporter should not invoke EmitProcessMemoryMetrics for the tab because its process value is not valid.

(cherry picked from commit 006522629080281754763876f822bfb63550fa01)

Bug:  837498 , 846426
Change-Id: I97bfe11d9157a9f050125d5919e1424f5a2c17f9
Reviewed-on: https://chromium-review.googlesource.com/1073109
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#561794}
Reviewed-on: https://chromium-review.googlesource.com/1088353
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#233}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/73efcb115563045a4257b63ae2e6000fa9efe0ad/chrome/browser/BUILD.gn
[modify] https://crrev.com/73efcb115563045a4257b63ae2e6000fa9efe0ad/chrome/browser/resource_coordinator/tab_helper.cc
[add] https://crrev.com/73efcb115563045a4257b63ae2e6000fa9efe0ad/chrome/browser/resource_coordinator/tab_memory_metrics_reporter.cc
[add] https://crrev.com/73efcb115563045a4257b63ae2e6000fa9efe0ad/chrome/browser/resource_coordinator/tab_memory_metrics_reporter.h
[add] https://crrev.com/73efcb115563045a4257b63ae2e6000fa9efe0ad/chrome/browser/resource_coordinator/tab_memory_metrics_reporter_unittest.cc
[modify] https://crrev.com/73efcb115563045a4257b63ae2e6000fa9efe0ad/chrome/test/BUILD.gn

Owner: tasak@chromium.org

Sign in to add a comment