New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 846425 link

Starred by 7 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Aug 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature



Sign in to add a comment

Policy RelaunchNotification not supported on ChromeOS

Project Member Reported by nrpeter@chromium.org, May 24 2018

Issue description

Chrome Version: 68.0.3437.0
Chrome OS Version: 10704.0.0
Chrome OS Platform: EVE

Steps To Reproduce:
(1) Set RelaunchNotification policy via D3 on a test domain (cl/197914399)
(2) Login to Chrome on a Windows computer with a user in the test domain, browse to chrome://policy on the Windows computer and see RelaunchNotification working as expected.
(3) Login to ChromeOS with the same user, browse to chrome://policy and notice RelaunchNotification is not applied.
(4) Reloading policy on ChromeOS manually doesn't change anything

Expected Result:
RelaunchNotification policy should apply to ChromeOS as well as Chrome desktop

Actual Result:
RelaunchNotification doesn't apply to ChromeOS.

Diagnosis:
When I look at the policy_templates.json file it looks like ChromeOS isn't listed as supported for the RelaunchNotification policy. However RelaunchNotificationPeriod is supported on ChromeOS.

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
Always

What is the impact to the user, and is there a workaround? If so, what is
it?
Can't use the policy on ChromeOS.

Please provide any additional information below. Attach a screen shot or
log if possible.

I'll upload a CL for review that adds ChromeOS support in case this was just an oversight and not an intention omission.
 

Comment 2 by grt@chromium.org, May 25 2018

It is certainly possible to expand the browser policies to devices if there's a need. Chrome OS has “Auto reboot after updates” and “Scheduled reboot” policy settings that partially address the need. Chrome OS was intentionally excluded in the RelaunchNotification design because of the existing policies.
Cc: atwilson@chromium.org
Owner: hunyadym@chromium.org
Think this may be a nice warmup bug for your intern?
Cc: hunyadym@chromium.org
Owner: fane@google.com
Status: Assigned (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54339ac9c0eda7fce6b9b2ec96714760e619fdc9

commit 54339ac9c0eda7fce6b9b2ec96714760e619fdc9
Author: Stefan Teodorescu <fane@google.com>
Date: Tue Jul 24 13:24:18 2018

Add RelaunchNotification to ChromeOS

Add Chrome desktop style RelaunchNotification to ChromeOS version of
Chrome, including the RelaunchNotificationController written for Chrome
desktop. This shows the bubble for the recommended relaunch and the
dialog for the required relaunch.

Bug:  846425 
Change-Id: I4aea7907d2f7a591e4e845597a7ece3d943722ca
Reviewed-on: https://chromium-review.googlesource.com/1146654
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Marton Hunyady <hunyadym@chromium.org>
Commit-Queue: Stefan Teodorescu <fane@google.com>
Cr-Commit-Position: refs/heads/master@{#577504}
[modify] https://crrev.com/54339ac9c0eda7fce6b9b2ec96714760e619fdc9/chrome/app/chromium_strings.grd
[modify] https://crrev.com/54339ac9c0eda7fce6b9b2ec96714760e619fdc9/chrome/app/generated_resources.grd
[modify] https://crrev.com/54339ac9c0eda7fce6b9b2ec96714760e619fdc9/chrome/app/google_chrome_strings.grd
[modify] https://crrev.com/54339ac9c0eda7fce6b9b2ec96714760e619fdc9/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/54339ac9c0eda7fce6b9b2ec96714760e619fdc9/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/54339ac9c0eda7fce6b9b2ec96714760e619fdc9/chrome/browser/ui/browser_ui_prefs.cc
[modify] https://crrev.com/54339ac9c0eda7fce6b9b2ec96714760e619fdc9/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc
[modify] https://crrev.com/54339ac9c0eda7fce6b9b2ec96714760e619fdc9/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.h
[modify] https://crrev.com/54339ac9c0eda7fce6b9b2ec96714760e619fdc9/chrome/browser/ui/views/relaunch_notification/relaunch_notification_controller.cc
[modify] https://crrev.com/54339ac9c0eda7fce6b9b2ec96714760e619fdc9/chrome/common/pref_names.cc
[modify] https://crrev.com/54339ac9c0eda7fce6b9b2ec96714760e619fdc9/chrome/common/pref_names.h
[modify] https://crrev.com/54339ac9c0eda7fce6b9b2ec96714760e619fdc9/chrome/test/BUILD.gn
[modify] https://crrev.com/54339ac9c0eda7fce6b9b2ec96714760e619fdc9/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/54339ac9c0eda7fce6b9b2ec96714760e619fdc9/components/policy/resources/policy_templates.json

Labels: Target-70
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2f0139dc3cb4096834da36734b203fc31ead9a2

commit e2f0139dc3cb4096834da36734b203fc31ead9a2
Author: Stefan Teodorescu <fane@google.com>
Date: Wed Aug 22 19:13:43 2018

Send notifications from RelaunchNotificationController to ash

Change the RelaunchNotificationController so that it sends notifications
to the system tray and to ash, to be shown in Chrome OS as they should
be, in the notification center (instead of bubbles and dialogs, the
Chrome dekstop way).

Bug:  846425 
Change-Id: Iea8cd8cc1c2c3457a44f74f10c72fa56b0b378bd
Reviewed-on: https://chromium-review.googlesource.com/1150227
Commit-Queue: Stefan Teodorescu <fane@google.com>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Marton Hunyady <hunyadym@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585193}
[modify] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/ash/public/interfaces/system_tray.mojom
[modify] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/ash/public/interfaces/update.mojom
[modify] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/ash/system/model/system_tray_model.cc
[modify] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/ash/system/model/system_tray_model.h
[modify] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/ash/system/model/update_model.cc
[modify] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/ash/system/model/update_model.h
[modify] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/ash/system/update/update_notification_controller.cc
[modify] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/ash/system/update/update_notification_controller_unittest.cc
[modify] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/chrome/browser/ui/ash/system_tray_client.cc
[modify] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/chrome/browser/ui/ash/system_tray_client.h
[modify] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/chrome/browser/ui/views/relaunch_notification/relaunch_notification_controller.cc
[modify] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/chrome/browser/ui/views/relaunch_notification/relaunch_notification_controller.h
[add] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/chrome/browser/ui/views/relaunch_notification/relaunch_notification_controller_platform_impl_chromeos.cc
[add] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/chrome/browser/ui/views/relaunch_notification/relaunch_notification_controller_platform_impl_chromeos.h
[add] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/chrome/browser/ui/views/relaunch_notification/relaunch_notification_controller_platform_impl_desktop.cc
[add] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/chrome/browser/ui/views/relaunch_notification/relaunch_notification_controller_platform_impl_desktop.h
[modify] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/chrome/browser/ui/views/relaunch_notification/relaunch_notification_controller_unittest.cc
[add] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/chrome/browser/ui/views/relaunch_notification/relaunch_notification_metrics.cc
[add] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/chrome/browser/ui/views/relaunch_notification/relaunch_notification_metrics.h
[modify] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/chrome/browser/ui/views/relaunch_notification/relaunch_recommended_bubble_view.cc
[modify] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/chrome/browser/ui/views/relaunch_notification/relaunch_recommended_bubble_view.h
[add] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/chrome/browser/ui/views/relaunch_notification/relaunch_recommended_timer.cc
[add] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/chrome/browser/ui/views/relaunch_notification/relaunch_recommended_timer.h
[modify] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/chrome/browser/ui/views/relaunch_notification/relaunch_required_dialog_view.cc
[modify] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/chrome/browser/ui/views/relaunch_notification/relaunch_required_dialog_view.h
[add] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/chrome/browser/ui/views/relaunch_notification/relaunch_required_timer.cc
[add] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/chrome/browser/ui/views/relaunch_notification/relaunch_required_timer.h
[add] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/chrome/browser/ui/views/relaunch_notification/relaunch_required_timer_internal.cc
[add] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/chrome/browser/ui/views/relaunch_notification/relaunch_required_timer_internal.h
[rename] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/chrome/browser/ui/views/relaunch_notification/relaunch_required_timer_internal_unittest.cc
[modify] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/chrome/test/BUILD.gn
[modify] https://crrev.com/e2f0139dc3cb4096834da36734b203fc31ead9a2/components/policy/resources/policy_templates.json

Status: Fixed (was: Assigned)
Status: Assigned (was: Fixed)
Checked using Yaps on Google Chrome: 70.0.3530.0 Platform : 10998.0.0 peach_pit 

Observed RelaunchNotification policies are seen on chrome:policy page.

Attached policy file. Please confirm if this is expected as per fix. Thanks.!
policies.json
2.7 KB View Download
Hi, Stefan's change landed only in 70.0.3531.0 according to https://storage.googleapis.com/chromium-find-releases-static/e2f.html#e2f0139dc3cb4096834da36734b203fc31ead9a2

Also, I don't understand what's the issue, can you please elaborate?
Observed pushed policy changes are seen #c9. Please confirm if i can close the bug as verified.
Labels: -Type-Bug Type-Feature
Hi, I think this issue needs more verification: the Chrome OS notifications are different from the Chrome ones.

I think we should verify that it's indeed showing the notifications in the intended way if a new update arrives in both modes (recommended and required). Let me or fane@ know if you need help with that.
Status: Verified (was: Assigned)
Google Chrome:70.0.3530.0 Platform:11005.0.0 sona
Checked via yaps and observed OS update notification.

Attached policy file and screenshots. Closing the bug as verified.
Screenshot 2018-08-27 at 4.15.51 PM.png
1.1 MB View Download
Screenshot 2018-08-27 at 4.16.24 PM.png
1014 KB View Download
Screenshot 2018-08-27 at 4.16.52 PM.png
204 KB View Download
policies.json
2.7 KB View Download
Status: Started (was: Verified)
It looks like that first screenshot is showing the desktop dialog. Is that how it's supposed to look?
Status: Fixed (was: Started)
As mentioned in #10, change landed in 70.0.3531.0, and the verification was done on 70.0.3530.0. Marking as fixed, please re-verify on a newer version. Thanks!
Thanks for checking Marton,
Will re-verify it and update the bug.
Status: Verified (was: Fixed)
Checked via yaps and Relaunch notification is seen on device.
Google Chrome:70.0.3532.0 Platform:11021.0.0

Attached Screenshots.
Screenshot 2018-09-07 at 5.18.26 PM.png
1.0 MB View Download
Screenshot 2018-09-07 at 4.08.18 PM.png
1.0 MB View Download
This sounds very good. Is there somewhere in the GSfE admin console where we can set this policy? (we do not have Windows computeres, but chromebooks)
Hi, the policy will be supported on Chromebooks starting from M70, so it's not possible yet to set it on the admin console.

Sign in to add a comment