16 patches and 480ish file modifications later, histogram_tester.h is finally moved. :)
asvitkine@, isherman@, any other files that should be moved as well? Or shall I close this out?
Ah, perfect list, thanks isherman@! Inlining here:
per-file *histogram_tester*=file://base/metrics/OWNERS
- Moved! I'll update this OWNERS file. It evaded my grep. CL coming tomorrow.
per-file *scoped_feature_list*=file://base/metrics/OWNERS
- I asked asvitkine@ about this earlier, and we went back and forth because feature_list.h is in //base/ (rather than //base/metrics). So, three reasonable options I see: a) leave scoped_feature_list in //base/test; b) put scoped_feature_list in //base/test/metrics, but leave feature_list in //base/; c) put feature_list in //base/metrics and put scoped_feature_list in //base/test/metrics.
Out of my desire for symmetry, I slightly prefer a) or c), but I have no vested interest in either, and would be happy to tackle whichever approach y'all think is best. Preferences?
per-file *user_action_tester*=file://base/metrics/OWNERS
- Prime candidate! I'll move this one over.
For the scoped_feature_list, I think probably the most appropriate thing to do would be to create //base/variations to parallel //components/variations, and move a bunch of variations/field trial/feature-related code to that directory... and then parallel that structure within //base/test/variations. Not sure whether Alexei would agree, though!
Thanks again for taking on the test code cleanup! =)
> For the scoped_feature_list, I think probably the most appropriate thing to do would be to create //base/variations to parallel //components/variations, and move a bunch of variations/field trial/feature-related code to that directory... and then parallel that structure within //base/test/variations. Not sure whether Alexei would agree, though!
Sounds reasonable to me; I'll wait for Alexei to chime in with any thoughts. If he agrees (and no one else objects), I can file another bug to do those moves. Thanks for the suggestion, Ilya!
Woo! Marking this as fixed, since it sounds like we'd move [scoped_]feature_list.* somewhere else if we move it at all.
On that note, Alexei, any opinions on #20/#22?
Sorry for the tardy reply - have been trying to catch up to my inbox.
I'd prefer we keep scoped_feature_list in a parallel location to feature_list itself - which is in base/ and not base/variations. So I think current state is fine. (Reason feature list is in base/ is because base/ OWNERS felt it was pretty core like command_line and suggested for it to be top-level in base).
Comment 1 by bugdroid1@chromium.org
, May 31 2018