New issue
Advanced search Search tips

Issue 846416 link

Starred by 4 users
Status: Verified
Owner:
pbos@chromium.org
Closed: Jun 2018
Cc:
tommycli@chromium.org
Components:
EstimatedDays: 2
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[MD-Refresh] Inkdrop colors on Toolbar / Extensions / Bookmarks Bar / Omnibox differ from each other

Project Member Reported by meh...@chromium.org, May 24 2018 
Chrome Version: 68.0.3439.0 Canary
OS: macOS 10.13.4

What steps will reproduce the problem?

I noticed that the color of the inkdrops differ from each other. Especially I mean the Inkdrops of the Extension Buttons, the Default Toolbar Buttons (like Reload, Profile, ...) Omnibox (Security Chip, BM-Star) and the Bookmarks Bar Buttons.

They all could have the same grey color.

Please find attached a screenshot

Thanks :)
Mehmet
Bildschirmfoto 2018-05-24 um 20.38.45.png
19.0 KB View Download

Comment 1 by meh...@chromium.org, May 24 2018

Status: Assigned (was: Untriaged)

Comment 2 by pkasting@chromium.org, May 31 2018

Components: UI>Browser>Toolbar
EstimatedDays: 2
Labels: -Pri-2 Pri-3
To me this is minor enough that we could ship with it (but I agree would be nice to fix).
Project Member

Comment 3 by bugdroid1@chromium.org, May 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fcfc72c61f88a2dab963b45c336f6d535614dfc

commit 7fcfc72c61f88a2dab963b45c336f6d535614dfc
Author: Peter Boström <pbos@chromium.org>
Date: Thu May 31 22:21:47 2018

Unify toolbar-related ink-drop colors

* Makes bookmarks-bar buttons use the toolbar ink-drop base color.
* Use the previously-touch opacities for hovered and selected ink-drop
  states unconditionally for toolbar buttons, extension icons, bookmark
  buttons and the 3-dot menu.
* Renames kTouchToolbar constants to reflect that they're no longer
  touch-only constants. Also does corresponding comment cleanup.

Bug: chromium:821996,  chromium:822069 ,  chromium:846416 
Change-Id: Ia28642afb2dd7381bff59428405fa895559be8bd
Reviewed-on: https://chromium-review.googlesource.com/1080552
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563398}
[modify] https://crrev.com/7fcfc72c61f88a2dab963b45c336f6d535614dfc/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
[modify] https://crrev.com/7fcfc72c61f88a2dab963b45c336f6d535614dfc/chrome/browser/ui/views/toolbar/browser_app_menu_button.cc
[modify] https://crrev.com/7fcfc72c61f88a2dab963b45c336f6d535614dfc/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
[modify] https://crrev.com/7fcfc72c61f88a2dab963b45c336f6d535614dfc/chrome/browser/ui/views/toolbar/toolbar_button.cc
[modify] https://crrev.com/7fcfc72c61f88a2dab963b45c336f6d535614dfc/chrome/browser/ui/views/toolbar/toolbar_ink_drop_util.h

Comment 4 by pbos@chromium.org, Jun 1 2018

Cc: tommycli@chromium.org
Status: Fixed (was: Assigned)
The omnibox security chip / star are different as they derive color based on the NativeTheme text color, and they can also be drawn either on grey or white depending on the location bar's state. +cc tommycli@ fyi.

The rest should be fixed after this change, so I'll call it fixed and omnibox WAI unless tommycli@ disagrees. Thanks!

Comment 5 by meh...@chromium.org, Jun 1 2018 

Looks good in latest Canary :) Thanks, pbos@.

Comment 6 by pbos@chromium.org, Jun 1 2018

Status: Verified (was: Fixed)
►

Sign in to add a comment