Material Refresh - Update relevant unit tests to enable new top-chrome-md modes |
||||||||||
Issue descriptionWith the added top-chrome-md modes, many unit tests don't actually test with those modes enabled. Some of these test will likely fail under these new modes due to size, shape, and position differences in UI elements. This should be the clearinghouse bug used to track unit test updates. New bugs related to updating unit tests for the material refresh modes should block this bug.
,
May 31 2018
Triage assigning all P1s.
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ce1258066d22379a3507a1ba1faf2ec16283c87 commit 5ce1258066d22379a3507a1ba1faf2ec16283c87 Author: Bret Sepulveda <bsep@chromium.org> Date: Mon Jun 04 19:14:40 2018 Force top-chrome-md to be Normal when running pre-Harmony tests. When Refresh UI is enabled it uses Harmony values in most cases. If a test is explicitly trying to test pre-Harmony behavior that will cause problems when Refresh is enabled by default. This patch forces Refresh to be off for those tests. Bug: 846410 Change-Id: I58132d4419fc50b024539cb20296b80dc1674505 Reviewed-on: https://chromium-review.googlesource.com/1083847 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#564179} [modify] https://crrev.com/5ce1258066d22379a3507a1ba1faf2ec16283c87/ui/views/controls/label_unittest.cc [modify] https://crrev.com/5ce1258066d22379a3507a1ba1faf2ec16283c87/ui/views/controls/styled_label_unittest.cc
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b52b27c5fb1aa4de54e86d7d763cd39d70a2413b commit b52b27c5fb1aa4de54e86d7d763cd39d70a2413b Author: Bret Sepulveda <bsep@chromium.org> Date: Tue Jun 05 00:41:17 2018 Fix crash in TabStripTest when Refresh is enabled. The tab strip's parent Widget doesn't have a NonClientFrameView in unit tests. This patch moves the logic for determining where the new tab button should go to TabController, which has a fake version for tests. Bug: 846410 Change-Id: I572b3b9aa6f4e4213ea9c203198b6f7bb98746c2 Reviewed-on: https://chromium-review.googlesource.com/1081891 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#564317} [modify] https://crrev.com/b52b27c5fb1aa4de54e86d7d763cd39d70a2413b/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc [modify] https://crrev.com/b52b27c5fb1aa4de54e86d7d763cd39d70a2413b/chrome/browser/ui/views/tabs/browser_tab_strip_controller.h [modify] https://crrev.com/b52b27c5fb1aa4de54e86d7d763cd39d70a2413b/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.cc [modify] https://crrev.com/b52b27c5fb1aa4de54e86d7d763cd39d70a2413b/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.h [modify] https://crrev.com/b52b27c5fb1aa4de54e86d7d763cd39d70a2413b/chrome/browser/ui/views/tabs/tab_strip.cc [modify] https://crrev.com/b52b27c5fb1aa4de54e86d7d763cd39d70a2413b/chrome/browser/ui/views/tabs/tab_strip.h [modify] https://crrev.com/b52b27c5fb1aa4de54e86d7d763cd39d70a2413b/chrome/browser/ui/views/tabs/tab_strip_controller.h [modify] https://crrev.com/b52b27c5fb1aa4de54e86d7d763cd39d70a2413b/chrome/browser/ui/views/tabs/tab_strip_types.h
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b245c2b1f7912fe801546ac8ba67e5ccef7436c7 commit b245c2b1f7912fe801546ac8ba67e5ccef7436c7 Author: Bret Sepulveda <bsep@chromium.org> Date: Tue Jun 05 18:43:31 2018 Fix OpaqueBrowserFrameViewLayoutTest when Refresh is enabled. In Refresh, OpaqueBrowserFrameViewLayout::TabStripCaptionSpacing always returns 0 because the tabstrip itself reserves space. This caused the layout unit tests to fail. Bug: 846410 Change-Id: I6b3ecf21914202e4049df39ebcdf40cbff76c312 Reviewed-on: https://chromium-review.googlesource.com/1086298 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#564595} [modify] https://crrev.com/b245c2b1f7912fe801546ac8ba67e5ccef7436c7/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15f2d3ed97d68db157646b9e71fcf29de0ddaf1d commit 15f2d3ed97d68db157646b9e71fcf29de0ddaf1d Author: Bret Sepulveda <bsep@chromium.org> Date: Wed Jun 06 00:13:02 2018 Make ProfileChooserViewExtensionsTest use the Refresh avatar button. Refresh adds a new avatar button in the toolbar. The profile menu suite needs to click on that new button when Refresh is enabled, as a prerequisite for its tests. Bug: 846410 Change-Id: I9a9cda0443f972a4246ff309fc163976e1bde05f Reviewed-on: https://chromium-review.googlesource.com/1087836 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#564725} [modify] https://crrev.com/15f2d3ed97d68db157646b9e71fcf29de0ddaf1d/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc
,
Jun 6 2018
,
Jun 6 2018
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94009951865b8fa10760234d2cb097083b934075 commit 94009951865b8fa10760234d2cb097083b934075 Author: Bret Sepulveda <bsep@chromium.org> Date: Wed Jun 06 19:05:24 2018 Skip BrowserNonClientFrameViewTestWin when Refresh is enabled. Since Refresh removes the avatar button in the frame area, the test is no longer needed. Bug: 846410 Change-Id: I58d40e94aa4e4f909ebec0674c923a0a9a7f0f82 Reviewed-on: https://chromium-review.googlesource.com/1087435 Reviewed-by: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#564992} [modify] https://crrev.com/94009951865b8fa10760234d2cb097083b934075/chrome/browser/ui/views/frame/browser_non_client_frame_view_browsertest_win.cc
,
Jun 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22b36989b1ba408a526d457fac93653895890b54 commit 22b36989b1ba408a526d457fac93653895890b54 Author: Bret Sepulveda <bsep@chromium.org> Date: Sat Jun 09 01:13:42 2018 Fix TabStripTest for Refresh. This patch fixes various tests in the TabStripTest suite: * VisibilityInOverflow and TabForEventWhenStacked were broken because Refresh tabs are larger than before, and the test wasn't allocating enough room for them. * TabCloseButtonVisibilityWhenNotStacked was broken because in Refresh close buttons on inactive tabs are never visible unless the tab is hovered. To fix this, the test now hovers the tab. * TabCloseButtonVisibilityWhenStacked was broken for the previous reason but also because close buttons shouldn't be shown on inactive tabs in stacked layout ever. Bug: 846410 Change-Id: I49655b9e03ba9622b71c6a0110e6772f72c0e8e5 Reviewed-on: https://chromium-review.googlesource.com/1092153 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#565811} [modify] https://crrev.com/22b36989b1ba408a526d457fac93653895890b54/chrome/browser/ui/views/tabs/tab_strip.cc [modify] https://crrev.com/22b36989b1ba408a526d457fac93653895890b54/chrome/browser/ui/views/tabs/tab_strip_unittest.cc
,
Jun 11 2018
Triage: update estimated days please. How much work is left?
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/155836a710f19cc9b0a4cac502f351bca4c6e112 commit 155836a710f19cc9b0a4cac502f351bca4c6e112 Author: Bret Sepulveda <bsep@chromium.org> Date: Wed Jun 13 00:29:56 2018 Fix AlertIndicatorButtonTest when Refresh is enabled. The suite needed to be a subclass of ChromeViewsTestBase to access the correct LayoutProvider. Bug: 846410 Change-Id: I51952fd6451b4efcfe26de14ffe73480f1892705 Reviewed-on: https://chromium-review.googlesource.com/1098218 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#566649} [modify] https://crrev.com/155836a710f19cc9b0a4cac502f351bca4c6e112/chrome/browser/ui/views/tabs/alert_indicator_button_unittest.cc
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/155836a710f19cc9b0a4cac502f351bca4c6e112 commit 155836a710f19cc9b0a4cac502f351bca4c6e112 Author: Bret Sepulveda <bsep@chromium.org> Date: Wed Jun 13 00:29:56 2018 Fix AlertIndicatorButtonTest when Refresh is enabled. The suite needed to be a subclass of ChromeViewsTestBase to access the correct LayoutProvider. Bug: 846410 Change-Id: I51952fd6451b4efcfe26de14ffe73480f1892705 Reviewed-on: https://chromium-review.googlesource.com/1098218 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#566649} [modify] https://crrev.com/155836a710f19cc9b0a4cac502f351bca4c6e112/chrome/browser/ui/views/tabs/alert_indicator_button_unittest.cc
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a605b4f78249c7596dda0b8e39eb4f6f2f39d682 commit a605b4f78249c7596dda0b8e39eb4f6f2f39d682 Author: Bret Sepulveda <bsep@chromium.org> Date: Wed Jun 13 01:51:22 2018 Fix unit tests that use OmniboxViewViews in Refresh. Some tests would create an instance of OmniboxViewViews, but without a location bar. Refresh tries to access the location bar to set the placeholder text, and this would crash. This patch moves that code into Init and guards it by checking that location_bar_view_ is defined. Bug: 846410 Change-Id: I0a1aec21f515dcc441e52c92c0c1adc58163348f Reviewed-on: https://chromium-review.googlesource.com/1098141 Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#566682} [modify] https://crrev.com/a605b4f78249c7596dda0b8e39eb4f6f2f39d682/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25e77807709363f1ee606d1e8a14e584bed4366b commit 25e77807709363f1ee606d1e8a14e584bed4366b Author: Bret Sepulveda <bsep@chromium.org> Date: Wed Jun 13 18:33:39 2018 Disable ThemeServiceTest.SeparatorColor in Refresh. The Refresh tabstrip does not draw the toolbar top separator, so this test is unnecessary in that mode. Bug: 846410 Change-Id: I0adac7e80227267e8a92556a4fef602d81e531db Reviewed-on: https://chromium-review.googlesource.com/1098139 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#566929} [modify] https://crrev.com/25e77807709363f1ee606d1e8a14e584bed4366b/chrome/browser/themes/theme_service_unittest.cc
,
Jun 14 2018
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77265c6e7b0219a673cf3c4ad9316b732c705d8b commit 77265c6e7b0219a673cf3c4ad9316b732c705d8b Author: Bret Sepulveda <bsep@chromium.org> Date: Thu Jun 14 02:31:54 2018 Fix Refresh tab icon layout when the tab is small. Refresh changes the amount of extra padding added to the left of the favicon. But when the tab is too small to accommodate this extra padding, Refresh was failing to remove this padding and calculate icon visibility correctly. This also fixes TabTest.LayoutAndVisibilityOfElements when Refresh is enabled. Bug: 846410 , 822061 Change-Id: I2b77b976d55e314da3e6b5193403eb2a102dd426 Reviewed-on: https://chromium-review.googlesource.com/1098148 Reviewed-by: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#567098} [modify] https://crrev.com/77265c6e7b0219a673cf3c4ad9316b732c705d8b/chrome/browser/ui/views/tabs/tab.cc
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34c7d0d6ba788f1317d5af5bc21be98bf0a841a8 commit 34c7d0d6ba788f1317d5af5bc21be98bf0a841a8 Author: Bret Sepulveda <bsep@chromium.org> Date: Thu Jun 14 20:57:10 2018 Fix PopupBlockerBrowserTest.WindowFeatures when Refresh is on. Refresh is a project to redesign the core UI, primarily the tapstrip's height and shape. The result is that popup windows are slightly taller because of some added frame padding. This patch makes the test checking for the height of the window more lenient. Bug: 846410 Change-Id: If62e8076d78477b82b80f13d19c0838b32f9ea64 Reviewed-on: https://chromium-review.googlesource.com/1100386 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#567408} [modify] https://crrev.com/34c7d0d6ba788f1317d5af5bc21be98bf0a841a8/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0d99402e403e3c03e296e0b8d0870ef714d5b91 commit a0d99402e403e3c03e296e0b8d0870ef714d5b91 Author: Bret Sepulveda <bsep@chromium.org> Date: Thu Jun 14 22:44:57 2018 Skip payment tests that rely on pre-Harmony behavior when Refresh is on. Refresh implies that Harmony is enabled, so these tests began failing. They can be safely skipped, as there are equivalent tests for Harmony. Bug: 846410 Change-Id: I6c6211d4ea99b6df0a4ba9620217574760ba723c Reviewed-on: https://chromium-review.googlesource.com/1100390 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#567450} [modify] https://crrev.com/a0d99402e403e3c03e296e0b8d0870ef714d5b91/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
,
Jun 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ebcbb262b529457721363e2e394a9ff25170c1cb commit ebcbb262b529457721363e2e394a9ff25170c1cb Author: Bret Sepulveda <bsep@chromium.org> Date: Fri Jun 15 19:16:29 2018 Disable a toolbar top separator test in Refresh. The Refresh tabstrip does not draw the toolbar top separator, so the test, BrowserNonClientFrameViewBrowserTest.InactiveSeparatorColor, is unnecessary in that mode. Bug: 846410 Change-Id: I1d9b0c386f51d57bf7cfef778e5e2892644b3ea9 Reviewed-on: https://chromium-review.googlesource.com/1102123 Reviewed-by: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#567760} [modify] https://crrev.com/ebcbb262b529457721363e2e394a9ff25170c1cb/chrome/browser/ui/views/frame/browser_non_client_frame_view_browsertest.cc
,
Jun 15 2018
,
Jun 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2199d8197dc81aaae7aae70bb6d5f0319fdabf2 commit c2199d8197dc81aaae7aae70bb6d5f0319fdabf2 Author: Bret Sepulveda <bsep@chromium.org> Date: Fri Jun 15 21:45:59 2018 Fix OmniboxViewViewsTest.SelectionClipboard when Refresh is enabled. In Refresh, when the omnibox receives focus it moves. The test was assuming it would stay put, so this patch refreshes the click location after the first click. Bug: 846410 Change-Id: Iea0fe695efed257d679f87c55146b948f3360e0d Reviewed-on: https://chromium-review.googlesource.com/1102117 Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#567802} [modify] https://crrev.com/c2199d8197dc81aaae7aae70bb6d5f0319fdabf2/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc
,
Jun 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d7d96406ec6358f1e0fca76deedfb7759c7936b commit 2d7d96406ec6358f1e0fca76deedfb7759c7936b Author: Bret Sepulveda <bsep@chromium.org> Date: Fri Jun 15 21:52:29 2018 Fix OpaqueBrowserFrameViewLayoutTest when Refresh is enabled, again. In Refresh, FrameTopBorderThickness is 1 dip larger when the browser is restored. OpaqueBrowserFrameViewLayoutTest needed to account for this increase. Bug: 846410 Change-Id: I4595c4d52ef955de53ef8f487fb181fb109d5f76 Reviewed-on: https://chromium-review.googlesource.com/1100382 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#567804} [modify] https://crrev.com/2d7d96406ec6358f1e0fca76deedfb7759c7936b/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc [modify] https://crrev.com/2d7d96406ec6358f1e0fca76deedfb7759c7936b/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h [modify] https://crrev.com/2d7d96406ec6358f1e0fca76deedfb7759c7936b/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc
,
Jun 18 2018
,
Jun 18 2018
M69 branch is coming soon on July 19th, Your bug is marked as ReleaseBlock-Beta for M69. Please try to land the fix ASAP to trunk in order to prevent many merges going after M69 branch. This will also help us to branch M69 from high quality trunk. Thank you.
,
Jun 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d54b0767963801d5b1344ad85660cbd0e59960eb commit d54b0767963801d5b1344ad85660cbd0e59960eb Author: Bret Sepulveda <bsep@chromium.org> Date: Mon Jun 18 20:25:28 2018 Fix PageInfoBubbleViewTest Harmony tests when Refresh is on. SetPermissionInfo and SetPermissionInfoForUsbGuard were checking whether Harmony was enabled by checking the feature flag instead of calling MaterialDesignController::IsSecondaryUiMaterial. The latter will return true under Refresh when the former does not. Also deletes some obsolete Mac-only code. Bug: 846410 Change-Id: I9cdf5ec0dee8fb2fcc519fa3c09702014d7342fe Reviewed-on: https://chromium-review.googlesource.com/1103583 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#568138} [modify] https://crrev.com/d54b0767963801d5b1344ad85660cbd0e59960eb/chrome/browser/ui/views/page_info/page_info_bubble_view_unittest.cc
,
Jun 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5010c9c9cff2a30d9d495d9c7a953da308ffa45 commit d5010c9c9cff2a30d9d495d9c7a953da308ffa45 Author: Bret Sepulveda <bsep@chromium.org> Date: Mon Jun 18 21:28:33 2018 Fix AXTreeSourceAuraTest.Accessors when Harmony is on. When Harmony is enabled textfields have an additional child in the form of the focus ring, so the expectation needed to be updated. Bug: 846410 Change-Id: I0b807d7f69c97eed7bc56e9520f51d3a845fba76 Reviewed-on: https://chromium-review.googlesource.com/1103586 Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#568166} [modify] https://crrev.com/d5010c9c9cff2a30d9d495d9c7a953da308ffa45/chrome/browser/ui/ash/accessibility/ax_tree_source_aura_unittest.cc
,
Jun 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b540add34fe6509ca72897f99e2d246db56a0330 commit b540add34fe6509ca72897f99e2d246db56a0330 Author: Peter Boström <pbos@chromium.org> Date: Mon Jun 18 22:14:56 2018 Set MD mode before initializing window in test Prevents DCHECK failure when turning on MD Refresh by default in tests ToolbarActionsBarUnitTest.TestHighlightMode/{0,1}. This was due to an inconsistent MD mode in the test as the browser window gets constructed and initialized with the default mode before it's overridden with ToolbarActionsBarUnitTest::GetParam(). Bug: chromium:846410 Change-Id: Id1fc1a0137d27cb4be7c5ddc32f2a2c9c203e117 Reviewed-on: https://chromium-review.googlesource.com/1102992 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568193} [modify] https://crrev.com/b540add34fe6509ca72897f99e2d246db56a0330/chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3183d7ced9505e878652100378d62d20a8228d47 commit 3183d7ced9505e878652100378d62d20a8228d47 Author: Bret Sepulveda <bsep@chromium.org> Date: Tue Jun 19 01:09:22 2018 Fix SadTabViewInteractiveUITest suite for Chrome OS when Refresh is on. The test assumed BlueButton would always be used for dialog buttons, but LabelButton is used in Harmony (which Refresh implies). Bug: 846410 Change-Id: Id7fb8f66cc0abb120fdb81294c4d00c3faf060ae Reviewed-on: https://chromium-review.googlesource.com/1105457 Reviewed-by: Peter Boström <pbos@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#568272} [modify] https://crrev.com/3183d7ced9505e878652100378d62d20a8228d47/chrome/browser/ui/views/sad_tab_view_interactive_uitest.cc
,
Jun 20 2018
Triage: Is there still 7 days of work remaining for this issue? Thanks!
,
Jun 20 2018
,
Jun 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/715862a72d01559f46457bd0fcfda37bc1d6e92b commit 715862a72d01559f46457bd0fcfda37bc1d6e92b Author: Bret Sepulveda <bsep@chromium.org> Date: Wed Jun 20 21:06:43 2018 Fix SelectToSpeakTest suite when Refresh is enabled. The top chrome height increases when Refresh is enabled, so the insets into the browser window to click on the web content were incorrect. Bug: 846410 , 853990 Change-Id: I2f274632ca752d583a8fd0ac21721039c3cc8c1b Reviewed-on: https://chromium-review.googlesource.com/1107272 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#569013} [modify] https://crrev.com/715862a72d01559f46457bd0fcfda37bc1d6e92b/chrome/browser/chromeos/accessibility/select_to_speak_browsertest.cc
,
Jun 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e84d85ed613d7f84a34853d719ceabe2d0cfc04 commit 2e84d85ed613d7f84a34853d719ceabe2d0cfc04 Author: Peter Boström <pbos@chromium.org> Date: Fri Jun 22 01:06:13 2018 Add and fix Refresh modes to toolbar-actions test Adds MATERIAL_REFRESH and MATERIAL_TOUCH_REFRESH to MD modes used in ToolbarActionsBarUnitTest and fixes the test to account for the separator area used in Refresh modes. Bug: chromium:846410 Change-Id: Ib6d45d26fc3ba273e3cc3c3613dae07c31af0c2b Reviewed-on: https://chromium-review.googlesource.com/1111269 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#569482} [modify] https://crrev.com/2e84d85ed613d7f84a34853d719ceabe2d0cfc04/chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc
,
Jun 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/302009c773b24acdda0342bcf54377de19f65038 commit 302009c773b24acdda0342bcf54377de19f65038 Author: Bret Sepulveda <bsep@chromium.org> Date: Sat Jun 23 00:30:28 2018 Fix tests programmatically setting the window size under Refresh. There were several tests that were failing because they were attempting to set the window to a particular size, and the minimum size of a window increases to more than that size when Refresh is enabled. TBR=gab@chromium.org Bug: 846410 , 853057 , 853044 Change-Id: Idad9ae2db2d0eacfc0432d9b5bb0ebe6734d47a4 Reviewed-on: https://chromium-review.googlesource.com/1111106 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#569857} [modify] https://crrev.com/302009c773b24acdda0342bcf54377de19f65038/chrome/browser/extensions/extension_fullscreen_apitest.cc [modify] https://crrev.com/302009c773b24acdda0342bcf54377de19f65038/chrome/browser/prefs/pref_service_browsertest.cc [modify] https://crrev.com/302009c773b24acdda0342bcf54377de19f65038/chrome/test/data/extensions/api_test/window_update/sizing/test.js [modify] https://crrev.com/302009c773b24acdda0342bcf54377de19f65038/chrome/test/data/profiles/window_placement/Default/Preferences
,
Jun 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f992cdd97b304bcc513368dd08a1be86f98cae1 commit 9f992cdd97b304bcc513368dd08a1be86f98cae1 Author: Bret Sepulveda <bsep@chromium.org> Date: Mon Jun 25 20:59:34 2018 Fix ChromeDriverTest.testWindowMinimize when Refresh is enabled. Under Refresh the minimum window size increases to more than the value the test is attempting to set the window to. This patch increases the test values. Bug: 846410 Change-Id: I6af5dce66424249402773a07d852d6245e8bfce3 Reviewed-on: https://chromium-review.googlesource.com/1114123 Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#570175} [modify] https://crrev.com/9f992cdd97b304bcc513368dd08a1be86f98cae1/chrome/test/chromedriver/test/run_py_tests.py
,
Jun 25 2018
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67594d06f38e9f2122392ab378988aae53ab5bc8 commit 67594d06f38e9f2122392ab378988aae53ab5bc8 Author: Bret Sepulveda <bsep@chromium.org> Date: Wed Jun 27 19:45:57 2018 Fix SadTabViewInteractiveUITest suite for Chrome OS when Refresh is on. The test assumed BlueButton would always be used for dialog buttons, but LabelButton is used in Harmony (which Refresh implies). Merging to M-68 because this fixes a test which is broken by https://chromium-review.googlesource.com/1072727 Bug: 846410 Change-Id: Id7fb8f66cc0abb120fdb81294c4d00c3faf060ae Reviewed-on: https://chromium-review.googlesource.com/1105457 Reviewed-by: Peter Boström <pbos@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#568272}(cherry picked from commit 3183d7ced9505e878652100378d62d20a8228d47) Reviewed-on: https://chromium-review.googlesource.com/1117518 Reviewed-by: Greg Levin <glevin@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#556} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/67594d06f38e9f2122392ab378988aae53ab5bc8/chrome/browser/ui/views/sad_tab_view_interactive_uitest.cc
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29ab2a912526ef6ff850fe1ae1a203583bcb5356 commit 29ab2a912526ef6ff850fe1ae1a203583bcb5356 Author: Bret Sepulveda <bsep@chromium.org> Date: Wed Jun 27 19:46:24 2018 Fix AXTreeSourceAuraTest.Accessors when Harmony is on. When Harmony is enabled textfields have an additional child in the form of the focus ring, so the expectation needed to be updated. Merging to M-68 because this fixes a test which is broken by https://chromium-review.googlesource.com/1072727 Bug: 846410 Change-Id: I0b807d7f69c97eed7bc56e9520f51d3a845fba76 Reviewed-on: https://chromium-review.googlesource.com/1103586 Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#568166}(cherry picked from commit d5010c9c9cff2a30d9d495d9c7a953da308ffa45) Reviewed-on: https://chromium-review.googlesource.com/1117499 Reviewed-by: Greg Levin <glevin@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#557} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/29ab2a912526ef6ff850fe1ae1a203583bcb5356/chrome/browser/ui/ash/accessibility/ax_tree_source_aura_unittest.cc |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by pkasting@chromium.org
, May 31 2018EstimatedDays: 7
Labels: -Pri-3 ReleaseBlock-Beta M-69 Pri-1