New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 846402 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 1
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-06-15
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - Way too many data points

Project Member Reported by lijeffrey@chromium.org, May 24 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/646d5ae0c8f6721e1cb40b836be422ef3f6c4da6

commit 646d5ae0c8f6721e1cb40b836be422ef3f6c4da6
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Thu May 24 23:07:14 2018

[Findit] Flake Analyzer - Round off commit position to nearest builds

The requested commit position is determined by the distance between the previously analyzed
builds' commit positions.

Previously, requested commit positions were mapped to the nearest valid earlier and later builds
on either side (b1, b2). next_commit_position_utils would then try to use b2 first, falling back
to b1 if b2 has already been analyzed. Originally this was to bias towards as recent builds as
possible, however lead to cases where b2 was too close to the build that was just analyzed. Thus
the next iteration would calculate a small distance and propose a requested commit position
that is still close to the build that were just analyzed. The net effect is exponential search
might degenerate into almost linear search.

The new approach is to compare the requested commit position to that of b1 and b2's commit
positions, and use whichever is closer to the requested commit position instead of always biasing
towards b2's all the time.

Bug:  846402 
Change-Id: Ib93d23b346247ac26c262ecaf5bc3ba357db24ad
Reviewed-on: https://chromium-review.googlesource.com/1072408
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/646d5ae0c8f6721e1cb40b836be422ef3f6c4da6/appengine/findit/services/flake_failure/next_commit_position_utils.py
[modify] https://crrev.com/646d5ae0c8f6721e1cb40b836be422ef3f6c4da6/appengine/findit/services/flake_failure/test/next_commit_position_utils_test.py

Status: Fixed (was: Assigned)

Comment 3 by st...@chromium.org, Jun 6 2018

Labels: -Pri-3 Pri-1
Did we verify this is in fact fixed?

Comment 4 by st...@chromium.org, Jun 6 2018

NextAction: 2018-06-08
Per offline discussion, this one still needs verification.
The NextAction date has arrived: 2018-06-08

Comment 6 by st...@chromium.org, Jun 14 2018

NextAction: 2018-06-15
Any updates on this?
The NextAction date has arrived: 2018-06-15

Comment 8 by st...@chromium.org, Jun 15 2018

Status: Assigned (was: Fixed)
Reopen as two pings didn't work to grab attention :)
The verification is still blocked on rerun for cq requests

Sign in to add a comment