New issue
Advanced search Search tips

Issue 846390 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Refactor 2-UA messaging to directly use mojo pipes

Project Member Reported by btolsch@chromium.org, May 24 2018

Issue description

For 1-UA messaging, the offscreen tab and the controller each get a blink::mojom::PresentationConnection that directly connects to the other page.  For 2-UA, the controller gets a connection that is connected to Media Router which proxies the messages to the extension via route messages.  We would like to directly connect the controller and MRP for 2-UA presentations as well.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ca10fb2914087fd1b2589dedf69f615595bdb4c

commit 8ca10fb2914087fd1b2589dedf69f615595bdb4c
Author: btolsch <btolsch@chromium.org>
Date: Wed Aug 29 01:35:09 2018

Refactor 2-UA messaging

This change allows MRPs to supply a pair of
blink::mojom::PresentationConnection mojo pipes to be used to directly
communicate with the controller in place of
BrowserPresentationConnectionProxy.  The mojo pipes are optional, to
allow backwards compatibility with extension versions that don't yet
support this change.  PSDImpl will revert to using
BrowserPresentationConnectionProxy if no pipes are provided in an
otherwise successful route reponse.

Bug: 846390
Change-Id: If4110499926bb5257c0e56ba6f7595e272ed05a3
Reviewed-on: https://chromium-review.googlesource.com/1072153
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Zhiqiang Zhang <zqzhang@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586985}
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/browser/media/android/router/media_router_android.cc
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/browser/media/android/router/media_router_android.h
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/browser/media/android/router/media_router_android_unittest.cc
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/browser/media/android/router/media_router_dialog_controller_android.cc
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/browser/media/router/media_router.h
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/browser/media/router/media_router_dialog_controller.cc
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/browser/media/router/media_router_dialog_controller.h
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/browser/media/router/media_router_dialog_controller_unittest.cc
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/browser/media/router/mojo/media_router_mojo_impl.h
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/browser/media/router/presentation/browser_presentation_connection_proxy.cc
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/browser/media/router/presentation/presentation_service_delegate_impl.cc
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/browser/media/router/presentation/presentation_service_delegate_impl.h
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/browser/media/router/presentation/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/browser/media/router/providers/cast/cast_media_route_provider.cc
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/browser/media/router/providers/dial/dial_media_route_provider.cc
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/browser/media/router/providers/dial/dial_media_route_provider_unittest.cc
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/browser/media/router/providers/wired_display/wired_display_media_route_provider.cc
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/browser/media/router/providers/wired_display/wired_display_media_route_provider_unittest.cc
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/browser/media/router/test/media_router_mojo_test.cc
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/browser/media/router/test/media_router_mojo_test.h
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/browser/media/router/test/mock_media_router.h
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/browser/ui/ash/cast_config_client_media_router.cc
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/browser/ui/media_router/media_router_ui_base.cc
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/browser/ui/media_router/media_router_ui_base.h
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/browser/ui/media_router/media_router_ui_helper.h
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/browser/ui/webui/media_router/media_router_dialog_controller_webui_impl_unittest.cc
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/common/media_router/mojo/BUILD.gn
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/common/media_router/mojo/media_router.mojom
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/test/media_router/media_router_e2e_browsertest.cc
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/chrome/test/media_router/media_router_e2e_browsertest.h
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/content/browser/presentation/presentation_service_impl.cc
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/content/browser/presentation/presentation_service_impl.h
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/content/browser/presentation/presentation_service_impl_unittest.cc
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/content/public/browser/presentation_service_delegate.h
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/third_party/WebKit/LayoutTests/presentation/presentation-controller-close-connection.html
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/third_party/WebKit/LayoutTests/presentation/presentation-controller-connection-closed-by-receiver.html
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/third_party/WebKit/LayoutTests/presentation/presentation-controller-terminate-connection.html
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/third_party/WebKit/LayoutTests/presentation/presentation-receiver-terminate-connection.html
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/third_party/WebKit/LayoutTests/presentation/resources/presentation-service-mock.js
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/third_party/blink/public/mojom/presentation/presentation.mojom
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/third_party/blink/renderer/modules/presentation/mock_presentation_service.h
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/third_party/blink/renderer/modules/presentation/presentation_connection.cc
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/third_party/blink/renderer/modules/presentation/presentation_connection.h
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/third_party/blink/renderer/modules/presentation/presentation_connection_callbacks.cc
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/third_party/blink/renderer/modules/presentation/presentation_connection_callbacks.h
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/third_party/blink/renderer/modules/presentation/presentation_controller.cc
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/third_party/blink/renderer/modules/presentation/presentation_controller.h
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/third_party/blink/renderer/modules/remoteplayback/remote_playback.cc
[modify] https://crrev.com/8ca10fb2914087fd1b2589dedf69f615595bdb4c/third_party/blink/renderer/modules/remoteplayback/remote_playback.h

Sign in to add a comment