New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 846388 link

Starred by 1 user
Status: Fixed
Owner:
█ jhawkins@chromium.org
Last visit > 30 days ago
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

SmartLock password input does not display "Click your photo"

Project Member Reported by jhawkins@chromium.org, May 24 2018 
The placeholder is set here [1], but that call has no effect without scheduling a paint.
Project Member

Comment 1 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2708eadbf26015b0fdce94180a1593c1b51c2c8

commit a2708eadbf26015b0fdce94180a1593c1b51c2c8
Author: James Hawkins <jhawkins@chromium.org>
Date: Thu May 24 20:19:11 2018

LoginPasswordView: SchedulePaint after setting placeholder text.

Otherwise any call after the initial SetPlaceholderText won't render.

R=jdufault@chromium.org

Bug:  846388 
Test: none
Change-Id: If3de184b8f7367658e9e0d920c9edbc45ee5d0f3
Reviewed-on: https://chromium-review.googlesource.com/1072227
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561603}
[modify] https://crrev.com/a2708eadbf26015b0fdce94180a1593c1b51c2c8/ash/login/ui/login_password_view.cc

Comment 2 by jhawkins@chromium.org, May 24 2018

Status: Fixed (was: Started)
►

Sign in to add a comment