Let me think of this, we also need to think about how to log metrics correctly for app shortcuts

A refactoring CL is about to land. 

https://chromium-review.googlesource.com/c/chromium/src/+/1068017

I would be surprised if it was broken still after that patch.

If you find out how it was broken please let me know!

ok

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5bad7fe34d6c31ccd858c75beba84141b4ec6b7

commit c5bad7fe34d6c31ccd858c75beba84141b4ec6b7
Author: Qiang Xu <warx@google.com>
Date: Thu Jun 21 23:22:53 2018

cros: consolidate uma record when executing app menu command

changes:
Consolidate uma recording when executing app menu command.
Both shelf and app list code record
Apps.ContextMenuExecuteCommand in AppMenuModelAdapter code
path. It was used to record in
SimpleMenuModel::RecordHistogram. However, app list doesn't
exercise through that path maybe due to the refactoring (it
calls delegate()'s code path now).

This CL fixes the regression. And it is more straightforward
to find where Apps.ContextMenuExecuteCommand UMA is recorded.

Bug:  846370 
Test: manual test
Change-Id: Ib59ab96f2647d068af55118e150b81b3758a4a60
Reviewed-on: https://chromium-review.googlesource.com/1107720
Commit-Queue: Qiang Xu <warx@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569443}
[modify] https://crrev.com/c5bad7fe34d6c31ccd858c75beba84141b4ec6b7/ash/app_list/views/app_list_menu_model_adapter.cc
[modify] https://crrev.com/c5bad7fe34d6c31ccd858c75beba84141b4ec6b7/ash/app_list/views/app_list_menu_model_adapter.h
[modify] https://crrev.com/c5bad7fe34d6c31ccd858c75beba84141b4ec6b7/ash/app_menu/app_menu_model_adapter.cc
[modify] https://crrev.com/c5bad7fe34d6c31ccd858c75beba84141b4ec6b7/ash/app_menu/app_menu_model_adapter.h
[modify] https://crrev.com/c5bad7fe34d6c31ccd858c75beba84141b4ec6b7/ash/shelf/shelf_menu_model_adapter.cc
[modify] https://crrev.com/c5bad7fe34d6c31ccd858c75beba84141b4ec6b7/ash/shelf/shelf_menu_model_adapter.h
[modify] https://crrev.com/c5bad7fe34d6c31ccd858c75beba84141b4ec6b7/ash/shelf/shelf_view.cc
[modify] https://crrev.com/c5bad7fe34d6c31ccd858c75beba84141b4ec6b7/chrome/browser/ui/app_list/app_context_menu.cc
[modify] https://crrev.com/c5bad7fe34d6c31ccd858c75beba84141b4ec6b7/chrome/browser/ui/app_list/arc/arc_app_context_menu.cc

Requesting merge to M-68 so these histograms work there too.

I'm already merging a few CLs so I'll merge this one too. Thanks for fixing this warx@!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/643c7010418385c03b75a6a4b5181115a4bbb405

commit 643c7010418385c03b75a6a4b5181115a4bbb405
Author: Alex Newcomer <newcomer@chromium.org>
Date: Tue Jun 26 15:35:16 2018

cros: Fix applist context menu execution histograms

These histograms were broken before the M68 branch. The code was
refactored after the branch, and the bug was fixed in M69.
This cl fixes the same bug fixed in M69, but avoids the
refactored part to minimize code changes.

Bug:  846370 
Change-Id: I9479157ec3db46bcde29b2d4272e62a977393085
Reviewed-on: https://chromium-review.googlesource.com/1114225
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#527}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/643c7010418385c03b75a6a4b5181115a4bbb405/ash/public/cpp/app_list/app_list_constants.cc
[modify] https://crrev.com/643c7010418385c03b75a6a4b5181115a4bbb405/ash/public/cpp/app_list/app_list_constants.h
[modify] https://crrev.com/643c7010418385c03b75a6a4b5181115a4bbb405/chrome/browser/ui/app_list/app_context_menu.cc
[modify] https://crrev.com/643c7010418385c03b75a6a4b5181115a4bbb405/chrome/browser/ui/app_list/arc/arc_app_context_menu.cc
[modify] https://crrev.com/643c7010418385c03b75a6a4b5181115a4bbb405/ui/app_list/views/app_list_item_view.cc
[modify] https://crrev.com/643c7010418385c03b75a6a4b5181115a4bbb405/ui/app_list/views/search_result_tile_item_view.cc