New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 846360 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Reduce V8 memory consumption of non-performance-critical frames

Project Member Reported by hpayer@chromium.org, May 24 2018

Issue description

Reduce V8 memory consumption of non-performance-critical frames
 

Comment 2 by jsc...@chromium.org, May 24 2018

Cc: chrisha@chromium.org

Comment 3 by dcheng@chromium.org, May 25 2018

Cc: dcheng@chromium.org

Comment 4 by creis@chromium.org, Jun 5 2018

Components: Internals>Sandbox>SiteIsolation
Labels: -Pri-3 OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows Pri-1
We'll use this bug to track field trials of Site Isolation + memory savings mode, to see what the impact is.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e3d725c21390af9a30d0cc98b0d1ac34b820ee9

commit 6e3d725c21390af9a30d0cc98b0d1ac34b820ee9
Author: Robert Sesek <rsesek@chromium.org>
Date: Wed Jun 06 14:38:02 2018

Add an experiment for enabling V8's memory savings mode on Android.

This feature works in conjunction with --site-per-process. When a renderer
process has only subframes, Blink's main thread isolate will be put
into a memory savings mode. If a main frame is created in the process,
the isolate will be taken out of memory savings mode for as long as a main
frame exists.

Bug: 846360
Change-Id: I09c362cce648b734fb01907a5ad758f0bdb7f752
Reviewed-on: https://chromium-review.googlesource.com/1076954
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564881}
[modify] https://crrev.com/6e3d725c21390af9a30d0cc98b0d1ac34b820ee9/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/6e3d725c21390af9a30d0cc98b0d1ac34b820ee9/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/6e3d725c21390af9a30d0cc98b0d1ac34b820ee9/content/common/renderer.mojom
[modify] https://crrev.com/6e3d725c21390af9a30d0cc98b0d1ac34b820ee9/content/public/common/content_features.cc
[modify] https://crrev.com/6e3d725c21390af9a30d0cc98b0d1ac34b820ee9/content/public/common/content_features.h
[modify] https://crrev.com/6e3d725c21390af9a30d0cc98b0d1ac34b820ee9/content/renderer/BUILD.gn
[add] https://crrev.com/6e3d725c21390af9a30d0cc98b0d1ac34b820ee9/content/renderer/low_memory_mode_controller.cc
[add] https://crrev.com/6e3d725c21390af9a30d0cc98b0d1ac34b820ee9/content/renderer/low_memory_mode_controller.h
[add] https://crrev.com/6e3d725c21390af9a30d0cc98b0d1ac34b820ee9/content/renderer/low_memory_mode_controller_unittest.cc
[modify] https://crrev.com/6e3d725c21390af9a30d0cc98b0d1ac34b820ee9/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/6e3d725c21390af9a30d0cc98b0d1ac34b820ee9/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/6e3d725c21390af9a30d0cc98b0d1ac34b820ee9/content/renderer/render_thread_impl.h
[modify] https://crrev.com/6e3d725c21390af9a30d0cc98b0d1ac34b820ee9/content/test/BUILD.gn
[modify] https://crrev.com/6e3d725c21390af9a30d0cc98b0d1ac34b820ee9/testing/variations/fieldtrial_testing_config.json
[modify] https://crrev.com/6e3d725c21390af9a30d0cc98b0d1ac34b820ee9/tools/metrics/histograms/histograms.xml

Thanks for the CL in #c5!  I can put together a CL configuring the field trail for this functionality (it probably needs to be coordinated with the current site-per-process trials and might be blocked by another in-flight field-trial-config-CL in this area).
Sounds good! Thanks for volunteering to handle the field trial setup.

Sign in to add a comment