[MD-Refresh] Spacing between extension button and Toolbar Divider could be also 8px (like between Toolbar Divider and profile button) |
|||||||||||||||||
Issue descriptionChrome Version: 68.0.3439.0 Canary OS: macOS 10.13.4 What steps will reproduce the problem? (1) Install an extension (2) Show its icon on the Toolbar (3) Hover over it (4) Take a look at the spacing between the extension hover button (HB) and the Toolbar Divider (5) Now hover over the Profile icon (6) Take a look at the spacing between the Toolbar Divider and the Profile icon HB What is the expected result? Both should have the same spacing (8px?). What happens instead? The spacing between the extension hover button and the Toolbar Divider is 10px. The spacing between the Toolbar Divider and the Profile icon HB is 8px. Thanks for looking into this issue :) Mehmet
,
May 30 2018
This is a pretty gross side effect of the extension icons being sized differently and the inkdrops being inset to 2dp less (for Refresh) than the actual button size, so the spacing is 8dp from the divider but then also 2dp inset into the extension buttons. :( This is incidentally also why there's 2dp of spacing before the location bar instead of 0dp. We should clean this up at some point and then the 8dp insets will be correct. I think we can live with being 2dp off until we clean up this code which we should do regardless.
,
May 31 2018
Triage
,
May 31 2018
,
Jun 1 2018
,
Jun 1 2018
,
Jun 28 2018
,
Jul 12
,
Jul 26
,
Aug 27
,
Sep 20
,
Sep 26
,
Oct 11
Sending to dfried@ for initial triage.
,
Oct 11
I think the Mac version is no longer around, so unifying ToolbarActionsBar with BrowserActionsContainer would be refactoring that would make this easier to resolve. We definitely have code debt in both because ToolbarActionsBar was trying to accommodate both Cocoa and Views versions.
,
Oct 17
Unassigning from myself as I'm not currently taking this, but it is a bug our team should consider working on later.
,
Nov 19
**UI mass Triage** Seems to be valid issue, adding respective labels.
,
Dec 11
,
Jan 4
Hey pbos@: Your CL https://chromium-review.googlesource.com/c/1394870 fixed this too :) Tested with Snapshot 620014. Closing as verified \o/
,
Jan 4
Hey I thought I had a bug for this, I just couldn't find it. :D |
|||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||
Comment 1 by meh...@chromium.org
, May 24 2018