[MD-Refresh] Spacing issue between Omnibox and Extension Icons Hover Button |
||||||||||
Issue descriptionChrome Version: 68.0.3439.0 Canary OS: macOS 10.13.4 What steps will reproduce the problem? (1) Install an extension (2) Show its icon on the Toolbar (3) Hover over it (4) Compare the spacing between the Omnibox and the extension hover button (HB) What is the expected result? It should be 8px, like between Reload icon HB and Omnibox or like Omnibox and Profile icon HB. What happens instead? The spacing is only 2px. This is a follow up to your fix from https://chromium-review.googlesource.com/1068179. I don't want to spam issue 822069 with my comments. Therefore this new report. Thanks :) Mehmet
,
May 31 2018
,
May 31 2018
Reassessed as P2 with bettes@
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1526d82653413c5c812f1b6d869e7b29389f5398 commit 1526d82653413c5c812f1b6d869e7b29389f5398 Author: Peter Boström <pbos@chromium.org> Date: Fri Jun 01 12:12:38 2018 Add spacing for browser actions' resize area This makes the toolbar area look less cramped, especially for Material refresh but even so in the current layout. Before this the resize area would overlap existing elements and there would be no spacing between this area and the omnibox. Bug: chromium:822069 , chromium:846353 Change-Id: I9eb566fe4369c1aae2ac275b6312effa67a0255a Reviewed-on: https://chromium-review.googlesource.com/1015620 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#563597} [modify] https://crrev.com/1526d82653413c5c812f1b6d869e7b29389f5398/chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc [modify] https://crrev.com/1526d82653413c5c812f1b6d869e7b29389f5398/chrome/browser/ui/views/toolbar/browser_actions_container.cc
,
Jun 1 2018
Done. Unfortunately you get 10dp left/right of the extensions as they are implemented as the wanted 8dp of padding but also 2dp insets *inside* the extension actions (why there were even 2dp to begin with and not 0). I think 10dp is a significantly better state of the world. Removing 2dp insets into the view is effectively tracked by issue 846358 , so I'm closing this.
,
Jun 1 2018
Thanks pbos@. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by markchang@chromium.org
, May 31 2018