New issue
Advanced search Search tips

Issue 846352 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 792546



Sign in to add a comment

CORB/NetworkService: Remove CrossSiteDocumentResourceHandler while preserving test coverage

Project Member Reported by lukasza@chromium.org, May 24 2018

Issue description

Once NetworkService ships, CrossSiteDocumentResourceHandler can be removed.


The following tests can be removed after CrossSiteDocumentResourceHandler is removed:

- CrossSiteDocumentBlockingServiceWorkerTest.NoNetwork
  (this test doesn't add value in the NetworkService world, where AFAIK ServiceWorker responses go straight to the right renderer process, without being seen by the browser process and/or the network process;  also note that CrossSiteDocumentBlockingServiceWorkerTest.NetworkToServiceWorkerResponse is still valuable because the responses tested there should still be going through the network service process)

- CrossSiteDocumentBlockingIsolatedOriginTest.BlockDocumentsFromIsolatedOrigin
  (hopefully by the time NetworkService ships, SitePerProcess would have already shipped and IsolateOrigins will no longer be a thing)


The following tests should be preserved, even after removing CrossSiteDocumentResourceHandler:

- All other browser tests in content/browser/loader/cross_site_document_blocking_browsertest.cc
  (with NetworkService it should be possible to simplify the code and unconditionally ignore some UMAs in InspectHistograms)

- All of content/browser/loader/cross_site_document_resource_handler_unittest.cc
  (this might be a bit tricky since these tests are somewhat closely-coupled with CrossSiteDocumentResourceHandler,
  but hopefully they can be moved to services/network/cross_origin_read_blocking_unittest.cc and tweaked to directly test CrossOriginReadBlocking::ResponseAnalyzer without loosing too much test coverage)

 
Cc: jam@chromium.org mmenke@chromium.org
+mmenke@ and jam@ to evaluate if this bug should also be tracked somewhere else - as part of a bigger list of work items to be done _after_ NetworkService ships.
My opinion is that if we care about what these tests are doing passing, we shouldn't ship the network service without porting these tests.

Sign in to add a comment