Omnibox popup overlays bottom of toolbar in ui refresh |
||||
Issue descriptionOmnibox popup layout likely needs a new view controller, with a new presenter.
,
May 24 2018
,
May 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24290222c0a1780c8849c3922acad244c245ca4d commit 24290222c0a1780c8849c3922acad244c245ca4d Author: Justin Cohen <justincohen@google.com> Date: Thu May 24 16:29:34 2018 [ios] Correct omnibox popup top constraint for ui refresh Bug: 846337 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5820f2715e41f9e13430a939a9d61cdca921bb70 Reviewed-on: https://chromium-review.googlesource.com/1071692 Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#561520} [modify] https://crrev.com/24290222c0a1780c8849c3922acad244c245ca4d/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_presenter.mm
,
May 25 2018
,
Jun 25 2018
For Phase 1, the decision is to keep the current implementation of the popup and just update the fonts/icons/colors. Therefore, this is unnecessary thanks to Justin's workaround above. |
||||
►
Sign in to add a comment |
||||
Comment 1 by justincohen@chromium.org
, May 24 2018