New issue
Advanced search Search tips

Issue 846329 link

Starred by 4 users
Status: Assigned
Owner:
ellyjo...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug
M-X



Sign in to add a comment

MacViews: popup window height computation is off

Project Member Reported by ellyjo...@chromium.org, May 24 2018 
I could swear I've already filed this, but I can't find the previous bug.

Anyway, in MacViews, when we're creating a popup, the window bounds do not include the titlebar, so the window ends up ~20px taller than requested by the caller. On other platforms (and in the Cocoa browser) the window bounds as requested do include the titlebar.
Project Member

Comment 1 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e908fe91c3cbc0bc55272f90f0c3db47f273d4d4

commit e908fe91c3cbc0bc55272f90f0c3db47f273d4d4
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Thu May 24 16:01:08 2018

macviews: fix some interactive UI tests

Two suites are Cocoa-only so they are marked as such.

PopupBlockerBrowserTest has one broken test because of a known bug; the part of
the test that fails is now skipped in Views mode on Mac.

TBR=sky@chromium.org

Bug: 845389,846329
Change-Id: I5643899196401bec3af23e5edcd28c1c865dbfaf
Reviewed-on: https://chromium-review.googlesource.com/1071730
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561515}
[modify] https://crrev.com/e908fe91c3cbc0bc55272f90f0c3db47f273d4d4/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc
[modify] https://crrev.com/e908fe91c3cbc0bc55272f90f0c3db47f273d4d4/chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm

Comment 2 by robliao@chromium.org, Jul 21

Labels: Group-Visual_Defects

Comment 3 by jmukthavaram@google.com, Nov 19

Labels: Hotlist-DesktopUIChecked Hotlist-DesktopUIValid
**UI Mass triage**

Adding respective labels  for expert review.
►

Sign in to add a comment