Issue metadata
Sign in to add a comment
|
[Compile Failure] Jumbo builds broken |
||||||||||||||||||||||
Issue description
Local builds with gn arg "use_jumbo_build = true"
In file included from gen/chrome/browser/browser_jumbo_6.cc:49:
./../../chrome/browser/net/net_error_tab_helper.cc:36:16: error: target of using declaration conflicts with declaration already in scope
using content::WebContentsObserver;
^
../../content/public/browser/web_contents_observer.h:64:22: note: target of using declaration
class CONTENT_EXPORT WebContentsObserver : public IPC::Listener {
^
../../chrome/browser/resource_coordinator/tab_load_tracker.h:16:7: note: conflicting declaration
class WebContentsObserver;
^
So far, no suspecting CLs.
(We should definitely have bots for that).
,
May 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd6ff3fc84bd780c80d6d29f729488f54e74d6bc commit bd6ff3fc84bd780c80d6d29f729488f54e74d6bc Author: Fredrik Söderquist <fs@opera.com> Date: Thu May 24 15:46:33 2018 Remove stray, unneeded (and incorrect) forward declaration WebContentsObserver is in the 'content' namespace, not in the global. This causes a collision with a 'using' directive for the same class, which breaks Jumbo builds. TBR=avi@chromium.org,siggi@chromium.org Bug: 755840, 846328 Change-Id: I977106611b374c955bf3c5c161c8a52eea927698 Reviewed-on: https://chromium-review.googlesource.com/1071663 Reviewed-by: Fredrik Söderquist <fs@opera.com> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#561512} [modify] https://crrev.com/bd6ff3fc84bd780c80d6d29f729488f54e74d6bc/chrome/browser/resource_coordinator/tab_load_tracker.h
,
May 24 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by f...@opera.com
, May 24 2018Status: Started (was: Available)
Summary: [Compile Failure] Jumbo builds broken (was: [Compile Failure] Jumob builds broken)