New issue
Advanced search Search tips

Issue 846327 link

Starred by 1 user
Status: Fixed
Owner:
guidou@chromium.org
Closed: May 2018
Cc:
guidou@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task



Sign in to add a comment

Replace std::function with base::Callback in MediaDevicesManager

Project Member Reported by guidou@chromium.org, May 24 2018 
An utility function uses std::function, but it should use base::Callback since std::function is banned by the style guide.
Project Member

Comment 1 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/431b81c648391417be6dc66fbbb61f775df362f3

commit 431b81c648391417be6dc66fbbb61f775df362f3
Author: Guido Urdaneta <guidou@chromium.org>
Date: Thu May 24 16:55:17 2018

Replace std::function with base::Callback in MediaDevicesManager.

std::function is banned by the style guide.

No behavior change intended.

Bug:  846327 
Change-Id: I7bd3c0bf082147491e5784626a8f74beb1c06719
Reviewed-on: https://chromium-review.googlesource.com/1071517
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561527}
[modify] https://crrev.com/431b81c648391417be6dc66fbbb61f775df362f3/content/browser/renderer_host/media/media_devices_manager.cc

Comment 2 by guidou@chromium.org, May 24 2018

Status: Fixed (was: Started)

Comment 3 by anatolid@chromium.org, Jun 7 2018 

[bulk-edit: disregard if N/A] Can the owner please set milestone to this bug if applicable?
►

Sign in to add a comment