OverscrollActionsView label text color too dim in incognito mode |
||
Issue descriptionChrome Version: (copy from chrome://version) OS: (e.g. Win10, MacOS 10.12, etc...) What steps will reproduce the problem? (1)Open the "UI refresh phase 1" flag in chrome://flags (2)Open a new tab in incognito mode (3)Pull to refresh, check the color of the label text "refresh". What is the expected result? Lighter color, like white. What happens instead? Gray color. Please use labels and text to provide additional information. If this is a regression (i.e., worked before), please consider using the bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help us identify the root cause and more rapidly triage the issue. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
May 25 2018
The NextAction date has arrived: 2018-05-25
,
May 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23fe24b803232670b8e36bd94668c4891b3bef24 commit 23fe24b803232670b8e36bd94668c4891b3bef24 Author: Yi Su <mrsuyi@chromium.org> Date: Mon May 28 14:02:14 2018 set label text color to white while incognito set label text color to white in the setStyle func in overscroll_actions_view.mm. In incognito mode, the text color of the label in overscroll view is gray, which appears to be too dim and hard to see. We will set it to white color. Bug: 846321 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If75cb5ab361fe21e580adebe75716abc0d2a1f54 Reviewed-on: https://chromium-review.googlesource.com/1071514 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#562253} [modify] https://crrev.com/23fe24b803232670b8e36bd94668c4891b3bef24/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_view.mm
,
Jun 5 2018
Tested in 69.0.3450.0 Canary in iPhone 7(iOS 11.3.1) and iPhone7plus(iOS 10.3.3) Text of the pull to refresh in incognito displays in white, looks good Link to screenshot: https://drive.google.com/file/d/1lOYooK0VoqZx2vT8D7qow2UJGp3CNKMj/view?usp=sharing
,
Jul 2
|
||
►
Sign in to add a comment |
||
Comment 1 by mrsuyi@chromium.org
, May 24 2018