New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 846316 link

Starred by 4 users
Status: Fixed
Owner:
nicolaso@chromium.org
Closed: Dec 17
Cc:
pastarmovj@chromium.org
█ jackalberto@chromium.org
█ norikob@chromium.org
█ omadden@chromium.org
privard@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Feature

Blocking:
issue 914423



Sign in to add a comment

FR: Legacy Browser Support (LBS) - policy to point hosts to open in alternative browser to an external XML file

Project Member Reported by norikob@google.com, May 24 2018 
UserAgent: Mozilla/5.0 (X11; CrOS x86_64 10452.96.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.181 Safari/537.36

Steps to reproduce the problem:
Today - adding hosts to alternative browser policy is manual and cumbersome when there are many urls to manage. Being able to have a policy that can point to an external file can help with auditing/tracking changes and easier editing to add/remove urls.  

What is the expected behavior?

What went wrong?
Today it is a pain to manage a large number of URL's for alternative hosts policy and while you can point to the Enterprise Mode Site list, having a separate list to manage to remove some sites that work better in Chrome from that list would be the preferred method. 

Did this work before? N/A 

Chrome version: 66.0.3359.181  Channel: stable
OS Version: 10452.96.0
Flash Version:

Comment 1 by norikob@chromium.org, May 24 2018

Cc: omadden@chromium.org jackalberto@chromium.org norikob@chromium.org
Labels: -Type-Bug -Pri-2 Pri-3 Type-Feature

Comment 2 by pastarmovj@chromium.org, May 25 2018

Cc: privard@chromium.org
Labels: -Pri-3 Pri-2
Owner: pastarmovj@chromium.org
Adding to the queue for LBS 6.

Comment 3 by krajshree@chromium.org, Jul 4

Labels: Triaged-ET M-69 Needs-Milestone Target-69 FoundIn-69
Status: Untriaged (was: Unconfirmed)
The issue seems to be a feature request. Hence, marking it as untriaged for further inputs from dev team.

Thanks...!!

Comment 4 by benhenry@chromium.org, Aug 3

Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".

Comment 5 by nicolaso@chromium.org, Oct 3

Cc: nicolaso@chromium.org

Comment 6 by nicolaso@chromium.org, Oct 31

Labels: Hotlist-Enterprise-Fixit

Comment 7 by pastarmovj@chromium.org, Nov 22

Cc: -nicolaso@chromium.org pastarmovj@chromium.org
Labels: -M-69 -FoundIn-69 -Target-69 M-74
Owner: nicolaso@chromium.org
I think this will only be a feature of the built into Chrome LBS version. Thus reassigning to nicolaso@ who already have most of the logic for this built in.

Comment 8 by nicolaso@chromium.org, Dec 10

Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2dc0883db6f448313cddf6b925e02ba1ced06020

commit 2dc0883db6f448313cddf6b925e02ba1ced06020
Author: Nicolas Ouellet-payeur <nicolaso@chromium.org>
Date: Wed Dec 12 21:10:14 2018

[BrowserSwitcher] Add BrowserSwitcherExternalSitelistUrl policy

This policy behaves a lot like BrowserSwitcherUseIeSitelist, except it
can point to a different URL than the one IE uses.

Bug:  846316 
Change-Id: I52f91019aabcdd9b20163198195770fb52183e98
Reviewed-on: https://chromium-review.googlesource.com/c/1361327
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616039}
[modify] https://crrev.com/2dc0883db6f448313cddf6b925e02ba1ced06020/chrome/browser/browser_switcher/browser_switcher_prefs.cc
[modify] https://crrev.com/2dc0883db6f448313cddf6b925e02ba1ced06020/chrome/browser/browser_switcher/browser_switcher_prefs.h
[modify] https://crrev.com/2dc0883db6f448313cddf6b925e02ba1ced06020/chrome/browser/browser_switcher/browser_switcher_service.cc
[modify] https://crrev.com/2dc0883db6f448313cddf6b925e02ba1ced06020/chrome/browser/browser_switcher/browser_switcher_service.h
[modify] https://crrev.com/2dc0883db6f448313cddf6b925e02ba1ced06020/chrome/browser/browser_switcher/browser_switcher_service_browsertest.cc
[modify] https://crrev.com/2dc0883db6f448313cddf6b925e02ba1ced06020/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/2dc0883db6f448313cddf6b925e02ba1ced06020/chrome/test/BUILD.gn
[modify] https://crrev.com/2dc0883db6f448313cddf6b925e02ba1ced06020/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/2dc0883db6f448313cddf6b925e02ba1ced06020/components/policy/resources/policy_templates.json
[modify] https://crrev.com/2dc0883db6f448313cddf6b925e02ba1ced06020/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/2dc0883db6f448313cddf6b925e02ba1ced06020/tools/traffic_annotation/summary/annotations.xml
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb49e86c1ddd5412c3dcbe35acd0c6110994e143

commit bb49e86c1ddd5412c3dcbe35acd0c6110994e143
Author: Hongchan Choi <hongchan@chromium.org>
Date: Thu Dec 13 18:51:31 2018

Revert "[BrowserSwitcher] Add BrowserSwitcherExternalSitelistUrl policy"

This reverts commit 2dc0883db6f448313cddf6b925e02ba1ced06020.

Reason for revert: Flaky tests. See  crbug.com/914657 

Original change's description:
> [BrowserSwitcher] Add BrowserSwitcherExternalSitelistUrl policy
> 
> This policy behaves a lot like BrowserSwitcherUseIeSitelist, except it
> can point to a different URL than the one IE uses.
> 
> Bug:  846316 
> Change-Id: I52f91019aabcdd9b20163198195770fb52183e98
> Reviewed-on: https://chromium-review.googlesource.com/c/1361327
> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
> Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#616039}

TBR=pastarmovj@chromium.org,rhalavati@chromium.org,nicolaso@chromium.org

Change-Id: Ic9185269f075ca32e07c29baddc41cde9dadb452
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  846316 
Reviewed-on: https://chromium-review.googlesource.com/c/1376097
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616376}
[modify] https://crrev.com/bb49e86c1ddd5412c3dcbe35acd0c6110994e143/chrome/browser/browser_switcher/browser_switcher_prefs.cc
[modify] https://crrev.com/bb49e86c1ddd5412c3dcbe35acd0c6110994e143/chrome/browser/browser_switcher/browser_switcher_prefs.h
[modify] https://crrev.com/bb49e86c1ddd5412c3dcbe35acd0c6110994e143/chrome/browser/browser_switcher/browser_switcher_service.cc
[modify] https://crrev.com/bb49e86c1ddd5412c3dcbe35acd0c6110994e143/chrome/browser/browser_switcher/browser_switcher_service.h
[modify] https://crrev.com/bb49e86c1ddd5412c3dcbe35acd0c6110994e143/chrome/browser/browser_switcher/browser_switcher_service_browsertest.cc
[modify] https://crrev.com/bb49e86c1ddd5412c3dcbe35acd0c6110994e143/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/bb49e86c1ddd5412c3dcbe35acd0c6110994e143/chrome/test/BUILD.gn
[modify] https://crrev.com/bb49e86c1ddd5412c3dcbe35acd0c6110994e143/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/bb49e86c1ddd5412c3dcbe35acd0c6110994e143/components/policy/resources/policy_templates.json
[modify] https://crrev.com/bb49e86c1ddd5412c3dcbe35acd0c6110994e143/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/bb49e86c1ddd5412c3dcbe35acd0c6110994e143/tools/traffic_annotation/summary/annotations.xml
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df0c29b1fc457224e68af2085835334470da264a

commit df0c29b1fc457224e68af2085835334470da264a
Author: Nicolas Ouellet-payeur <nicolaso@chromium.org>
Date: Mon Dec 17 17:24:23 2018

Reland "[BrowserSwitcher] Add BrowserSwitcherExternalSitelistUrl policy"

This is a reland of 2dc0883db6f448313cddf6b925e02ba1ced06020

Original change's description:
> [BrowserSwitcher] Add BrowserSwitcherExternalSitelistUrl policy
>
> This policy behaves a lot like BrowserSwitcherUseIeSitelist, except it
> can point to a different URL than the one IE uses.
>
> Bug:  846316 
> Change-Id: I52f91019aabcdd9b20163198195770fb52183e98
> Reviewed-on: https://chromium-review.googlesource.com/c/1361327
> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
> Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#616039}

TBR=rhalavati@chromium.org

Bug:  846316 ,  914611 
Change-Id: If8421e620c95eb2bdb4ab2d5d9d1a3a71c2390eb
Reviewed-on: https://chromium-review.googlesource.com/c/1377135
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617146}
[modify] https://crrev.com/df0c29b1fc457224e68af2085835334470da264a/chrome/browser/browser_switcher/browser_switcher_prefs.cc
[modify] https://crrev.com/df0c29b1fc457224e68af2085835334470da264a/chrome/browser/browser_switcher/browser_switcher_prefs.h
[modify] https://crrev.com/df0c29b1fc457224e68af2085835334470da264a/chrome/browser/browser_switcher/browser_switcher_service.cc
[modify] https://crrev.com/df0c29b1fc457224e68af2085835334470da264a/chrome/browser/browser_switcher/browser_switcher_service.h
[modify] https://crrev.com/df0c29b1fc457224e68af2085835334470da264a/chrome/browser/browser_switcher/browser_switcher_service_browsertest.cc
[modify] https://crrev.com/df0c29b1fc457224e68af2085835334470da264a/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/df0c29b1fc457224e68af2085835334470da264a/chrome/test/BUILD.gn
[modify] https://crrev.com/df0c29b1fc457224e68af2085835334470da264a/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/df0c29b1fc457224e68af2085835334470da264a/components/policy/resources/policy_templates.json
[modify] https://crrev.com/df0c29b1fc457224e68af2085835334470da264a/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/df0c29b1fc457224e68af2085835334470da264a/tools/traffic_annotation/summary/annotations.xml

Comment 12 by nicolaso@chromium.org, Dec 17

Status: Fixed (was: Started)
►

Sign in to add a comment