New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 846309 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Dice M3] SettingsA11ySignOut.SIGN_OUT_* tests are failing

Project Member Reported by droger@chromium.org, May 24 2018

Issue description

When enabling Dice M3, all these tests fail

To repro: enable Dice M3 in filedtrial_testing_config, like:
https://chromium-review.googlesource.com/c/chromium/src/+/1071289


Test output is similar to this:


[234801:234809:0524/150631.296214:ERROR:instance.cc(49)] Unable to locate service manifest for ui
[234801:234809:0524/150631.296339:ERROR:service_manager.cc(942)] Failed to resolve service name: ui
[234801:234801:0524/150631.373838:WARNING:password_store_factory.cc(250)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[234801:234801:0524/150631.591954:WARNING:gaia_auth_fetcher.cc(902)] Could not reach Google Accounts servers: errno -11
[234801:234801:0524/150632.593599:WARNING:gaia_auth_fetcher.cc(902)] Could not reach Google Accounts servers: errno -11
[234801:234801:0524/150633.408993:INFO:CONSOLE(1236)] "Running TestCase SettingsA11ySignOut.SIGN_OUT_accesskeys", source: file:///usr/local/google/home/droger/dev/chromium/src/chrome/test/data/webui/test_api.js (1236)
[234801:234801:0524/150634.275191:WARNING:CONSOLE(24)] "Error: Assertion failed
    at assert (chrome://settings/crisper.js:24:144)
    at Accessible Dialog.browserProxy.getSyncStatus.then (file:///usr/local/google/home/droger/dev/chromium/src/out/Release/test_data/chrome/test/data/webui/settings/a11y/sign_out_a11y_test.js:72:9)", source: chrome://settings/crisper.js (24)
[234801:234801:0524/150634.276608:ERROR:CONSOLE(48)] "Mocha test failed: SIGN_OUT_accesskeys Accessible Dialog
Error: Assertion failed
    at assert (crisper.js:24:144)
    at Accessible Dialog.browserProxy.getSyncStatus.then (file:///usr/local/google/home/droger/dev/chromium/src/out/Release/test_data/chrome/test/data/webui/settings/a11y/sign_out_a11y_test.js:72:9)
", source: file:///usr/local/google/home/droger/dev/chromium/src/chrome/test/data/webui/mocha_adapter.js (48)
[234801:234801:0524/150634.498306:ERROR:web_ui_test_handler.cc(100)] Test Errors: 1/1 tests had failed assertions.
[234801:234801:0524/150634.498527:ERROR:web_ui_browser_test.cc(474)] CONDITION FAILURE: encountered javascript console error(s):
[234801:234801:0524/150634.498553:ERROR:web_ui_browser_test.cc(476)] JS ERROR: '[234801:234801:0524/150634.276608:ERROR:CONSOLE(48)] "Mocha test failed: SIGN_OUT_accesskeys Accessible Dialog
Error: Assertion failed
    at assert (crisper.js:24:144)
    at Accessible Dialog.browserProxy.getSyncStatus.then (file:///usr/local/google/home/droger/dev/chromium/src/out/Release/test_data/chrome/test/data/webui/settings/a11y/sign_out_a11y_test.js:72:9)
", source: file:///usr/local/google/home/droger/dev/chromium/src/chrome/test/data/webui/mocha_adapter.js (48)
'
[234801:234801:0524/150634.498583:ERROR:web_ui_browser_test.cc(478)] JS call assumed failed, because JS console error(s) found.
gen/chrome/test/data/webui/settings/a11y/sign_out_a11y_test-gen.cc:51: Failure
Value of: RunJavascriptTestF( true, "SettingsA11ySignOut", "SIGN_OUT_accesskeys")
  Actual: false
Expected: true
Stack trace:
#0 0x0000026149cc testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x0000026143a9 testing::internal::AssertHelper::operator=()
#2 0x000002553b78 SettingsA11ySignOut_SIGN_OUT_accesskeys_Test::RunTestOnMainThread()
#3 0x0000031887fe content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#4 0x000002c5edfa ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#5 0x000002c5db9a ChromeBrowserMainParts::PreMainMessageLoopRun()
#6 0x7f649a03e031 content::BrowserMainLoop::PreMainMessageLoopRun()
#7 0x7f649a529035 content::StartupTaskRunner::RunAllTasksNow()
#8 0x7f649a03ca9c content::BrowserMainLoop::CreateStartupTasks()
#9 0x7f649a040dc5 content::BrowserMainRunnerImpl::Initialize()
#10 0x7f649a03a4b5 content::BrowserMain()
#11 0x7f649aaeed2a content::RunBrowserProcessMain()
#12 0x7f649aaefda4 content::ContentMainRunnerImpl::Run()
#13 0x7f64980d76bf service_manager::Main()
#14 0x7f649aaedb94 content::ContentMain()
#15 0x000003188362 content::BrowserTestBase::SetUp()
#16 0x000002bf6300 InProcessBrowserTest::SetUp()

[234801:234809:0524/150634.696095:WARNING:discardable_shared_memory_manager.cc(431)] Some MojoDiscardableSharedMemoryManagerImpls are still alive. They will be leaked.
[234801:234801:0524/150634.698472:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[234801:234801:0524/150634.700565:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[234801:234801:0524/150634.700613:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[234801:234987:0524/150634.706004:WARNING:internal_linux.cc(64)] Failed to read /proc/234833/stat

 

Comment 1 by droger@chromium.org, May 24 2018

scottchen, tangltom: is this code you are familiar with? Any idea what could be the problem?

Comment 2 by droger@chromium.org, May 24 2018

I guess the fundamental reason is that there is no longer a signout button when Dice is enabled. We should probably just disable these tests in this case.

Comment 3 by droger@chromium.org, May 25 2018

scottchen:
The test is failing on this line:
assert(!!disconnectButton);

https://cs.chromium.org/chromium/src/chrome/test/data/webui/settings/a11y/sign_out_a11y_test.js?rcl=a018e2356a5ed786778b2d4a25851c6229fedff0&l=72

looking at the code, it seems that with Dice, the button is now "turn-off" instead of "disconnectButton".
However, I tried changing  "disconnectButton" to "turn-off" in the test and the button is still not found.
Do you know how to access the new button in the code?
I could also just disable the test when Dice is enabled, but that seems suboptimal.
Owner: scottchen@chromium.org
assigning to scottchen to answer question in #3. You can reassign to me for the actual implementation.
The turn-off button is within an element in the people-page now, see [1] and [2].

Try
this.peoplePage.$$('settings-sync-account-control #turn-off')
or
this.peoplePage.$$('settings-sync-account-control').$$('#turn-off')

[1]https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/people_page/people_page.html?sq=package:chromium&dr&g=0&l=142
[2]https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/people_page/sync_account_control.html?sq=package:chromium&dr&g=0&l=194
Owner: droger@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b8e72cc13ed78a99502e56c50d96f595c4a1f20

commit 5b8e72cc13ed78a99502e56c50d96f595c4a1f20
Author: David Roger <droger@chromium.org>
Date: Thu Jun 07 10:26:03 2018

[signin] Add Dice support in SettingsA11ySignOut.SIGN_OUT_* tests

Bug:  846309 
Change-Id: Iaf60faa0312f8c52f575e5d1d5a561487db364a5
Reviewed-on: https://chromium-review.googlesource.com/1087229
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565218}
[modify] https://crrev.com/5b8e72cc13ed78a99502e56c50d96f595c4a1f20/chrome/test/data/webui/settings/a11y/sign_out_a11y_test.js

Status: Fixed (was: Assigned)

Sign in to add a comment