New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 846304 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
OOO until Feb 4th
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Supersize: Allow multiple .o.whitelist files to reference the same symbol

Project Member Reported by wnwen@chromium.org, May 24 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, May 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/428f805f67405aafe534c68861daebea9230aeff

commit 428f805f67405aafe534c68861daebea9230aeff
Author: Peter Wen <wnwen@chromium.org>
Date: Mon May 28 19:19:46 2018

Supersize: Add aliases for pak symbols

When different .cc files use the same pak symbol, we want to attribute
size correctly to all usages.

Also rename overhead for each pak file to the proper overhead format.

Add tests for associating pak files with the right object paths.

Bug:  846304 
Change-Id: I07be2f53ad75e90dc3623c182b4929e17c18a0f8
Reviewed-on: https://chromium-review.googlesource.com/1075289
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562298}
[modify] https://crrev.com/428f805f67405aafe534c68861daebea9230aeff/tools/binary_size/libsupersize/archive.py
[modify] https://crrev.com/428f805f67405aafe534c68861daebea9230aeff/tools/binary_size/libsupersize/testdata/Archive_Apk.golden
[modify] https://crrev.com/428f805f67405aafe534c68861daebea9230aeff/tools/binary_size/libsupersize/testdata/Archive_Pak_Files.golden
[add] https://crrev.com/428f805f67405aafe534c68861daebea9230aeff/tools/binary_size/libsupersize/testdata/mock_output_directory/obj/base/base/page_allocator.o.whitelist
[add] https://crrev.com/428f805f67405aafe534c68861daebea9230aeff/tools/binary_size/libsupersize/testdata/mock_output_directory/obj/third_party/icu/icuuc/ucnv_ext.o.whitelist

Comment 2 by wnwen@chromium.org, May 28 2018

Status: Fixed (was: Assigned)

Sign in to add a comment