New issue
Advanced search Search tips

Issue 846302 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

ios_chrome_integration_egtests failing

Project Member Reported by sdefresne@chromium.org, May 24 2018

Issue description

On bijou-simulator bot, ios_chrome_integration_egtests is consistently failing in FeatureEngagementTestCase/testBadgedReadingListFeatureShouldShow on iPad 11.2.

https://uberchromegw.corp.google.com/i/internal.bling.main/builders/bijou-simulator

olivierrobin: can you investigate?
 
Cc: gambard@chromium.org
Components: UI>Browser>ReaderMode
gambard, is reading list badge even supported in bijou?
Cc: olivierrobin@chromium.org
Owner: gambard@chromium.org
I think it might be related to the changes I have landed yesterday and broke the simulator in  issue 845925 .
I will take a look this afternoon.
Project Member

Comment 3 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb3688d8cd32c33f82cbdd916c075483bfd13761

commit fb3688d8cd32c33f82cbdd916c075483bfd13761
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu May 24 15:42:16 2018

Fix testBadgedReadingListFeatureShouldShow

Bug:  846302 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I959a7b1657531d7170a35df69dd38d210122ea1d
Reviewed-on: https://chromium-review.googlesource.com/1071661
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561510}
[modify] https://crrev.com/fb3688d8cd32c33f82cbdd916c075483bfd13761/ios/chrome/browser/feature_engagement/feature_engagement_egtest.mm

Status: Fixed (was: Assigned)

Sign in to add a comment