New issue
Advanced search Search tips

Issue 846291 link

Starred by 1 user
Status: Fixed
Owner:
aee@chromium.org
Closed: May 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unwanted vertical scroll bar is seen on 'Add bookmark' overlay in chrome://bookmarks/

Reported by rp...@etouch.net, May 24 2018 
Chrome version: 68.0.3439.0 (Official Build) Revision 1666e272389d5933c9d96ce25114aa327dfb9233-refs/branch-heads/3439@{#1}(32/64-bit)
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.5)

What steps will reproduce the problem?
1. Launch chrome,navigate to chrome://bookmarks/
2. Now right click on page and click on 'Add new bookmark' and observe 'Add bookmark' overlay
 
Actual: Unwanted vertical scroll bar is seen on 'Add bookmark' overlay
Expected: Unwanted vertical scroll bar should not be seen on 'Add bookmark' overlay

This is regression issue, broken in ‘M 68’ and below is the bisect info :
Good build: 68.0.3438.3  (Revision: 560884).
Bad build: 68.0.3439.0 (Revision: 561388).

You are probably looking for a change made after 561364 (known good), but no later than 561365 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/2d085ab3bdfac01d330584c3447ca00f84417811..29bc0a300e670bb159425a47a5ad7bade2cdf386

Suspect : https://chromium.googlesource.com/chromium/src/+/29bc0a300e670bb159425a47a5ad7bade2cdf386

From the CL above, assigning the issue to the concern owner 

@aee- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
Actual_video.mp4
148 KB View Download
Expected_video.mp4
121 KB View Download
Actual_screenshot.png
88.8 KB View Download
Expected_screenshot.png
88.1 KB View Download

Comment 1 by aee@chromium.org, May 24 2018

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5dab43b7c18fb23e13ff122a02571ba29dffdf71

commit 5dab43b7c18fb23e13ff122a02571ba29dffdf71
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Thu May 24 22:09:17 2018

Bookmarks: set fixed height of dialog depending on number of inputs

Bug:  846291 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I16f71655271eab77480c3744250618a2077481fe
Reviewed-on: https://chromium-review.googlesource.com/1072041
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561652}
[modify] https://crrev.com/5dab43b7c18fb23e13ff122a02571ba29dffdf71/chrome/browser/resources/md_bookmarks/edit_dialog.html
[modify] https://crrev.com/5dab43b7c18fb23e13ff122a02571ba29dffdf71/chrome/browser/resources/md_bookmarks/edit_dialog.js

Comment 3 by aee@chromium.org, May 24 2018

Status: Fixed (was: Started)

Comment 4 by rp...@etouch.net, May 25 2018

Labels: TE-Verified-68.0.3440.0 TE-Verified-M68
Update : 
Rechecked the above issue on Windows (7,8,8.1,10) and Mac OS X(10.12.6,10.13.1,10.13.5) OS using latest Canary Chrome version : 68.0.3440.0 and on Linux (14.04 LTS) using build : 68.0.3440.2 and the issue is fixed.Kindly refer the attached screen cast for reference.
Fixed_video.mp4
323 KB View Download

Comment 5 by rp...@etouch.net, May 25 2018

Labels: TE-Verified-68.0.3440.2
►

Sign in to add a comment