New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 846289 link

Starred by 2 users
Status: Duplicate
Merged: issue 846313
Owner: ----
Closed: May 2018
Cc:
perezju@chromium.org
█ kbr@chromium.org
brucedaw...@chromium.org
eyaich@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

* core.stacktrace_unittest.TabStackTraceTest.testValidDump failing on win bots

Project Member Reported by nednguyen@chromium.org, May 24 2018

Comment 1 by nednguyen@chromium.org, May 24 2018

Cc: kbr@chromium.org
Summary: * core.stacktrace_unittest.TabStackTraceTest.testValidDump failing on win bots (was: * core.stacktrace_unittest.TabStackTraceTest.testValidDump flaky on win bots)
First failing build: https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%281%29/80170

Log:
  Found crashpad_database_util
  Minidump found: e:\b\swarm_slave\w\ittiixl2\tmpmn_uw9\reports\f37bea3b-f8ad-4d42-bf2b-4916ebb344a5.dmp
  Uploading e:\b\swarm_slave\w\ittiixl2\tmpmn_uw9\reports\f37bea3b-f8ad-4d42-bf2b-4916ebb344a5.dmp to gs://chrome-telemetry-output/minidump-2018-05-23_09-41-30-279905.dmp
  Problem when trying to gather stack trace:
  Traceback (most recent call last):
    File "e:\b\swarm_slave\w\ir\third_party\catapult\telemetry\telemetry\core\exceptions.py", line 72, in __init__
      self._is_valid_dump, trace_output = app.GetStackTrace()
    File "e:\b\swarm_slave\w\ir\third_party\catapult\telemetry\telemetry\internal\browser\browser.py", line 237, in GetStackTrace
      return self._browser_backend.GetStackTrace()
    File "e:\b\swarm_slave\w\ir\third_party\catapult\common\py_trace_event\py_trace_event\trace_event_impl\decorators.py", line 52, in traced_function
      return func(*args, **kwargs)
    File "e:\b\swarm_slave\w\ir\third_party\catapult\telemetry\telemetry\internal\backends\chrome\desktop_browser_backend.py", line 493, in GetStackTrace
      return self._InternalSymbolizeMinidump(most_recent_dump)
    File "e:\b\swarm_slave\w\ir\third_party\catapult\common\py_trace_event\py_trace_event\trace_event_impl\decorators.py", line 52, in traced_function
      return func(*args, **kwargs)
    File "e:\b\swarm_slave\w\ir\third_party\catapult\telemetry\telemetry\internal\backends\chrome\desktop_browser_backend.py", line 527, in _InternalSymbolizeMinidump
      stack = self._GetStackFromMinidump(minidump_path)
    File "e:\b\swarm_slave\w\ir\third_party\catapult\common\py_trace_event\py_trace_event\trace_event_impl\decorators.py", line 52, in traced_function
      return func(*args, **kwargs)
    File "e:\b\swarm_slave\w\ir\third_party\catapult\telemetry\telemetry\internal\backends\chrome\desktop_browser_backend.py", line 437, in _GetStackFromMinidump
      '-z', minidump])
    File "e:\b\swarm_slave\w\ir\.swarming_module\bin\Lib\subprocess.py", line 219, in check_output
      raise CalledProcessError(retcode, cmd, output=output)
  CalledProcessError: Command '['e:\\b\\swarm_slave\\w\\ir\\out\\Release\\cdb\\cdb.exe', '-y', 'e:\\b\\swarm_slave\\w\\ir\\out\\Release', '-c', '.ecxr;.lastevent;kb30;~*kb30;q', '-z', 'e:\\b\\swarm_slave\\w\\ittiixl2\\tmpmn_uw9\\reports\\f37bea3b-f8ad-4d42-bf2b-4916ebb344a5.dmp']' returned non-zero exit status -1073741512
  *************** BROWSER STANDARD OUTPUT ***************
  
  *********** END OF BROWSER STANDARD OUTPUT ************
  ********************* BROWSER LOG *********************
  No log file
  ***************** END OF BROWSER LOG ******************
  Closing browser (pid=4576) ...
  Successfully shut down browser cooperatively
  Browser is closed.
  Traceback (most recent call last):
    File "e:\b\swarm_slave\w\ir\third_party\catapult\telemetry\telemetry\testing\browser_test_case.py", line 39, in WrappedMethod
      method(self)
    File "e:\b\swarm_slave\w\ir\tools\perf\core\stacktrace_unittest.py", line 22, in testValidDump
      self.assertTrue(c.exception.is_valid_dump)
  AssertionError: False is not true


So somehow the cdb.exe command fail.

Comment 2 by nednguyen@chromium.org, May 24 2018

Cc: brucedaw...@chromium.org
Somehow the cdb.exe call to create stack from the dump fail.

Bruce: any opinion?

I don't have a windows machine with me but this can be easily reproduce by:
1) Download the mini dump from gs://chrome-telemetry-output/minidump-2018-05-23_09-41-30-279905.dmp
2) Fetch the isolate in https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%281%29/80170
3) Run the cdb command: 

'['e:\\b\\swarm_slave\\w\\ir\\out\\Release\\cdb\\cdb.exe', '-y', 'e:\\b\\swarm_slave\\w\\ir\\out\\Release', '-c', '.ecxr;.lastevent;kb30;~*kb30;q', '-z', 'e:\\b\\swarm_slave\\w\\ittiixl2\\tmpmn_uw9\\reports\\f37bea3b-f8ad-4d42-bf2b-4916ebb344a5.dmp']'

Comment 3 by nednguyen@chromium.org, May 24 2018

Owner: ----
Status: Available (was: Assigned)
Ken: since you set up the cdb.exe command, can you take over this bug?
Project Member

Comment 5 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/216e6d16194a576c5fdaf126d2984e2d60ed32a7

commit 216e6d16194a576c5fdaf126d2984e2d60ed32a7
Author: Ned Nguyen <nednguyen@google.com>
Date: Thu May 24 20:09:14 2018

Disable core.stacktrace_unittest.TabStackTraceTest.testValidDump on win

TBR=kbr@chromium.org
NOTRY=true  # net_unittests flake

Bug:  846289 
Change-Id: I7fa42786ebdb448fd424e37a7c777e60df6b3c36
Reviewed-on: https://chromium-review.googlesource.com/1071868
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#561594}
[modify] https://crrev.com/216e6d16194a576c5fdaf126d2984e2d60ed32a7/tools/perf/core/stacktrace_unittest.py

Comment 6 by h...@chromium.org, May 25 2018

Mergedinto: 846313
Status: Duplicate (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, May 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69141da060f335106bfc7313fa1fde65cc72da91

commit 69141da060f335106bfc7313fa1fde65cc72da91
Author: nednguyen <nednguyen@google.com>
Date: Fri May 25 15:19:09 2018

Revert "Disable core.stacktrace_unittest.TabStackTraceTest.testValidDump on win"

This reverts commit 216e6d16194a576c5fdaf126d2984e2d60ed32a7.

Reason for revert: culrpit CL was reverted 

BUG: chromium:846313 

Original change's description:
> Disable core.stacktrace_unittest.TabStackTraceTest.testValidDump on win
> 
> TBR=kbr@chromium.org
> NOTRY=true  # net_unittests flake
> 
> Bug:  846289 
> Change-Id: I7fa42786ebdb448fd424e37a7c777e60df6b3c36
> Reviewed-on: https://chromium-review.googlesource.com/1071868
> Commit-Queue: Ned Nguyen <nednguyen@google.com>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Cr-Commit-Position: refs/heads/master@{#561594}

TBR=nednguyen@google.com

Change-Id: Ibf328d3ea480b094e47c5037a7498f198ef94e62
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  846289 
Reviewed-on: https://chromium-review.googlesource.com/1073091
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#561881}
[modify] https://crrev.com/69141da060f335106bfc7313fa1fde65cc72da91/tools/perf/core/stacktrace_unittest.py
Project Member

Comment 8 by bugdroid1@chromium.org, May 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8efd16ff6e3f26db9ac52e7d8bf8d65b723c668e

commit 8efd16ff6e3f26db9ac52e7d8bf8d65b723c668e
Author: Luna Lu <loonybear@chromium.org>
Date: Fri May 25 17:40:50 2018

Reland "Disable core.stacktrace_unittest.TabStackTraceTest.testValidDump on win"

This reverts commit 69141da060f335106bfc7313fa1fde65cc72da91.

Reason for revert: core.stacktrace_unittest.TabStackTraceTest.testValidDump is failing on Win 7, disabling this test for now. 

Original change's description:
> Revert "Disable core.stacktrace_unittest.TabStackTraceTest.testValidDump on win"
> 
> This reverts commit 216e6d16194a576c5fdaf126d2984e2d60ed32a7.
> 
> Reason for revert: culrpit CL was reverted 
> 
> BUG: chromium:846313 
> 
> Original change's description:
> > Disable core.stacktrace_unittest.TabStackTraceTest.testValidDump on win
> > 
> > TBR=kbr@chromium.org
> > NOTRY=true  # net_unittests flake
> > 
> > Bug:  846289 
> > Change-Id: I7fa42786ebdb448fd424e37a7c777e60df6b3c36
> > Reviewed-on: https://chromium-review.googlesource.com/1071868
> > Commit-Queue: Ned Nguyen <nednguyen@google.com>
> > Reviewed-by: Ned Nguyen <nednguyen@google.com>
> > Cr-Commit-Position: refs/heads/master@{#561594}
> 
> TBR=nednguyen@google.com
> 
> Change-Id: Ibf328d3ea480b094e47c5037a7498f198ef94e62
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  846289 
> Reviewed-on: https://chromium-review.googlesource.com/1073091
> Commit-Queue: Ned Nguyen <nednguyen@google.com>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Cr-Commit-Position: refs/heads/master@{#561881}

TBR=nednguyen@google.com

Change-Id: I039a5ffa03afbd50d79c57529d1b561def58ccdf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  846289 
Reviewed-on: https://chromium-review.googlesource.com/1073492
Reviewed-by: Luna Lu <loonybear@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561933}
[modify] https://crrev.com/8efd16ff6e3f26db9ac52e7d8bf8d65b723c668e/tools/perf/core/stacktrace_unittest.py

Comment 9 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 10 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry
►

Sign in to add a comment