Issue metadata
Sign in to add a comment
|
Regression : 'CONFIRM' button is seen enabled when any wrong password is entered in chrome://settings/lockScreen page |
||||||||||||||||||||||
Issue descriptionChrome Version: 68.0.3438.0/10710.0.0 dev-channel Reks,Daisy and Candy OS: Chrome What steps will reproduce the problem? (1)Sign into User -> Go to chrome://settings -> Now under 'People' section click on 'Screen lock' option 2)Enter wrong Password in 'Confirm your password' dialog box -> Now click on 'CONFIRM' button -> 'Invalid password' message is seen with selected password -> observe enabled 'CONFIRM' button is seen (Please refer Video and screenshot) Expected: 'CONFIRM' button should be disabled when any wrong password is entered Actual: Instead 'CONFIRM' button is seen enabled This is Regression Issue as same is working fine in M-66 Note : Issue is also seen on M-67 @sammiequon : Please confirm the Issue
,
May 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c17889dd2837b9220bbc5f23c7f461e72691ced commit 1c17889dd2837b9220bbc5f23c7f461e72691ced Author: Scott Chen <scottchen@chromium.org> Date: Thu May 31 22:25:51 2018 Settings: CrOS lock-screen password prompt logic fix. The confirm button disabled state was being updated one cycle too late. Bug: 847969 , 846278 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib02b69f2cb22c4aa134b4f18f5962611790da654 Reviewed-on: https://chromium-review.googlesource.com/1079791 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#563402} [modify] https://crrev.com/1c17889dd2837b9220bbc5f23c7f461e72691ced/chrome/browser/resources/settings/people_page/password_prompt_dialog.html [modify] https://crrev.com/1c17889dd2837b9220bbc5f23c7f461e72691ced/chrome/browser/resources/settings/people_page/password_prompt_dialog.js [modify] https://crrev.com/1c17889dd2837b9220bbc5f23c7f461e72691ced/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js
,
Jun 1 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by scottchen@chromium.org
, May 31 2018Status: Started (was: Assigned)